From: Eli Zaretskii <eliz@gnu.org>
To: Shane Mulligan <mullikine@gmail.com>
Cc: 48500@debbugs.gnu.org
Subject: bug#48500: 28.0.50; url-retrieve-synchronously exits abnormally due to pending keyboard input from terminal
Date: Tue, 18 May 2021 18:05:52 +0300 [thread overview]
Message-ID: <8335ukrsj3.fsf@gnu.org> (raw)
In-Reply-To: <87pmxo4kiu.wl-mullikine@gmail.com> (message from Shane Mulligan on Tue, 18 May 2021 18:35:05 +1200)
> Date: Tue, 18 May 2021 18:35:05 +1200
> From: Shane Mulligan <mullikine@gmail.com>
>
>
> `url-retrieve-synchronously` exits abnormally due to pending keyboard input from terminal
>
> This is related to a known issue documented in the `url-retrieve-synchronously` function of `url/url.el`.
> https://github.com/emacs-mirror/emacs/blob/7124598068ed267c34e1d70b49361f499fc31c9f/lisp/url/url.el#L297
>
> If the code is changed to the following (the addition of `while-no-input`) then `accept-process-output` will no longer be interrupted.
>
> (unless (or (while-no-input
> (with-local-quit
> (accept-process-output proc 1)))
> (null proc))
>
> The above possible fix is also documented here:
> https://github.com/emacs-helm/helm/pull/2419
>
> In order to easily reproduce the issue, one way is to run emacs through terminal and to try to use the function `helm-google-suggest` from package `helm`.
> https://github.com/emacs-helm/helm/issues/2417
>
> As you can see, the issue affects a lot of users. Currently, all users of terminal emacs that use helm.
> Unfortunately, it appears that it can't be handled outside of `url/url.el`.
I don't understand: with-local-quit isn't supposed to react to
keyboard input, only to C-g. So what kind of pending keyboard input
interrupts it in this case?
next prev parent reply other threads:[~2021-05-18 15:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 6:35 bug#48500: 28.0.50; url-retrieve-synchronously exits abnormally due to pending keyboard input from terminal Shane Mulligan
2021-05-18 15:05 ` Eli Zaretskii [this message]
[not found] ` <CACT87JpYLto5_HY8V=9+R3uvC614BxB_H_6gduW7hwnoJL1PDA@mail.gmail.com>
2021-05-18 16:54 ` Eli Zaretskii
2021-05-18 23:32 ` Shane Mulligan
2021-05-19 6:48 ` Shane Mulligan
2021-05-19 6:49 ` Shane Mulligan
2021-05-19 11:46 ` Shane Mulligan
2021-05-19 11:57 ` Eli Zaretskii
[not found] ` <CACT87JrC=pzVBJXLGP9k22OCnXTd0_3SYimsiD=AX9A7QsJS2A@mail.gmail.com>
2021-05-19 13:08 ` bug#48500: Fwd: " Shane Mulligan
2021-05-19 13:12 ` Shane Mulligan
2021-05-20 23:35 ` Shane Mulligan
2022-07-13 11:58 ` Lars Ingebrigtsen
2022-08-12 15:57 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8335ukrsj3.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=48500@debbugs.gnu.org \
--cc=mullikine@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).