From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#48500: 28.0.50; url-retrieve-synchronously exits abnormally due to pending keyboard input from terminal Date: Tue, 18 May 2021 18:05:52 +0300 Message-ID: <8335ukrsj3.fsf@gnu.org> References: <87pmxo4kiu.wl-mullikine@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2937"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48500@debbugs.gnu.org To: Shane Mulligan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 18 17:33:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lj1ic-0000eK-Fj for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 18 May 2021 17:33:14 +0200 Original-Received: from localhost ([::1]:53434 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lj1ib-0004Ua-Fo for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 18 May 2021 11:33:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59420) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lj1II-0003Zi-V3 for bug-gnu-emacs@gnu.org; Tue, 18 May 2021 11:06:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45380) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lj1II-0007VI-LK for bug-gnu-emacs@gnu.org; Tue, 18 May 2021 11:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lj1II-0002KP-Fx for bug-gnu-emacs@gnu.org; Tue, 18 May 2021 11:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 May 2021 15:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48500 X-GNU-PR-Package: emacs Original-Received: via spool by 48500-submit@debbugs.gnu.org id=B48500.16213503568937 (code B ref 48500); Tue, 18 May 2021 15:06:02 +0000 Original-Received: (at 48500) by debbugs.gnu.org; 18 May 2021 15:05:56 +0000 Original-Received: from localhost ([127.0.0.1]:56926 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lj1IC-0002K5-Gj for submit@debbugs.gnu.org; Tue, 18 May 2021 11:05:56 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37496) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lj1IA-0002Jt-TF for 48500@debbugs.gnu.org; Tue, 18 May 2021 11:05:55 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:39284) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lj1I5-0007Pr-M6; Tue, 18 May 2021 11:05:49 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1167 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lj1I5-0000EG-72; Tue, 18 May 2021 11:05:49 -0400 In-Reply-To: <87pmxo4kiu.wl-mullikine@gmail.com> (message from Shane Mulligan on Tue, 18 May 2021 18:35:05 +1200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:206800 Archived-At: > Date: Tue, 18 May 2021 18:35:05 +1200 > From: Shane Mulligan > > > `url-retrieve-synchronously` exits abnormally due to pending keyboard input from terminal > > This is related to a known issue documented in the `url-retrieve-synchronously` function of `url/url.el`. > https://github.com/emacs-mirror/emacs/blob/7124598068ed267c34e1d70b49361f499fc31c9f/lisp/url/url.el#L297 > > If the code is changed to the following (the addition of `while-no-input`) then `accept-process-output` will no longer be interrupted. > > (unless (or (while-no-input > (with-local-quit > (accept-process-output proc 1))) > (null proc)) > > The above possible fix is also documented here: > https://github.com/emacs-helm/helm/pull/2419 > > In order to easily reproduce the issue, one way is to run emacs through terminal and to try to use the function `helm-google-suggest` from package `helm`. > https://github.com/emacs-helm/helm/issues/2417 > > As you can see, the issue affects a lot of users. Currently, all users of terminal emacs that use helm. > Unfortunately, it appears that it can't be handled outside of `url/url.el`. I don't understand: with-local-quit isn't supposed to react to keyboard input, only to C-g. So what kind of pending keyboard input interrupts it in this case?