From: Eli Zaretskii <eliz@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: larsi@gnus.org, 45147@debbugs.gnu.org
Subject: bug#45147: Org-like cycling in outline-minor-mode
Date: Wed, 19 May 2021 15:10:37 +0300 [thread overview]
Message-ID: <8335uirkjm.fsf@gnu.org> (raw)
In-Reply-To: <87y2cc0xeh.fsf@mail.linkov.net> (message from Juri Linkov on Tue, 18 May 2021 23:12:46 +0300)
> From: Juri Linkov <juri@linkov.net>
> Date: Tue, 18 May 2021 23:12:46 +0300
> Cc: 45147@debbugs.gnu.org
>
> +(defcustom describe-bindings-after-hook '(describe-bindings-outline)
> + "Hook run at the end of `describe-bindings'."
> + :type 'hook
> + :options '(describe-bindings-outline)
> + :group 'help
> + :version "28.1")
What's the rationale for populating the hook by default? That's not
what we normally do: hooks are for Lisp programs to use, not for the
core functionality to invoke itself.
> +(defun describe-bindings-outline ()
> + "Hook to enable outlines in the output buffer of `describe-bindings'."
First, this is not a hook.
And second, if we want a feature whereby the buffer describing
bindings could be put in Outline mode, why not offer a simple option
for users to customize, not a hook for users to tweak? Once again,
having user options that accept only function values is
user-unfriendly.
Thanks.
next prev parent reply other threads:[~2021-05-19 12:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 19:15 bug#45147: Org-like cycling in outline-minor-mode Juri Linkov
2020-12-09 20:03 ` Juri Linkov
2020-12-14 20:35 ` Juri Linkov
2020-12-16 20:28 ` Juri Linkov
2021-03-03 19:12 ` Juri Linkov
2021-05-16 15:51 ` Lars Ingebrigtsen
2021-05-16 17:53 ` Juri Linkov
2021-05-17 13:57 ` Lars Ingebrigtsen
2021-05-18 20:12 ` Juri Linkov
2021-05-19 12:10 ` Eli Zaretskii [this message]
2021-05-19 16:14 ` Juri Linkov
2021-05-19 17:28 ` Eli Zaretskii
2021-05-20 18:37 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8335uirkjm.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=45147@debbugs.gnu.org \
--cc=juri@linkov.net \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).