From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#45147: Org-like cycling in outline-minor-mode Date: Wed, 19 May 2021 15:10:37 +0300 Message-ID: <8335uirkjm.fsf@gnu.org> References: <874kkuyhfx.fsf@mail.linkov.net> <87wnuoaw60.fsf@mail.linkov.net> <87zgwullsb.fsf@gnus.org> <87im3i7efm.fsf@mail.linkov.net> <87cztplaya.fsf@gnus.org> <87y2cc0xeh.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32543"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 45147@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 19 14:11:18 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ljL2j-0008I3-QW for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 19 May 2021 14:11:17 +0200 Original-Received: from localhost ([::1]:36038 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ljL2i-00021F-F1 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 19 May 2021 08:11:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51552) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljL2V-000212-He for bug-gnu-emacs@gnu.org; Wed, 19 May 2021 08:11:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46773) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ljL2U-0002Fk-5a for bug-gnu-emacs@gnu.org; Wed, 19 May 2021 08:11:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ljL2T-0005Ig-Vj for bug-gnu-emacs@gnu.org; Wed, 19 May 2021 08:11:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 May 2021 12:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45147 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 45147-submit@debbugs.gnu.org id=B45147.162142623620343 (code B ref 45147); Wed, 19 May 2021 12:11:01 +0000 Original-Received: (at 45147) by debbugs.gnu.org; 19 May 2021 12:10:36 +0000 Original-Received: from localhost ([127.0.0.1]:58319 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ljL24-0005I3-Do for submit@debbugs.gnu.org; Wed, 19 May 2021 08:10:36 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57834) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ljL23-0005Hq-1O for 45147@debbugs.gnu.org; Wed, 19 May 2021 08:10:35 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:46218) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ljL1v-0001qi-OU; Wed, 19 May 2021 08:10:28 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3971 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljL1v-0007ma-9d; Wed, 19 May 2021 08:10:27 -0400 In-Reply-To: <87y2cc0xeh.fsf@mail.linkov.net> (message from Juri Linkov on Tue, 18 May 2021 23:12:46 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:206879 Archived-At: > From: Juri Linkov > Date: Tue, 18 May 2021 23:12:46 +0300 > Cc: 45147@debbugs.gnu.org > > +(defcustom describe-bindings-after-hook '(describe-bindings-outline) > + "Hook run at the end of `describe-bindings'." > + :type 'hook > + :options '(describe-bindings-outline) > + :group 'help > + :version "28.1") What's the rationale for populating the hook by default? That's not what we normally do: hooks are for Lisp programs to use, not for the core functionality to invoke itself. > +(defun describe-bindings-outline () > + "Hook to enable outlines in the output buffer of `describe-bindings'." First, this is not a hook. And second, if we want a feature whereby the buffer describing bindings could be put in Outline mode, why not offer a simple option for users to customize, not a hook for users to tweak? Once again, having user options that accept only function values is user-unfriendly. Thanks.