unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Daniel Martín" <mardani29@yahoo.es>, "Richard Stallman" <rms@gnu.org>
Cc: arash@gnu.org, 51606@debbugs.gnu.org
Subject: bug#51606: 29.0.50; [PATCH] Show offscreen context with properties
Date: Fri, 05 Nov 2021 16:01:07 +0200	[thread overview]
Message-ID: <8335oaem70.fsf@gnu.org> (raw)
In-Reply-To: <m1pmresqu3.fsf@yahoo.es> (message from Daniel Martín on Fri, 05 Nov 2021 13:57:08 +0100)

> From: Daniel Martín <mardani29@yahoo.es>
> Cc: Arash Esbati <arash@gnu.org>,  51606@debbugs.gnu.org
> Date: Fri, 05 Nov 2021 13:57:08 +0100
> 
> >> paren.el now can show the context in minibuffer when
> >> `show-paren-context-when-offscreen' is non-nil (introduced in this
> >> change 9f505c476e).  Is it possible to extend this that text properties
> >> are not stripped?  I'm thinking about something like this:
> >
> > Why do we remove the properties in the first place?  Daniel, any
> > special reasons?
> 
> No reason other than being cautious and "follow the traditional behavior
> of blink-matching-open".  The code that I extracted from
> blink-matching-open to reuse it for show-paren-mode removed the text
> properties (see
> https://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/simple.el?h=emacs-28#n8608).
> If I'm not mistaken, this was apparently introduced in 2005 by Richard
> Stallman
> (https://git.savannah.gnu.org/cgit/emacs.git/commit/?h=emacs-28&id=1d0e3fc84f058248515f242c0484a0dabfac95aa),
> but I don't know the reasons for the change.  Perhaps it didn't look
> good on some TTY frames?

I'd be surprised.

Richard, do you remember why you removed text properties from the
blink-matching-open text it shows in the echo-area?





  reply	other threads:[~2021-11-05 14:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-05  9:40 bug#51606: 29.0.50; [PATCH] Show offscreen context with properties Arash Esbati
2021-11-05 12:02 ` Eli Zaretskii
2021-11-05 12:57   ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-05 14:01     ` Eli Zaretskii [this message]
2021-11-26 19:01       ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-29 11:03         ` Arash Esbati
2022-01-15 13:16           ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8335oaem70.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=51606@debbugs.gnu.org \
    --cc=arash@gnu.org \
    --cc=mardani29@yahoo.es \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).