From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#51606: 29.0.50; [PATCH] Show offscreen context with properties Date: Fri, 05 Nov 2021 16:01:07 +0200 Message-ID: <8335oaem70.fsf@gnu.org> References: <86y263hrds.fsf@gnu.org> <835yt6ero5.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5011"; mail-complaints-to="usenet@ciao.gmane.io" Cc: arash@gnu.org, 51606@debbugs.gnu.org To: Daniel =?UTF-8?Q?Mart=C3=ADn?= , Richard Stallman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 05 15:11:24 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mizwB-00018m-D7 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Nov 2021 15:11:23 +0100 Original-Received: from localhost ([::1]:50150 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mizwA-0007lC-Bb for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Nov 2021 10:11:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34980) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mizn8-0007CO-Jg for bug-gnu-emacs@gnu.org; Fri, 05 Nov 2021 10:02:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35160) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mizn8-0006Nd-9x for bug-gnu-emacs@gnu.org; Fri, 05 Nov 2021 10:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mizn8-0007K9-7t for bug-gnu-emacs@gnu.org; Fri, 05 Nov 2021 10:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Nov 2021 14:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51606 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51606-submit@debbugs.gnu.org id=B51606.163612090128124 (code B ref 51606); Fri, 05 Nov 2021 14:02:02 +0000 Original-Received: (at 51606) by debbugs.gnu.org; 5 Nov 2021 14:01:41 +0000 Original-Received: from localhost ([127.0.0.1]:46706 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mizmn-0007JY-4t for submit@debbugs.gnu.org; Fri, 05 Nov 2021 10:01:41 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37286) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mizmk-0007JN-Rv for 51606@debbugs.gnu.org; Fri, 05 Nov 2021 10:01:39 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:52364) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mizmf-0005PS-Ha; Fri, 05 Nov 2021 10:01:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=/o5xALQtwZXi65gR13cLk3XfVydvjU31QLpj24ql/N8=; b=ZU1UOuizOmISinMmDxhb nK0QfJGpH0Ifokp9Xj2Ej1RPkOkTcINwlinwtu51Y/MORhn42TgTXmsCOFs9qM+ADtmx99xRzRjP0 2VVCbluKWz4j1PGqyqiN8MNr0wb7SFKxIUMde2pghe8Cbz4n+0MNJMnT8bancIOayxYA3FEkitsfr AhaZUrPmPrK34A35jSyOAcYSdjkU5DltoKm5NgZ5ctF6kgQtutpGj8sS9k/e0IDXJlM+XFGHOMOCF EDPGrvPVIyoSaVRoP+5RQKqJGhGOIcxjiddk0GTzT9DVKGHjGIduG9HCUg3XrmLMmMkuZujgHzTSH x7x7L5EibxARlA==; Original-Received: from [87.69.77.57] (port=3796 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mizmX-0003zU-RL; Fri, 05 Nov 2021 10:01:26 -0400 In-Reply-To: (message from Daniel =?UTF-8?Q?Mart=C3=ADn?= on Fri, 05 Nov 2021 13:57:08 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:219002 Archived-At: > From: Daniel Martín > Cc: Arash Esbati , 51606@debbugs.gnu.org > Date: Fri, 05 Nov 2021 13:57:08 +0100 > > >> paren.el now can show the context in minibuffer when > >> `show-paren-context-when-offscreen' is non-nil (introduced in this > >> change 9f505c476e). Is it possible to extend this that text properties > >> are not stripped? I'm thinking about something like this: > > > > Why do we remove the properties in the first place? Daniel, any > > special reasons? > > No reason other than being cautious and "follow the traditional behavior > of blink-matching-open". The code that I extracted from > blink-matching-open to reuse it for show-paren-mode removed the text > properties (see > https://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/simple.el?h=emacs-28#n8608). > If I'm not mistaken, this was apparently introduced in 2005 by Richard > Stallman > (https://git.savannah.gnu.org/cgit/emacs.git/commit/?h=emacs-28&id=1d0e3fc84f058248515f242c0484a0dabfac95aa), > but I don't know the reasons for the change. Perhaps it didn't look > good on some TTY frames? I'd be surprised. Richard, do you remember why you removed text properties from the blink-matching-open text it shows in the echo-area?