* bug#66569: [PATCH] Fix eglot.texi (JSONRPC objects in Elisp) example
@ 2023-10-15 19:00 Matthew Woodcraft
2023-10-25 13:27 ` Eli Zaretskii
0 siblings, 1 reply; 2+ messages in thread
From: Matthew Woodcraft @ 2023-10-15 19:00 UTC (permalink / raw)
To: 66569
[-- Attachment #1: Type: text/plain, Size: 250 bytes --]
Tags: patch
The example in the eglot.texi "JSONRPC objects in Elisp" page has some
mistakes:
- the input is wrongly parenthesised for the intended output
- the serialised JSON text shows some trailing commas which are not in
fact generated
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-eglot.texi.patch --]
[-- Type: text/patch, Size: 1436 bytes --]
From a1a32a498e8c97775611cf04fc46d30d909e4200 Mon Sep 17 00:00:00 2001
From: Matthew Woodcraft <matthew@woodcraft.me.uk>
Date: Sun, 15 Oct 2023 19:50:26 +0100
Subject: [PATCH] Fix eglot.texi (JSONRPC objects in Elisp) example
* doc/misc/eglot.texi (JSONRPC objects in Elisp): Correct the example
---
doc/misc/eglot.texi | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/doc/misc/eglot.texi b/doc/misc/eglot.texi
index 3c1d44cd363..9ffea80b641 100644
--- a/doc/misc/eglot.texi
+++ b/doc/misc/eglot.texi
@@ -1237,8 +1237,8 @@ JSONRPC objects in Elisp
@lisp
(:pylsp (:plugins (:jedi_completion (:include_params t
:fuzzy t
- :cache_for ["pandas" "numpy"]
- :pylint (:enabled :json-false))))
+ :cache_for ["pandas" "numpy"])
+ :pylint (:enabled :json-false)))
:gopls (:usePlaceholders t))
@end lisp
@@ -1252,7 +1252,7 @@ JSONRPC objects in Elisp
"jedi_completion": @{
"include_params": true,
"fuzzy": true,
- "cache_for": [ "pandas", "numpy" ],
+ "cache_for": [ "pandas", "numpy" ]
@},
"pylint": @{
"enabled": false
@@ -1260,8 +1260,8 @@ JSONRPC objects in Elisp
@}
@},
"gopls": @{
- "usePlaceholders":true
- @},
+ "usePlaceholders": true
+ @}
@}
@end example
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* bug#66569: [PATCH] Fix eglot.texi (JSONRPC objects in Elisp) example
2023-10-15 19:00 bug#66569: [PATCH] Fix eglot.texi (JSONRPC objects in Elisp) example Matthew Woodcraft
@ 2023-10-25 13:27 ` Eli Zaretskii
0 siblings, 0 replies; 2+ messages in thread
From: Eli Zaretskii @ 2023-10-25 13:27 UTC (permalink / raw)
To: Matthew Woodcraft; +Cc: 66569-done
> From: Matthew Woodcraft <matthew@woodcraft.me.uk>
> Date: Sun, 15 Oct 2023 20:00:37 +0100
>
> The example in the eglot.texi "JSONRPC objects in Elisp" page has some
> mistakes:
>
> - the input is wrongly parenthesised for the intended output
>
> - the serialised JSON text shows some trailing commas which are not in
> fact generated
Thanks, installed on the emacs-29 branch, and closing the bug.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-25 13:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-15 19:00 bug#66569: [PATCH] Fix eglot.texi (JSONRPC objects in Elisp) example Matthew Woodcraft
2023-10-25 13:27 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).