* bug#10464: 24.0.92; mouse highlight regression
@ 2012-01-09 10:16 Chong Yidong
2012-01-09 12:32 ` Eli Zaretskii
2012-01-09 20:48 ` Eli Zaretskii
0 siblings, 2 replies; 6+ messages in thread
From: Chong Yidong @ 2012-01-09 10:16 UTC (permalink / raw)
To: 10464
With latest trunk, the (non-automated) redisplay testsuite is failing in
Test 2. Here is a simplified recipe:
emacs -Q
Insert the following:
(let ((opoint (point))
overlay)
(insert "XXX")
(setq overlay (make-overlay opoint (point)))
(overlay-put overlay 'display "XXX")
(overlay-put overlay 'mouse-face 'highlight))
M-x eval-buffer RET
Move the mouse over the XXX that was inserted.
Result: multiple lines are highlighted, from the end of the first buffer
line to the end of the display string.
Expected result (works in Emacs 23): only the XXX is highlighted.
In GNU Emacs 24.0.92.9 (x86_64-unknown-linux-gnu, GTK+ Version 3.2.0)
of 2012-01-09 on furball
Windowing system distributor `The X.Org Foundation', version 11.0.11004000
configured using `configure '--with-x-toolkit=gtk3' 'CFLAGS=-g''
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#10464: 24.0.92; mouse highlight regression
2012-01-09 10:16 bug#10464: 24.0.92; mouse highlight regression Chong Yidong
@ 2012-01-09 12:32 ` Eli Zaretskii
2012-01-09 20:48 ` Eli Zaretskii
1 sibling, 0 replies; 6+ messages in thread
From: Eli Zaretskii @ 2012-01-09 12:32 UTC (permalink / raw)
To: Chong Yidong; +Cc: 10464
> From: Chong Yidong <cyd@gnu.org>
> Date: Mon, 09 Jan 2012 18:16:38 +0800
>
> With latest trunk, the (non-automated) redisplay testsuite is failing in
> Test 2. Here is a simplified recipe:
>
> emacs -Q
>
> Insert the following:
>
> (let ((opoint (point))
> overlay)
> (insert "XXX")
> (setq overlay (make-overlay opoint (point)))
> (overlay-put overlay 'display "XXX")
> (overlay-put overlay 'mouse-face 'highlight))
>
> M-x eval-buffer RET
> Move the mouse over the XXX that was inserted.
>
> Result: multiple lines are highlighted, from the end of the first buffer
> line to the end of the display string.
>
> Expected result (works in Emacs 23): only the XXX is highlighted.
Did this work with Emacs 24 at some recent time (or ever), i.e. do you
remember this working for you past Emacs 23? If it did, it will allow
me to consider only the latest changes.
TIA
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#10464: 24.0.92; mouse highlight regression
2012-01-09 10:16 bug#10464: 24.0.92; mouse highlight regression Chong Yidong
2012-01-09 12:32 ` Eli Zaretskii
@ 2012-01-09 20:48 ` Eli Zaretskii
2012-01-10 4:21 ` Chong Yidong
1 sibling, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2012-01-09 20:48 UTC (permalink / raw)
To: Chong Yidong; +Cc: 10464
> From: Chong Yidong <cyd@gnu.org>
> Date: Mon, 09 Jan 2012 18:16:38 +0800
>
> With latest trunk, the (non-automated) redisplay testsuite is failing in
> Test 2. Here is a simplified recipe:
>
> emacs -Q
>
> Insert the following:
>
> (let ((opoint (point))
> overlay)
> (insert "XXX")
> (setq overlay (make-overlay opoint (point)))
> (overlay-put overlay 'display "XXX")
> (overlay-put overlay 'mouse-face 'highlight))
>
> M-x eval-buffer RET
> Move the mouse over the XXX that was inserted.
>
> Result: multiple lines are highlighted, from the end of the first buffer
> line to the end of the display string.
>
> Expected result (works in Emacs 23): only the XXX is highlighted.
I think I fixed this (trunk revision 106827), but please test,
including any variations on this theme you can come up with. The
bidi-aware mouse highlight is tricky business, especially when display
strings are involved.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#10464: 24.0.92; mouse highlight regression
2012-01-09 20:48 ` Eli Zaretskii
@ 2012-01-10 4:21 ` Chong Yidong
2012-01-10 5:26 ` Eli Zaretskii
2012-01-11 19:47 ` Eli Zaretskii
0 siblings, 2 replies; 6+ messages in thread
From: Chong Yidong @ 2012-01-10 4:21 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 10464
Eli Zaretskii <eliz@gnu.org> writes:
> I think I fixed this (trunk revision 106827), but please test,
> including any variations on this theme you can come up with. The
> bidi-aware mouse highlight is tricky business, especially when display
> strings are involved.
Thanks for the very quick fix.
This specific case is indeed fixed, but there is still a failing corner
case in the redisplay testsuite. Load test/redisplay-testsuite.el, do
M-x test-redisplay, and go to the very last case in Test 2.
When the mouse is over the XXX, the highlight only extends to the end of
the text, whereas it's expected to go to the end of the line. This is
the case where there's an overlay with "XXX\n" as the display string and
a mouse face.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#10464: 24.0.92; mouse highlight regression
2012-01-10 4:21 ` Chong Yidong
@ 2012-01-10 5:26 ` Eli Zaretskii
2012-01-11 19:47 ` Eli Zaretskii
1 sibling, 0 replies; 6+ messages in thread
From: Eli Zaretskii @ 2012-01-10 5:26 UTC (permalink / raw)
To: Chong Yidong; +Cc: 10464
> From: Chong Yidong <cyd@gnu.org>
> Cc: 10464@debbugs.gnu.org
> Date: Tue, 10 Jan 2012 12:21:10 +0800
>
> When the mouse is over the XXX, the highlight only extends to the end of
> the text, whereas it's expected to go to the end of the line. This is
> the case where there's an overlay with "XXX\n" as the display string and
> a mouse face.
I will look into it, but (compatibility with Emacs 23 aside) how
important is it to have the entire display line come up in mouse color
in this case? I could make an argument that what we do in Emacs 24 is
actually better, since the newline is not shown on display as any
tangible glyph.
IOW, are there practical use cases where this difference matters?
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#10464: 24.0.92; mouse highlight regression
2012-01-10 4:21 ` Chong Yidong
2012-01-10 5:26 ` Eli Zaretskii
@ 2012-01-11 19:47 ` Eli Zaretskii
1 sibling, 0 replies; 6+ messages in thread
From: Eli Zaretskii @ 2012-01-11 19:47 UTC (permalink / raw)
To: Chong Yidong; +Cc: 10464-done
> From: Chong Yidong <cyd@gnu.org>
> Cc: 10464@debbugs.gnu.org
> Date: Tue, 10 Jan 2012 12:21:10 +0800
>
> Thanks for the very quick fix.
>
> This specific case is indeed fixed, but there is still a failing corner
> case in the redisplay testsuite. Load test/redisplay-testsuite.el, do
> M-x test-redisplay, and go to the very last case in Test 2.
>
> When the mouse is over the XXX, the highlight only extends to the end of
> the text, whereas it's expected to go to the end of the line. This is
> the case where there's an overlay with "XXX\n" as the display string and
> a mouse face.
Fixed (trunk revision 106848).
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-01-11 19:47 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-09 10:16 bug#10464: 24.0.92; mouse highlight regression Chong Yidong
2012-01-09 12:32 ` Eli Zaretskii
2012-01-09 20:48 ` Eli Zaretskii
2012-01-10 4:21 ` Chong Yidong
2012-01-10 5:26 ` Eli Zaretskii
2012-01-11 19:47 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).