From: Eli Zaretskii <eliz@gnu.org>
To: Ivan Shmakov <ivan@siamics.net>
Cc: 19556@debbugs.gnu.org
Subject: bug#19556: eww: make URI rewriting fully customizable
Date: Sat, 10 Jan 2015 16:19:07 +0200 [thread overview]
Message-ID: <831tn27m78.fsf@gnu.org> (raw)
In-Reply-To: <87sifi22rg.fsf@violet.siamics.net>
> From: Ivan Shmakov <ivan@siamics.net>
> Date: Sat, 10 Jan 2015 13:17:55 +0000
>
> +(defcustom eww-uri-rewrite-hook
> + '(eww-uri-file
> + eww-uri-not-supported
> + eww-uri-remote-prepend-http
> + eww-uri-search)
> + "List of functions called to deal with the argument to `eww'.
> +These functions will be called in order, with the argument given to
> +`eww' passed as their only argument, until one returns non-nil. The
> +value returned will be used as the URI to fetch.
> +
> +Should no function of those listed return non-nil, `eww' will use its
> +argument unaltered."
> + :version "25.1"
> + :group 'eww
> + :type 'hook
> + :options '(eww-uri-file
> + eww-uri-not-supported
> + eww-uri-remote-prepend-http
> + eww-uri-search))
Why put the "standard" rules into the defcustom? why not leave them in
place as "plan B", and leave the hook for customizations only? That's
what hooks are normally for -- _modifying_ the default behavior, not
supplanting it. E.g., with your suggestion, what happens if someone
customizes the value to nil?
Thanks.
next prev parent reply other threads:[~2015-01-10 14:19 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-10 13:17 bug#19556: eww: make URI rewriting fully customizable Ivan Shmakov
2015-01-10 14:19 ` Eli Zaretskii [this message]
2015-01-10 14:40 ` Ivan Shmakov
2015-01-10 16:01 ` Eli Zaretskii
2015-01-10 17:20 ` Ivan Shmakov
2015-01-10 17:37 ` Eli Zaretskii
2015-01-10 18:05 ` Ivan Shmakov
2015-01-10 14:29 ` Lars Magne Ingebrigtsen
2015-01-10 14:44 ` Ivan Shmakov
2015-01-10 14:58 ` Lars Magne Ingebrigtsen
2015-01-10 15:59 ` Ivan Shmakov
2015-01-10 16:08 ` Lars Magne Ingebrigtsen
2015-01-10 16:22 ` Lars Magne Ingebrigtsen
2015-01-10 18:24 ` Ivan Shmakov
2015-12-25 7:03 ` Lars Ingebrigtsen
2015-12-26 9:30 ` Ivan Shmakov
2015-01-10 15:02 ` Lars Magne Ingebrigtsen
2015-01-10 18:11 ` Ivan Shmakov
2015-01-11 14:58 ` Lars Magne Ingebrigtsen
2015-01-11 15:06 ` Lars Magne Ingebrigtsen
2015-01-11 18:22 ` Ivan Shmakov
2015-01-11 20:03 ` Eli Zaretskii
2015-01-11 20:17 ` Ivan Shmakov
2015-01-11 20:40 ` Eli Zaretskii
2015-01-11 21:46 ` Lars Magne Ingebrigtsen
2015-01-11 1:59 ` Stefan Monnier
2015-01-11 6:25 ` Ivan Shmakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831tn27m78.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=19556@debbugs.gnu.org \
--cc=ivan@siamics.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).