From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#19556: eww: make URI rewriting fully customizable Date: Sat, 10 Jan 2015 16:19:07 +0200 Message-ID: <831tn27m78.fsf@gnu.org> References: <87sifi22rg.fsf@violet.siamics.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1420899618 2796 80.91.229.3 (10 Jan 2015 14:20:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 10 Jan 2015 14:20:18 +0000 (UTC) Cc: 19556@debbugs.gnu.org To: Ivan Shmakov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 10 15:20:11 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Y9wtf-0001ds-7I for geb-bug-gnu-emacs@m.gmane.org; Sat, 10 Jan 2015 15:20:11 +0100 Original-Received: from localhost ([::1]:55208 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y9wte-00060M-BW for geb-bug-gnu-emacs@m.gmane.org; Sat, 10 Jan 2015 09:20:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58391) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y9wtb-0005zY-Ct for bug-gnu-emacs@gnu.org; Sat, 10 Jan 2015 09:20:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y9wtX-0005mg-Hb for bug-gnu-emacs@gnu.org; Sat, 10 Jan 2015 09:20:07 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:60477) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y9wtX-0005lv-F3 for bug-gnu-emacs@gnu.org; Sat, 10 Jan 2015 09:20:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Y9wtW-0003a6-Ld for bug-gnu-emacs@gnu.org; Sat, 10 Jan 2015 09:20:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Jan 2015 14:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19556 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19556-submit@debbugs.gnu.org id=B19556.142089955313702 (code B ref 19556); Sat, 10 Jan 2015 14:20:02 +0000 Original-Received: (at 19556) by debbugs.gnu.org; 10 Jan 2015 14:19:13 +0000 Original-Received: from localhost ([127.0.0.1]:41610 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y9wsj-0003Yw-CC for submit@debbugs.gnu.org; Sat, 10 Jan 2015 09:19:13 -0500 Original-Received: from mtaout28.012.net.il ([80.179.55.184]:48925) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y9wsf-0003Yh-Vq for 19556@debbugs.gnu.org; Sat, 10 Jan 2015 09:19:11 -0500 Original-Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0NHY00D00SJY9N00@mtaout28.012.net.il> for 19556@debbugs.gnu.org; Sat, 10 Jan 2015 16:17:05 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NHY0081LT0HQV60@mtaout28.012.net.il>; Sat, 10 Jan 2015 16:17:05 +0200 (IST) In-reply-to: <87sifi22rg.fsf@violet.siamics.net> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:98173 Archived-At: > From: Ivan Shmakov > Date: Sat, 10 Jan 2015 13:17:55 +0000 > > +(defcustom eww-uri-rewrite-hook > + '(eww-uri-file > + eww-uri-not-supported > + eww-uri-remote-prepend-http > + eww-uri-search) > + "List of functions called to deal with the argument to `eww'. > +These functions will be called in order, with the argument given to > +`eww' passed as their only argument, until one returns non-nil. The > +value returned will be used as the URI to fetch. > + > +Should no function of those listed return non-nil, `eww' will use its > +argument unaltered." > + :version "25.1" > + :group 'eww > + :type 'hook > + :options '(eww-uri-file > + eww-uri-not-supported > + eww-uri-remote-prepend-http > + eww-uri-search)) Why put the "standard" rules into the defcustom? why not leave them in place as "plan B", and leave the hook for customizations only? That's what hooks are normally for -- _modifying_ the default behavior, not supplanting it. E.g., with your suggestion, what happens if someone customizes the value to nil? Thanks.