unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: npostavs@users.sourceforge.net
Cc: 16406@debbugs.gnu.org
Subject: bug#16406: load prefers directories rather than searching load-path
Date: Sat, 03 Sep 2016 20:32:14 +0300	[thread overview]
Message-ID: <831t10evoh.fsf@gnu.org> (raw)
In-Reply-To: <878tv9ndce.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net)

> From: npostavs@users.sourceforge.net
> Date: Sat, 03 Sep 2016 12:43:29 -0400
> Cc: 16406@debbugs.gnu.org
> 
> > Seems simple enough to fix, here is a patch (this also covers #17848
> > "add suffix search to -l even when directory part in argument"):
> 
> That one broke normal loading.  Here's a new patch.

Instead of doing the search by hand, wouldn't it be better to teach
'load' to ignore directories?  Or do we have a use case where finding
a directory in 'load' would make sense?

IOW, isn't "'load' prefers directories" the actual problem we should
fix, rather than only fixing the startup problem?

I do agree that the file-exists-p test in command-line-1 should be
replaced with a test that doesn't let directories through.  But I
don't understand why using locate-file here is a good idea.

Thanks.





  reply	other threads:[~2016-09-03 17:32 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-10  5:23 bug#16406: load prefers directories rather than searching load-path Glenn Morris
2014-01-10 14:46 ` Stefan Monnier
2016-08-21 16:35 ` npostavs
2016-09-03 16:43   ` npostavs
2016-09-03 17:32     ` Eli Zaretskii [this message]
2016-09-03 18:43       ` npostavs
2016-09-03 19:00         ` Eli Zaretskii
2016-09-03 19:12           ` npostavs
2016-09-03 19:27             ` Eli Zaretskii
2016-09-07 23:27               ` npostavs
2016-09-04 22:06       ` bug#17848: #17848 add suffix search to -l even when directory part in argument (WAS: Re: bug#16406: load prefers directories...) npostavs
2016-09-05 15:07         ` Eli Zaretskii
2016-09-05 22:59           ` bug#17848: #17848 add suffix search to -l even when directory part in argument npostavs
2016-09-06 15:05             ` Eli Zaretskii
2016-09-08  0:06               ` npostavs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=831t10evoh.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=16406@debbugs.gnu.org \
    --cc=npostavs@users.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).