From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#16406: load prefers directories rather than searching load-path Date: Sat, 03 Sep 2016 20:32:14 +0300 Message-ID: <831t10evoh.fsf@gnu.org> References: <8737lyulkl.fsf@users.sourceforge.net> <878tv9ndce.fsf@users.sourceforge.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1472924009 30130 195.159.176.226 (3 Sep 2016 17:33:29 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 3 Sep 2016 17:33:29 +0000 (UTC) Cc: 16406@debbugs.gnu.org To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Sep 03 19:33:25 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bgEoi-0006qf-5v for geb-bug-gnu-emacs@m.gmane.org; Sat, 03 Sep 2016 19:33:20 +0200 Original-Received: from localhost ([::1]:47257 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgEod-0000mt-1h for geb-bug-gnu-emacs@m.gmane.org; Sat, 03 Sep 2016 13:33:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58739) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgEoV-0000iw-Rk for bug-gnu-emacs@gnu.org; Sat, 03 Sep 2016 13:33:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bgEoQ-0006vR-MF for bug-gnu-emacs@gnu.org; Sat, 03 Sep 2016 13:33:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51163) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgEoQ-0006vN-Iq for bug-gnu-emacs@gnu.org; Sat, 03 Sep 2016 13:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bgEoQ-0005hy-F6 for bug-gnu-emacs@gnu.org; Sat, 03 Sep 2016 13:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 Sep 2016 17:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16406 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 16406-submit@debbugs.gnu.org id=B16406.147292395421907 (code B ref 16406); Sat, 03 Sep 2016 17:33:02 +0000 Original-Received: (at 16406) by debbugs.gnu.org; 3 Sep 2016 17:32:34 +0000 Original-Received: from localhost ([127.0.0.1]:48875 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bgEny-0005hH-7o for submit@debbugs.gnu.org; Sat, 03 Sep 2016 13:32:34 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:39491) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bgEnw-0005h2-Cm for 16406@debbugs.gnu.org; Sat, 03 Sep 2016 13:32:32 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bgEnn-0006tw-5L for 16406@debbugs.gnu.org; Sat, 03 Sep 2016 13:32:27 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43262) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgEnn-0006tr-28; Sat, 03 Sep 2016 13:32:23 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4047 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bgEnl-0000Zo-4i; Sat, 03 Sep 2016 13:32:22 -0400 In-reply-to: <878tv9ndce.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:122891 Archived-At: > From: npostavs@users.sourceforge.net > Date: Sat, 03 Sep 2016 12:43:29 -0400 > Cc: 16406@debbugs.gnu.org > > > Seems simple enough to fix, here is a patch (this also covers #17848 > > "add suffix search to -l even when directory part in argument"): > > That one broke normal loading. Here's a new patch. Instead of doing the search by hand, wouldn't it be better to teach 'load' to ignore directories? Or do we have a use case where finding a directory in 'load' would make sense? IOW, isn't "'load' prefers directories" the actual problem we should fix, rather than only fixing the startup problem? I do agree that the file-exists-p test in command-line-1 should be replaced with a test that doesn't let directories through. But I don't understand why using locate-file here is a good idea. Thanks.