unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: 31312@debbugs.gnu.org, npostavs@gmail.com, cyrus.and@gmail.com
Subject: bug#31312: Segmentation fault with doom-emacs, NeoTree and Zoom
Date: Wed, 02 May 2018 18:03:45 +0300	[thread overview]
Message-ID: <831seuqeum.fsf@gnu.org> (raw)
In-Reply-To: <5AE9C062.9010203@gmx.at> (message from martin rudalics on Wed, 02 May 2018 15:42:58 +0200)

> Date: Wed, 02 May 2018 15:42:58 +0200
> From: martin rudalics <rudalics@gmx.at>
> CC: 31312@debbugs.gnu.org, Andrea Cardaci <cyrus.and@gmail.com>
> 
>  > So we need the same defense after prepare_menu_bars as we
>  > have after do_pending_changes, I think.
> 
> If you mean something like
> 
>    if (WINDOWP (selected_window) && (w = XWINDOW (selected_window)) != sw)
>      sw = w;
> 
> I'm afraid that this would fail since selected_window has no buffer
> any more (or may have even been recycled already).

Is that a fact?  I might be mistaken, but my take on what Noam found
was that the selected window is OK, it's just that the window held in
W is dead (i.e. it was deleted inside the tempest that happened in
run_window_size_change_functions called by prepare_menu_bars).  So my
suggestion is to update W with the new selected window.

In general, if the selected window has no buffer, we are in deep
trouble, and not just in redisplay.  So I very much hope this is not
what happens here.





  reply	other threads:[~2018-05-02 15:03 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-29 10:56 bug#31312: Segmentation fault with doom-emacs, NeoTree and Zoom Andrea Cardaci
2018-05-01 13:25 ` Noam Postavsky
2018-05-01 14:33   ` martin rudalics
2018-05-01 23:10     ` Noam Postavsky
2018-05-02  6:16       ` martin rudalics
2018-05-02 11:52         ` Eli Zaretskii
2018-05-02 12:21         ` Noam Postavsky
2018-05-02 12:45           ` Eli Zaretskii
2018-05-02 13:27             ` Andrea Cardaci
2018-05-02 13:47               ` martin rudalics
2018-05-02 15:06                 ` Andrea Cardaci
2018-05-02 15:06               ` Eli Zaretskii
2018-05-02 15:14                 ` Andrea Cardaci
2018-05-02 15:30                   ` Eli Zaretskii
2018-05-02 13:42             ` martin rudalics
2018-05-02 15:03               ` Eli Zaretskii [this message]
2018-05-02 18:43                 ` martin rudalics
2018-05-02 19:02                   ` Eli Zaretskii
2018-05-03  7:11                     ` martin rudalics
2018-05-03  0:04               ` Noam Postavsky
2018-05-03  2:32                 ` Eli Zaretskii
2018-05-03 12:21                   ` Noam Postavsky
2018-05-03 17:54                     ` Eli Zaretskii
2018-05-04  1:18                       ` Noam Postavsky
2018-05-02 13:42           ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=831seuqeum.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=31312@debbugs.gnu.org \
    --cc=cyrus.and@gmail.com \
    --cc=npostavs@gmail.com \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).