From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#31312: Segmentation fault with doom-emacs, NeoTree and Zoom Date: Wed, 02 May 2018 18:03:45 +0300 Message-ID: <831seuqeum.fsf@gnu.org> References: <87r2mvo6c8.fsf@gmail.com> <5AE87AA3.6050602@gmx.at> <87o9hznfam.fsf@gmail.com> <5AE957BA.6000809@gmx.at> <87fu3ant8k.fsf@gmail.com> <0DFE6C67-38C5-45EE-B658-8BEF80B595FF@gnu.org> <5AE9C062.9010203@gmx.at> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1525273476 29818 195.159.176.226 (2 May 2018 15:04:36 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 2 May 2018 15:04:36 +0000 (UTC) Cc: 31312@debbugs.gnu.org, npostavs@gmail.com, cyrus.and@gmail.com To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 02 17:04:32 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fDtJ1-0007fm-NO for geb-bug-gnu-emacs@m.gmane.org; Wed, 02 May 2018 17:04:31 +0200 Original-Received: from localhost ([::1]:50981 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fDtL8-0006wh-Cb for geb-bug-gnu-emacs@m.gmane.org; Wed, 02 May 2018 11:06:42 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36772) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fDtJd-00060q-UO for bug-gnu-emacs@gnu.org; Wed, 02 May 2018 11:05:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fDtJW-0001tl-98 for bug-gnu-emacs@gnu.org; Wed, 02 May 2018 11:05:09 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39270) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fDtJW-0001te-4q for bug-gnu-emacs@gnu.org; Wed, 02 May 2018 11:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fDtJV-0003DD-K6 for bug-gnu-emacs@gnu.org; Wed, 02 May 2018 11:05:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 May 2018 15:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31312 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 31312-submit@debbugs.gnu.org id=B31312.152527344712286 (code B ref 31312); Wed, 02 May 2018 15:05:01 +0000 Original-Received: (at 31312) by debbugs.gnu.org; 2 May 2018 15:04:07 +0000 Original-Received: from localhost ([127.0.0.1]:47167 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fDtId-0003C6-IR for submit@debbugs.gnu.org; Wed, 02 May 2018 11:04:07 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:45414) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fDtIb-0003Bb-AG for 31312@debbugs.gnu.org; Wed, 02 May 2018 11:04:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fDtIV-0001ZC-72 for 31312@debbugs.gnu.org; Wed, 02 May 2018 11:04:00 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48774) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fDtIQ-0001Xt-NF; Wed, 02 May 2018 11:03:54 -0400 Original-Received: from [176.228.60.248] (port=4605 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fDtIP-0005OH-Pd; Wed, 02 May 2018 11:03:54 -0400 In-reply-to: <5AE9C062.9010203@gmx.at> (message from martin rudalics on Wed, 02 May 2018 15:42:58 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:145929 Archived-At: > Date: Wed, 02 May 2018 15:42:58 +0200 > From: martin rudalics > CC: 31312@debbugs.gnu.org, Andrea Cardaci > > > So we need the same defense after prepare_menu_bars as we > > have after do_pending_changes, I think. > > If you mean something like > > if (WINDOWP (selected_window) && (w = XWINDOW (selected_window)) != sw) > sw = w; > > I'm afraid that this would fail since selected_window has no buffer > any more (or may have even been recycled already). Is that a fact? I might be mistaken, but my take on what Noam found was that the selected window is OK, it's just that the window held in W is dead (i.e. it was deleted inside the tempest that happened in run_window_size_change_functions called by prepare_menu_bars). So my suggestion is to update W with the new selected window. In general, if the selected window has no buffer, we are in deep trouble, and not just in redisplay. So I very much hope this is not what happens here.