unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Dima Kogan <dima@secretsauce.net>
Cc: 25271@debbugs.gnu.org
Subject: bug#25271: Committed
Date: Mon, 18 Jun 2018 19:29:13 +0300	[thread overview]
Message-ID: <831sd4t5wm.fsf@gnu.org> (raw)
In-Reply-To: <87bmc8ljdb.fsf@secretsauce.net> (message from Dima Kogan on Sun,  17 Jun 2018 23:05:36 -0700)

> From: Dima Kogan <dima@secretsauce.net>
> Date: Sun, 17 Jun 2018 23:05:36 -0700
> 
> Patches committed in ba2ddadb5378351e8003c8e172b52bfabaa27554

Thank you for working on this.

In the future, please observe the following minor gotchas (I fixed
them for this changeset):

  . The commit log entries should be full sentences: start with a
    capital letter and end with a period.

  . A new or modified defcustom should have a suitable :version tag
    that records the version where it was introduced or its value
    changed.

  . Please update the manual(s) to reflect the changes, otherwise this
    job is left for the pretest phase, where it delays the release,
    and also increases the risk of having inaccurate documentation
    (due to the time that passed and people who forget).

  . NEWS entries should preferably have their first line a complete
    sentence that summarizes the entry.  This is so NEWS could be
    usefully read in Outline mode after folding the body of the
    entries.





      reply	other threads:[~2018-06-18 16:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-25 19:54 bug#25271: 26.0.50; [PATCH] comint-insert-previous-argument logic improvements Dima Kogan
2018-05-02  1:36 ` Noam Postavsky
2018-06-18  2:25   ` Dima Kogan
2018-06-18  2:30     ` Noam Postavsky
2018-06-18  6:05 ` bug#25271: Committed Dima Kogan
2018-06-18 16:29   ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=831sd4t5wm.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=25271@debbugs.gnu.org \
    --cc=dima@secretsauce.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).