From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#25271: Committed Date: Mon, 18 Jun 2018 19:29:13 +0300 Message-ID: <831sd4t5wm.fsf@gnu.org> References: <87eg0veqe2.fsf@secretsauce.net> <87bmc8ljdb.fsf@secretsauce.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1529340124 26375 195.159.176.226 (18 Jun 2018 16:42:04 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 18 Jun 2018 16:42:04 +0000 (UTC) Cc: 25271@debbugs.gnu.org To: Dima Kogan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 18 18:42:00 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fUxE8-0006fj-2E for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Jun 2018 18:42:00 +0200 Original-Received: from localhost ([::1]:35916 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fUxGD-0003wx-DW for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Jun 2018 12:44:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47198) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fUx2e-0003KL-P9 for bug-gnu-emacs@gnu.org; Mon, 18 Jun 2018 12:30:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fUx2Y-0003c0-Vn for bug-gnu-emacs@gnu.org; Mon, 18 Jun 2018 12:30:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:47349) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fUx2Y-0003bu-Rw for bug-gnu-emacs@gnu.org; Mon, 18 Jun 2018 12:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fUx2Y-0007nn-KH for bug-gnu-emacs@gnu.org; Mon, 18 Jun 2018 12:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Jun 2018 16:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25271 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 25271-submit@debbugs.gnu.org id=B25271.152933936529905 (code B ref 25271); Mon, 18 Jun 2018 16:30:02 +0000 Original-Received: (at 25271) by debbugs.gnu.org; 18 Jun 2018 16:29:25 +0000 Original-Received: from localhost ([127.0.0.1]:55243 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fUx1x-0007mH-BM for submit@debbugs.gnu.org; Mon, 18 Jun 2018 12:29:25 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:56001) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fUx1w-0007m3-83 for 25271@debbugs.gnu.org; Mon, 18 Jun 2018 12:29:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fUx1n-0003DK-3g for 25271@debbugs.gnu.org; Mon, 18 Jun 2018 12:29:19 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41762) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fUx1m-0003D3-VH; Mon, 18 Jun 2018 12:29:15 -0400 Original-Received: from [176.228.60.248] (port=4697 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fUx1m-0007Op-FD; Mon, 18 Jun 2018 12:29:14 -0400 In-reply-to: <87bmc8ljdb.fsf@secretsauce.net> (message from Dima Kogan on Sun, 17 Jun 2018 23:05:36 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147603 Archived-At: > From: Dima Kogan > Date: Sun, 17 Jun 2018 23:05:36 -0700 > > Patches committed in ba2ddadb5378351e8003c8e172b52bfabaa27554 Thank you for working on this. In the future, please observe the following minor gotchas (I fixed them for this changeset): . The commit log entries should be full sentences: start with a capital letter and end with a period. . A new or modified defcustom should have a suitable :version tag that records the version where it was introduced or its value changed. . Please update the manual(s) to reflect the changes, otherwise this job is left for the pretest phase, where it delays the release, and also increases the risk of having inaccurate documentation (due to the time that passed and people who forget). . NEWS entries should preferably have their first line a complete sentence that summarizes the entry. This is so NEWS could be usefully read in Outline mode after folding the body of the entries.