From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 11303@debbugs.gnu.org, kellydeanch@yahoo.com
Subject: bug#11303: Whitespace mode causes auto-save to malfunction
Date: Fri, 16 Jul 2021 15:00:56 +0300 [thread overview]
Message-ID: <831r7y5uyv.fsf@gnu.org> (raw)
In-Reply-To: <87r1fya2wv.fsf@gnus.org> (message from Lars Ingebrigtsen on Fri, 16 Jul 2021 13:55:44 +0200)
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Fri, 16 Jul 2021 13:55:44 +0200
> Cc: 11303@debbugs.gnu.org
>
> Kelly Dean <kellydeanch@yahoo.com> writes:
>
> > Start Emacs with no options.
> > Open a file, press space, wait for the timeout, press C-g, and wait
> > for the timeout again. Notice that Emacs does write the auto-save file
> > again, even though the buffer hasn't changed since the last
> > auto-save. This is not the correct behavior.
>
> This problem is still present in Emacs 28.
>
> Poking around a bit at this, it seems that it's the call to
>
> (jit-lock-refontify (point-min) (point-max))
>
> that makes `M-x do-auto-save' auto-save again (even if nothing has
> changed except the text properties in the buffer).
>
> I.e., doing
>
> (put-text-property 1 3 'face 'bold)
>
> will make the buffer eligible for auto-saving again, even if putting
> those text properties into the buffer doesn't switch from unmodified to
> modified.
>
> That's pretty inconsistent behaviour, at least? I'm guessing this stems
> from text properties upping the BUF_MODIFF, but not changing the buffer
> modification status.
>
> Does this sound like the correct analysis? If so, what can we do about
> it? (`with-silent-modifications' doesn't seem to have any effect here.)
The OP's recipe includes C-g, which could mean we lack an
unwind-protect somewhere, and the buffer stays modified due to changes
in faces.
The fact that changes in faces cause the buffer become eligible for
auto-saving is not a bug, IMO, it's a feature.
next prev parent reply other threads:[~2021-07-16 12:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-21 9:49 bug#11303: Whitespace mode causes auto-save to malfunction Kelly Dean
2012-06-02 21:22 ` Kelly Dean
2021-07-16 11:55 ` Lars Ingebrigtsen
2021-07-16 12:00 ` Eli Zaretskii [this message]
2021-07-16 12:06 ` Lars Ingebrigtsen
2022-05-07 10:07 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831r7y5uyv.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=11303@debbugs.gnu.org \
--cc=kellydeanch@yahoo.com \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).