From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#11303: Whitespace mode causes auto-save to malfunction Date: Fri, 16 Jul 2021 15:00:56 +0300 Message-ID: <831r7y5uyv.fsf@gnu.org> References: <1335001776.57750.YahooMailClassic@web121502.mail.ne1.yahoo.com> <87r1fya2wv.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37795"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 11303@debbugs.gnu.org, kellydeanch@yahoo.com To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 16 14:02:19 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m4MXr-0009dz-2z for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 16 Jul 2021 14:02:19 +0200 Original-Received: from localhost ([::1]:60726 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m4MXq-0007fO-20 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 16 Jul 2021 08:02:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40594) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m4MXa-0007aw-NQ for bug-gnu-emacs@gnu.org; Fri, 16 Jul 2021 08:02:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39137) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m4MXa-00070T-FP for bug-gnu-emacs@gnu.org; Fri, 16 Jul 2021 08:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m4MXa-0000lH-EM for bug-gnu-emacs@gnu.org; Fri, 16 Jul 2021 08:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Jul 2021 12:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11303 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 11303-submit@debbugs.gnu.org id=B11303.16264368862882 (code B ref 11303); Fri, 16 Jul 2021 12:02:02 +0000 Original-Received: (at 11303) by debbugs.gnu.org; 16 Jul 2021 12:01:26 +0000 Original-Received: from localhost ([127.0.0.1]:50683 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m4MWz-0000kQ-W4 for submit@debbugs.gnu.org; Fri, 16 Jul 2021 08:01:26 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:42622) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m4MWy-0000kC-7B for 11303@debbugs.gnu.org; Fri, 16 Jul 2021 08:01:24 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49710) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m4MWs-0006UK-QM; Fri, 16 Jul 2021 08:01:18 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4609 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m4MWl-00006T-Ol; Fri, 16 Jul 2021 08:01:18 -0400 In-Reply-To: <87r1fya2wv.fsf@gnus.org> (message from Lars Ingebrigtsen on Fri, 16 Jul 2021 13:55:44 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:210088 Archived-At: > From: Lars Ingebrigtsen > Date: Fri, 16 Jul 2021 13:55:44 +0200 > Cc: 11303@debbugs.gnu.org > > Kelly Dean writes: > > > Start Emacs with no options. > > Open a file, press space, wait for the timeout, press C-g, and wait > > for the timeout again. Notice that Emacs does write the auto-save file > > again, even though the buffer hasn't changed since the last > > auto-save. This is not the correct behavior. > > This problem is still present in Emacs 28. > > Poking around a bit at this, it seems that it's the call to > > (jit-lock-refontify (point-min) (point-max)) > > that makes `M-x do-auto-save' auto-save again (even if nothing has > changed except the text properties in the buffer). > > I.e., doing > > (put-text-property 1 3 'face 'bold) > > will make the buffer eligible for auto-saving again, even if putting > those text properties into the buffer doesn't switch from unmodified to > modified. > > That's pretty inconsistent behaviour, at least? I'm guessing this stems > from text properties upping the BUF_MODIFF, but not changing the buffer > modification status. > > Does this sound like the correct analysis? If so, what can we do about > it? (`with-silent-modifications' doesn't seem to have any effect here.) The OP's recipe includes C-g, which could mean we lack an unwind-protect somewhere, and the buffer stays modified due to changes in faces. The fact that changes in faces cause the buffer become eligible for auto-saving is not a bug, IMO, it's a feature.