From: Eli Zaretskii <eliz@gnu.org>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: p.stephani2@gmail.com, pogonyshev@gmail.com, 53071@debbugs.gnu.org
Subject: bug#53071: 28.0.90; Emacs 28 regression: incorrect code generation for complex pcase forms?
Date: Wed, 12 Jan 2022 21:33:38 +0200 [thread overview]
Message-ID: <831r1c6965.fsf@gnu.org> (raw)
In-Reply-To: <5CB5FFBD-7859-416B-9E66-21A7590DB35C@acm.org> (message from Mattias Engdegård on Wed, 12 Jan 2022 20:09:26 +0100)
> From: Mattias Engdegård <mattiase@acm.org>
> Date: Wed, 12 Jan 2022 20:09:26 +0100
> Cc: 53071@debbugs.gnu.org, Philipp <p.stephani2@gmail.com>,
> Paul Pogonyshev <pogonyshev@gmail.com>
>
> 12 jan. 2022 kl. 17.58 skrev Eli Zaretskii <eliz@gnu.org>:
>
> > So I'm about to revert this backport, but I'm prepared to hear
> > arguments why shouldn't I.
>
> I broke protocol by pushing it to the stable branch in this phase without permission. Sorry about that; the change has now been reverted. Will be more careful in the future.
>
> > From my POV, the regression is very minor, and it doesn't justify such
> > a non-trivial change in such a central place.
>
> I personally don't care much about it since I don't use Emacs 28 but would certainly not prefer at least two known, documented and harmful bugs reported by our users over some vague hypothetical conjectured problem that might arise.
>
> > If you think the
> > problem is serious, I'd rather revert the change we did which produced
> > the regression in the first place (assuming it's not too complicated).
>
> That would be inadvisable as it would introduce yet another bug, the fix of which was the immediate cause of the regression.
Fine by me, then let's leave emacs-28 at its present state.
Thanks.
next prev parent reply other threads:[~2022-01-12 19:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-07 9:36 bug#53071: 28.0.90; Emacs 28 regression: incorrect code generation for complex pcase forms? Philipp Stephani
2022-01-12 2:19 ` Philipp
2022-01-12 14:10 ` Michael Heerdegen
2022-01-12 15:35 ` Mattias Engdegård
2022-01-12 16:03 ` Mattias Engdegård
2022-01-12 16:58 ` Eli Zaretskii
2022-01-12 19:09 ` Mattias Engdegård
2022-01-12 19:33 ` Eli Zaretskii [this message]
2022-01-12 19:37 ` Philipp Stephani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831r1c6965.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=53071@debbugs.gnu.org \
--cc=mattiase@acm.org \
--cc=p.stephani2@gmail.com \
--cc=pogonyshev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).