From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#53071: 28.0.90; Emacs 28 regression: incorrect code generation for complex pcase forms? Date: Wed, 12 Jan 2022 21:33:38 +0200 Message-ID: <831r1c6965.fsf@gnu.org> References: <39D132B5-6B44-41F0-A618-6A68BFB5FEBF@gmail.com> <87mtk1niyj.fsf@web.de> <653D1A81-3A8F-4964-8A80-4C84F8C2A07A@acm.org> <83czkw6gca.fsf@gnu.org> <5CB5FFBD-7859-416B-9E66-21A7590DB35C@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8806"; mail-complaints-to="usenet@ciao.gmane.io" Cc: p.stephani2@gmail.com, pogonyshev@gmail.com, 53071@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 12 20:34:19 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n7jNz-00029s-9f for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 12 Jan 2022 20:34:19 +0100 Original-Received: from localhost ([::1]:36960 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n7jNx-0002Ep-P6 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 12 Jan 2022 14:34:17 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:59174) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7jNl-0002Ef-Ew for bug-gnu-emacs@gnu.org; Wed, 12 Jan 2022 14:34:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38039) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n7jNi-00039Z-6C for bug-gnu-emacs@gnu.org; Wed, 12 Jan 2022 14:34:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n7jNi-00048k-3S for bug-gnu-emacs@gnu.org; Wed, 12 Jan 2022 14:34:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Jan 2022 19:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53071 X-GNU-PR-Package: emacs Original-Received: via spool by 53071-submit@debbugs.gnu.org id=B53071.164201603115895 (code B ref 53071); Wed, 12 Jan 2022 19:34:02 +0000 Original-Received: (at 53071) by debbugs.gnu.org; 12 Jan 2022 19:33:51 +0000 Original-Received: from localhost ([127.0.0.1]:59175 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7jNX-00048I-Dy for submit@debbugs.gnu.org; Wed, 12 Jan 2022 14:33:51 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7jNV-000487-W3 for 53071@debbugs.gnu.org; Wed, 12 Jan 2022 14:33:50 -0500 Original-Received: from [2001:470:142:3::e] (port=55258 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7jNQ-00038M-Mm; Wed, 12 Jan 2022 14:33:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=tpdUoK2NyIKUJx1K5pWmrKCbQVpcCMmGmtad4RzVBzc=; b=i8OAOaQLQs8/5sK6I2Gz 2chIZemezypJGYV5CIDowRU4hoska/RCpXMb37h4VHbtU4qhHvWKodkvBvXkISNlica2thznJU/jM tM+eYVwdYIpXLuj0df/BmXH1Ih1K+ZArwCjcNJHWDVZQ67UL3xFJmneCcBLWVADLbcLKj9qK6D+8e 84E49EToZbqu8mqGv6DxInRev9HpkTX26edo5+eJJe1TZgEETast6ZCDrdclWJKuMfpDgERc58ke8 7vrZScFe2dfydWmdi0cjeiwEgJKjsBSQhji+SPbzY+q4aCCzk3b/CfGDPE4u3mVlPS+amnGv+a+Oc j+TMBzroB2gwRA==; Original-Received: from [87.69.77.57] (port=2783 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7jNQ-0004gQ-Ih; Wed, 12 Jan 2022 14:33:44 -0500 In-Reply-To: <5CB5FFBD-7859-416B-9E66-21A7590DB35C@acm.org> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Wed, 12 Jan 2022 20:09:26 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:224033 Archived-At: > From: Mattias Engdegård > Date: Wed, 12 Jan 2022 20:09:26 +0100 > Cc: 53071@debbugs.gnu.org, Philipp , > Paul Pogonyshev > > 12 jan. 2022 kl. 17.58 skrev Eli Zaretskii : > > > So I'm about to revert this backport, but I'm prepared to hear > > arguments why shouldn't I. > > I broke protocol by pushing it to the stable branch in this phase without permission. Sorry about that; the change has now been reverted. Will be more careful in the future. > > > From my POV, the regression is very minor, and it doesn't justify such > > a non-trivial change in such a central place. > > I personally don't care much about it since I don't use Emacs 28 but would certainly not prefer at least two known, documented and harmful bugs reported by our users over some vague hypothetical conjectured problem that might arise. > > > If you think the > > problem is serious, I'd rather revert the change we did which produced > > the regression in the first place (assuming it's not too complicated). > > That would be inadvisable as it would introduce yet another bug, the fix of which was the immediate cause of the regression. Fine by me, then let's leave emacs-28 at its present state. Thanks.