bug#64424: [PATCH] Include a help-echo for flymake's modeline counters

bug#64424: [PATCH] Include a help-echo for flymake's modeline counters

[sbaugh]

[-- Attachment #1: Type: text/plain, Size: 661 bytes --]

Tags: patch


This helps clarify what each of these numbers mean.  This is inspired
by compilation-mode-line-errors which does the same.

* lisp/progmodes/flymake.el (flymake--mode-line-counter): Add
help-echo to mode line properties.


In GNU Emacs 29.0.92 (build 2, x86_64-pc-linux-gnu, X toolkit, cairo
 version 1.16.0, Xaw3d scroll bars) of 2023-07-01 built on earth
Repository revision: b179926388ee76f7b3304535a7189f89bd7c7f8c
Repository branch: emacs-29
Windowing system distributor 'The X.Org Foundation', version 11.0.12014000
System Description: NixOS 22.11 (Raccoon)

Configured using:
 'configure --with-x-toolkit=lucid --with-tree-sitter CC=gcc'
 

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Include-a-help-echo-for-flymake-s-modeline-counters.patch --]
[-- Type: text/patch, Size: 1294 bytes --]

From aa577647a91c295fedcff4c1357ebb1f6c0d1384 Mon Sep 17 00:00:00 2001
From: Spencer Baugh <sbaugh@catern.com>
Date: Sun, 2 Jul 2023 12:11:09 -0400
Subject: [PATCH] Include a help-echo for flymake's modeline counters

This helps clarify what each of these numbers mean.  This is inspired
by compilation-mode-line-errors which does the same.

* lisp/progmodes/flymake.el (flymake--mode-line-counter): Add
help-echo to mode line properties.
---
 lisp/progmodes/flymake.el | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el
index 6f293acca5e..47dc32f9245 100644
--- a/lisp/progmodes/flymake.el
+++ b/lisp/progmodes/flymake.el
@@ -1473,6 +1473,12 @@ flymake--mode-line-counter
          ,(format "%d" count)
          face ,face
          mouse-face mode-line-highlight
+         help-echo ,(format "Number of %s; scroll mouse to view."
+                            (cond
+                             ((eq type :error) "errors")
+                             ((eq type :warning) "warnings")
+                             ((eq type :note) "notes")
+                             (t (format "%s diagnostics" type))))
          keymap
          ,(let ((map (make-sparse-keymap)))
             (define-key map (vector 'mode-line
-- 
2.40.1

bug#64424: [PATCH] Include a help-echo for flymake's modeline counters

[Eli Zaretskii]

> From: sbaugh@catern.com
> Date: Sun, 02 Jul 2023 16:12:06 +0000 (UTC)
> 
> This helps clarify what each of these numbers mean.  This is inspired
> by compilation-mode-line-errors which does the same.
> 
> * lisp/progmodes/flymake.el (flymake--mode-line-counter): Add
> help-echo to mode line properties.

Thanks.

João, is this safe for the release branch?

bug#64424: [PATCH] Include a help-echo for flymake's modeline counters

[João Távora]

[-- Attachment #1: Type: text/plain, Size: 605 bytes --]

On Sun, Jul 2, 2023, 18:08 Eli Zaretskii <eliz@gnu.org> wrote:

> > From: sbaugh@catern.com
> > Date: Sun, 02 Jul 2023 16:12:06 +0000 (UTC)
> >
> > This helps clarify what each of these numbers mean.  This is inspired
> > by compilation-mode-line-errors which does the same.
> >
> > * lisp/progmodes/flymake.el (flymake--mode-line-counter): Add
> > help-echo to mode line properties.
>
> Thanks.
>
> João, is this safe for the release branch?
>

I think so, yes. I'd like to give it a bit of testing with Eglot, which
uses its own types, but it does seem safe regardless.

João

>

[-- Attachment #2: Type: text/html, Size: 1198 bytes --]

bug#64424: [PATCH] Include a help-echo for flymake's modeline counters

[Eli Zaretskii]

> From: João Távora <joaotavora@gmail.com>
> Date: Sun, 2 Jul 2023 21:54:20 +0100
> Cc: sbaugh@catern.com, 64424@debbugs.gnu.org
> 
> On Sun, Jul 2, 2023, 18:08 Eli Zaretskii <eliz@gnu.org> wrote:
> 
>  > From: sbaugh@catern.com
>  > Date: Sun, 02 Jul 2023 16:12:06 +0000 (UTC)
>  > 
>  > This helps clarify what each of these numbers mean.  This is inspired
>  > by compilation-mode-line-errors which does the same.
>  > 
>  > * lisp/progmodes/flymake.el (flymake--mode-line-counter): Add
>  > help-echo to mode line properties.
> 
>  Thanks.
> 
>  João, is this safe for the release branch?
> 
> I think so, yes. I'd like to give it a bit of testing with Eglot, which uses its own types, but it does seem
> safe regardless.

Thanks, installed on the emacs-29 branch, and closing the bug.