bug#21417: Subject: 25.0.50; Paragraph movement in Eshell

bug#21417: Subject: 25.0.50; Paragraph movement in Eshell

[Simen Heggestøyl]

[-- Attachment #1: Type: text/plain, Size: 1101 bytes --]

Moving by paragraph in Eshell doesn't work when there's command output
containing newlines. Consider the following case:

~ $ foo
bar

baz
~ $

The user has entered the command "foo", which has put out
"bar\n\nbaz\n". Point is after the second "$".

Now the user hits `C-c C-p' which runs `eshell-previous-prompt', and
point ends up at the blank line between "bar" and "baz", instead of
going back to the previous prompt.

It seems that setting `paragraph-separate' to something else than the
default "[ \f]*$" solves the problem, though I'm uncertain what it
should be set to.

-- Simen


In GNU Emacs 25.0.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.16.6)
 of 2015-09-04
Repository revision: 09c15856a926eb80106a5c42571660601c2167d6
Windowing system distributor 'The X.Org Foundation', version 
11.0.11702000
System Description:	Debian GNU/Linux testing (stretch)

Configured features:
XPM JPEG TIFF GIF PNG SOUND DBUS GSETTINGS NOTIFY LIBXML2 FREETYPE XFT
ZLIB TOOLKIT_SCROLL_BARS GTK3 X11

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: EShell

[-- Attachment #2: Type: text/html, Size: 1599 bytes --]

bug#21417: Subject: 25.0.50; Paragraph movement in Eshell

[Stefan Kangas]

Simen Heggestøyl <simenheg@gmail.com> writes:

> Moving by paragraph in Eshell doesn't work when there's command output
> containing newlines. Consider the following case:
>
> ~ $ foo
> bar
>
> baz
> ~ $
>
> The user has entered the command "foo", which has put out
> "bar\n\nbaz\n". Point is after the second "$".
>
> Now the user hits `C-c C-p' which runs `eshell-previous-prompt', and
> point ends up at the blank line between "bar" and "baz", instead of
> going back to the previous prompt.
>
> It seems that setting `paragraph-separate' to something else than the
> default "[ ]*$" solves the problem, though I'm uncertain what it
> should be set to.

I'm unable to reproduce this on current master.  I tried:

0. emacs -Q
1. M-x eshell
2. emacs --help
3. C-c C-p

At the last command, point correctly moved to the previous prompt.

Can you reproduce this on Emacs 27 or 26?  If yes, could you please
provide more details on how to reproduce it?

Perhaps there is something in the output of the particular command you
used that confused Eshell?  That's just a wild guess, though.

Best regards,
Stefan Kangas

bug#21417: Subject: 25.0.50; Paragraph movement in Eshell

[simenheg]

Stefan Kangas <stefan@marxist.se> writes:

> I'm unable to reproduce this on current master.

Bisecting showed that it was fixed by Noam Postavsky in
7a0ca227af1081ca7ada2e82a87b1a575ef04759 in response to
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=27405. Nice.

I'm closing this. Thanks for checking up on it.

-- Simen