From: Glenn Morris <rgm@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: matthew@mattleach.net, 37564@debbugs.gnu.org,
Stefan Kangas <stefan@marxist.se>
Subject: bug#37564: [PATCH] don't export LINES and COLUMNS env vars in term to fix ncurses applications
Date: Mon, 20 Jan 2020 19:58:53 -0500 [thread overview]
Message-ID: <7nd0bd8w1e.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <83pnfevsbv.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 20 Jan 2020 21:30:28 +0200")
The report seems clear to me.
No other terminal emulator exports LINES and COLUMNS as environment variables.
Applications use ioctl to get the size.
-> Therefore setting LINES and COLUMNS is pointless.
If LINES/COLUMNS are set, they override ioctl.
You can't update the environment of an already running process.
Therefore the presence of LINES/COLUMNS in the initial environment
of a process spawned from Emacs means it will fail to react to resizing.
Therefore exporting LINES and COLUMNS is harmful.
(It's irrelevant if Emacs changes LINES and COLUMNS for new processes.)
So don't export LINES and COLUMNS.
I can't explain it any better.
next prev parent reply other threads:[~2020-01-21 0:58 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 19:59 bug#37564: [PATCH] don't export LINES and COLUMNS env vars in term to fix ncurses applications Matthew Leach
2019-10-01 6:01 ` Eli Zaretskii
2019-10-01 15:47 ` Matthew Leach
2019-10-01 16:07 ` Eli Zaretskii
2019-10-01 18:33 ` Matthew Leach
2019-10-01 18:58 ` Eli Zaretskii
2019-10-01 19:14 ` Eli Zaretskii
2019-10-01 19:24 ` Matthew Leach
2019-10-02 2:28 ` Eli Zaretskii
2019-10-03 17:51 ` Glenn Morris
2019-10-04 18:48 ` Matthew Leach
2020-01-20 19:10 ` Stefan Kangas
2020-01-20 19:30 ` Eli Zaretskii
2020-01-21 0:58 ` Glenn Morris [this message]
2020-01-21 17:11 ` Eli Zaretskii
2020-01-21 18:10 ` Matthew Leach
2020-01-22 3:38 ` Glenn Morris
2020-01-22 15:46 ` Eli Zaretskii
2020-06-04 16:01 ` Glenn Morris
2020-08-15 12:37 ` Lars Ingebrigtsen
2020-01-24 18:08 ` Stefan Kangas
2020-01-21 3:04 ` Stefan Kangas
2019-10-04 18:47 ` Matthew Leach
2019-10-07 4:11 ` Lars Ingebrigtsen
2019-10-07 9:16 ` Andreas Schwab
2019-10-08 16:38 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7nd0bd8w1e.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=37564@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=matthew@mattleach.net \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).