From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#37564: [PATCH] don't export LINES and COLUMNS env vars in term to fix ncurses applications Date: Mon, 20 Jan 2020 19:58:53 -0500 Message-ID: <7nd0bd8w1e.fsf@fencepost.gnu.org> References: <87y2y5lfnb.fsf@1e0.co.uk> <83eezxatsv.fsf@gnu.org> <87tv8slb6w.fsf@mattleach.net> <83a7aka1q5.fsf@gnu.org> <87sgocfh8c.fsf@mattleach.net> <83y2y48f8u.fsf@gnu.org> <87o8z0few1.fsf@mattleach.net> <83sgob98zk.fsf@gnu.org> <9ipnjdemzv.fsf@fencepost.gnu.org> <878sq0jqi6.fsf@mattleach.net> <87o8uyrlja.fsf@marxist.se> <83pnfevsbv.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="93046"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) Cc: matthew@mattleach.net, 37564@debbugs.gnu.org, Stefan Kangas To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 21 02:00:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ithtt-000O2L-JB for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 21 Jan 2020 02:00:13 +0100 Original-Received: from localhost ([::1]:46468 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ithts-00013R-L8 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Jan 2020 20:00:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41096) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ithtj-000133-GW for bug-gnu-emacs@gnu.org; Mon, 20 Jan 2020 20:00:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ithti-0003T0-Jl for bug-gnu-emacs@gnu.org; Mon, 20 Jan 2020 20:00:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40341) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ithti-0003S3-GK for bug-gnu-emacs@gnu.org; Mon, 20 Jan 2020 20:00:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ithti-0002ZQ-Dg for bug-gnu-emacs@gnu.org; Mon, 20 Jan 2020 20:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 21 Jan 2020 01:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37564 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37564-submit@debbugs.gnu.org id=B37564.15795683459790 (code B ref 37564); Tue, 21 Jan 2020 01:00:02 +0000 Original-Received: (at 37564) by debbugs.gnu.org; 21 Jan 2020 00:59:05 +0000 Original-Received: from localhost ([127.0.0.1]:46314 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ithsm-0002Xq-VD for submit@debbugs.gnu.org; Mon, 20 Jan 2020 19:59:05 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:60232) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ithsl-0002XF-Pb for 37564@debbugs.gnu.org; Mon, 20 Jan 2020 19:59:04 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:35658) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ithsg-00035C-8j; Mon, 20 Jan 2020 19:58:58 -0500 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1ithsc-0007ce-BW; Mon, 20 Jan 2020 19:58:54 -0500 X-Spook: CipherTAC-2000 Mexico Agriculture enemy of the state X-Ran: 'q~,.wQ`V#*`XGjw7K?:FhIGAKb04-qFm`g8u%O>3"=EM@:`lac,b|LFizAW?x+/QH0)S| X-Hue: brightred X-Attribution: GM In-Reply-To: <83pnfevsbv.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 20 Jan 2020 21:30:28 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:174974 Archived-At: The report seems clear to me. No other terminal emulator exports LINES and COLUMNS as environment variables. Applications use ioctl to get the size. -> Therefore setting LINES and COLUMNS is pointless. If LINES/COLUMNS are set, they override ioctl. You can't update the environment of an already running process. Therefore the presence of LINES/COLUMNS in the initial environment of a process spawned from Emacs means it will fail to react to resizing. Therefore exporting LINES and COLUMNS is harmful. (It's irrelevant if Emacs changes LINES and COLUMNS for new processes.) So don't export LINES and COLUMNS. I can't explain it any better.