unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Richard Hopkins <emacs@unbit.co.uk>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 58367@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#58367: `package-install-file' rejects some .tar files (tentative patch)
Date: Sat, 08 Oct 2022 14:55:35 +0100	[thread overview]
Message-ID: <7e77f24cf4fb9ea9b12c4bab2c11cbcd@unbit.co.uk> (raw)
In-Reply-To: <87pmf2saur.fsf@gnus.org>

I've found another difference regarding `package-install-file' and a
package with subdirectories that I can reproduce with the previously
attached files.  This is the difference between installing a directory
or installing a .tar file.  For example

M-: (package-install-file "ustar-withsub-0.1")
;; * installs but ignores subdirectory

M-: (package-install-file "ustar-withsub-0.1.tar")
;; * 28.2 - error
;; * with patch - installs and includes subdirectory

I believe sub directories should be allowed from this part of the docs
and the patch now allows for it as well as fixing the error.

     "...Files may also extract into subdirectories of the content
     directory. ..."
     
https://www.gnu.org/software/emacs/manual/html_node/elisp/Multi_002dfile-Packages.html

It would be to good to see if anyone can reproduce these as it looks
like more patches are needed to support sub directories?

1) for v7-withsub-0.1.tar so it looks at the top level for "-pkg.el"

2) include subdirectories when installing from a directory to match
functionality of installing from .tar.





  reply	other threads:[~2022-10-08 13:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-07 21:15 bug#58367: `package-install-file' rejects some .tar files (tentative patch) Richard Hopkins
2022-10-08 13:28 ` Lars Ingebrigtsen
2022-10-08 13:55   ` Richard Hopkins [this message]
2022-10-08 16:25 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-08 22:45   ` Richard Hopkins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7e77f24cf4fb9ea9b12c4bab2c11cbcd@unbit.co.uk \
    --to=emacs@unbit.co.uk \
    --cc=58367@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).