From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Richard Hopkins Newsgroups: gmane.emacs.bugs Subject: bug#58367: `package-install-file' rejects some .tar files (tentative patch) Date: Sat, 08 Oct 2022 14:55:35 +0100 Message-ID: <7e77f24cf4fb9ea9b12c4bab2c11cbcd@unbit.co.uk> References: <263dae3ce307236c2694a2bc0baa3f63@unbit.co.uk> <87pmf2saur.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3738"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Roundcube Webmail/1.5.2 Cc: 58367@debbugs.gnu.org, Stefan Monnier To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 08 15:56:11 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ohAJG-0000lc-ON for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 08 Oct 2022 15:56:10 +0200 Original-Received: from localhost ([::1]:35042 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ohAJF-0002dv-9T for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 08 Oct 2022 09:56:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56200) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohAJ8-0002dm-Ik for bug-gnu-emacs@gnu.org; Sat, 08 Oct 2022 09:56:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41769) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ohAJ8-0006AA-70 for bug-gnu-emacs@gnu.org; Sat, 08 Oct 2022 09:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ohAJ8-0005vp-1A for bug-gnu-emacs@gnu.org; Sat, 08 Oct 2022 09:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Richard Hopkins Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Oct 2022 13:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58367 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58367-submit@debbugs.gnu.org id=B58367.166523734322152 (code B ref 58367); Sat, 08 Oct 2022 13:56:01 +0000 Original-Received: (at 58367) by debbugs.gnu.org; 8 Oct 2022 13:55:43 +0000 Original-Received: from localhost ([127.0.0.1]:40189 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohAIp-0005kz-FM for submit@debbugs.gnu.org; Sat, 08 Oct 2022 09:55:43 -0400 Original-Received: from antelope.elm.relay.mailchannels.net ([23.83.212.4]:48942) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohAIm-0005hM-3d for 58367@debbugs.gnu.org; Sat, 08 Oct 2022 09:55:41 -0400 X-Sender-Id: 9wt3zsp42r|x-authuser|emacs@unbit.co.uk Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 4A32B9216BB; Sat, 8 Oct 2022 13:55:38 +0000 (UTC) Original-Received: from apollo.krystal.co.uk (unknown [127.0.0.6]) (Authenticated sender: 9wt3zsp42r) by relay.mailchannels.net (Postfix) with ESMTPA id 0B8479216E5; Sat, 8 Oct 2022 13:55:36 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1665237337; a=rsa-sha256; cv=none; b=cjTj9+zPB8/V0W5fq/aYIO3/RXu094Ww9d3Zy5/6zsgy6Kue+xlOhsULvGOJAR6flazllq o6HBouQU0N/1XmB5FjZyCCLTpC74rsedxqF88Pao3uiZDm4hPf172G2Gj0wy1ZaMMRTfQS MleTUWfz8u1ZdszVSnF+n99Sg5IdL/eCVyImJaTevcssBqeg0YD6OPTZX9/Hd+FRZUQ+b1 gmqCkw+uz5EqqFcsdfkoswhQD/jzuLUm2TEbBfo4szGvCaVIiao+p1qI6XC9hDE7dF6KOe NbL4SmQohOD3nXHMWZMFoPjtG+aVZZwtNPo7WQL/B+neWUtSUpsLgetepVmGGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1665237337; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dvK3Esxwobi8BM7AgXLkUkUwPvEHBn/tucMFwmG6CU0=; b=ikTiI1Ez8taU0fn4a9RTTMR3sTGanzMrpRRiXW+gBsflFlG/PMAxEywkB7FF52KzvrKUnq 2waP1Bg+EbqedXrIb2Trcgk49VAzKMiSRiXY/y1PXTOyLR/1vc3kicXHPT8yZj+yLXqJgw 1CLaitjEcDjZcuQIRXD12/GDij0QHldaXrF0NAcq3l/nu7EL9XcikftTM7c2Mui5afGWN4 QIrWTTewh3h1HMmQHpCwQcfJSQeBqoco/v+1Yls54WpoO8w1tsQ+S+bg4Qkl7P3dV/SsLn wkfdfXSyHVUTOt7Z409RReztyDiOZW7NpxbwuFDJykh3pLfzKoAUqRGnvaLzeQ== ARC-Authentication-Results: i=1; rspamd-7c485dd8cf-gdcxr; auth=pass smtp.auth=9wt3zsp42r smtp.mailfrom=emacs@unbit.co.uk X-Sender-Id: 9wt3zsp42r|x-authuser|emacs@unbit.co.uk X-MC-Relay: Neutral X-MailChannels-SenderId: 9wt3zsp42r|x-authuser|emacs@unbit.co.uk X-MailChannels-Auth-Id: 9wt3zsp42r X-Print-Celery: 0758db3d464c2a9d_1665237337852_513959468 X-MC-Loop-Signature: 1665237337852:3420567738 X-MC-Ingress-Time: 1665237337851 Original-Received: from apollo.krystal.co.uk (apollo.krystal.co.uk [77.72.0.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384) by 100.126.129.213 (trex/6.7.1); Sat, 08 Oct 2022 13:55:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=unbit.co.uk ; s=default; h=Content-Transfer-Encoding:Content-Type:Message-ID:References: In-Reply-To:Subject:Cc:To:From:Date:MIME-Version:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=dvK3Esxwobi8BM7AgXLkUkUwPvEHBn/tucMFwmG6CU0=; b=ZzXKBg96n4YV6dhueoZzNFXPpL FBCHtkz9mwdK382PJ4gBEAMlsULDXcAjeM56hbbdqBYrU/7vlT3tqQANE3u6+LPmYcL0KkZr2gW0w AeFhbUGqpKOuANs6HEuRNLoYn0dOTYd6jWJP+yYziQbrhet0TDwgvWIP6Ic4tAbd6zRbp2EIPsi53 64F9BS64f+uATw4QRCSWCIGgsvw/s1jyNrE6FIY2DJdWnYdrgypBQv2tfiwutM4Lio9hEhXGDgLdR IRhPz/r2+CgucRK+L09fJHXUY/KTICvKPLqDyxCCx9Z0ShkqXzYIY7eybB2SXAZodWwxy/IY/LDZU fnqTe5FQ==; Original-Received: from [::1] (port=39990 helo=apollo.krystal.co.uk) by apollo.krystal.co.uk with esmtpa (Exim 4.95) (envelope-from ) id 1ohAIj-00Ec32-IO; Sat, 08 Oct 2022 14:55:35 +0100 In-Reply-To: <87pmf2saur.fsf@gnus.org> X-Sender: emacs@unbit.co.uk X-AuthUser: emacs@unbit.co.uk X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:244913 Archived-At: I've found another difference regarding `package-install-file' and a package with subdirectories that I can reproduce with the previously attached files. This is the difference between installing a directory or installing a .tar file. For example M-: (package-install-file "ustar-withsub-0.1") ;; * installs but ignores subdirectory M-: (package-install-file "ustar-withsub-0.1.tar") ;; * 28.2 - error ;; * with patch - installs and includes subdirectory I believe sub directories should be allowed from this part of the docs and the patch now allows for it as well as fixing the error. "...Files may also extract into subdirectories of the content directory. ..." https://www.gnu.org/software/emacs/manual/html_node/elisp/Multi_002dfile-Packages.html It would be to good to see if anyone can reproduce these as it looks like more patches are needed to support sub directories? 1) for v7-withsub-0.1.tar so it looks at the top level for "-pkg.el" 2) include subdirectories when installing from a directory to match functionality of installing from .tar.