From: Jim Porter <jporterbugs@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>, Gabriel <gabriel376@hotmail.com>
Cc: 59491@debbugs.gnu.org
Subject: bug#59491: 29.0.50; [PATCH] Mode-line elements too wide in some VC buffers
Date: Wed, 23 Nov 2022 10:43:29 -0800 [thread overview]
Message-ID: <7e19c0e7-5b64-bf40-cb25-fb8e5e3cdb0a@gmail.com> (raw)
In-Reply-To: <83sfi9zx3y.fsf@gnu.org>
On 11/23/2022 4:14 AM, Eli Zaretskii wrote:
>> From: Gabriel <gabriel376@hotmail.com>
>> Date: Tue, 22 Nov 2022 17:58:25 -0300
>>
>> For Git, a better option would be to use a "short revision" (by default
>> the first 7 characters of the "long revision")
>
> AFAIR, just taking the first 7 characters is not safe; you need to ask Git.
> But maybe for this purpose taking 7 would be enough?
It'd be nice to pass this through `git rev-parse --short` or maybe even
`git describe --always --all`. vc-git.el could also use something like
this when it gets the ref for the modeline (see
'vc-git-mode-line-string' and 'vc-git--symbolic-ref').
In fact, maybe there should be a generic VC function for getting a
"friendly" string describing a commit. Then code could use that function
in some/most cases instead of showing the full commit ID.
prev parent reply other threads:[~2022-11-23 18:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 20:58 bug#59491: 29.0.50; [PATCH] Mode-line elements too wide in some VC buffers Gabriel
2022-11-23 12:14 ` Eli Zaretskii
2022-11-23 18:43 ` Jim Porter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e19c0e7-5b64-bf40-cb25-fb8e5e3cdb0a@gmail.com \
--to=jporterbugs@gmail.com \
--cc=59491@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=gabriel376@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).