From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#59491: 29.0.50; [PATCH] Mode-line elements too wide in some VC buffers Date: Wed, 23 Nov 2022 10:43:29 -0800 Message-ID: <7e19c0e7-5b64-bf40-cb25-fb8e5e3cdb0a@gmail.com> References: <83sfi9zx3y.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2039"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59491@debbugs.gnu.org To: Eli Zaretskii , Gabriel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 23 19:44:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oxujF-0000Mz-V3 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Nov 2022 19:44:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oxuj6-0000Ft-5C; Wed, 23 Nov 2022 13:44:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxuj4-0000Fj-7p for bug-gnu-emacs@gnu.org; Wed, 23 Nov 2022 13:44:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oxuj3-0003Wy-UX for bug-gnu-emacs@gnu.org; Wed, 23 Nov 2022 13:44:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oxuj3-00028N-Kg for bug-gnu-emacs@gnu.org; Wed, 23 Nov 2022 13:44:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Nov 2022 18:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59491 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59491-submit@debbugs.gnu.org id=B59491.16692290198167 (code B ref 59491); Wed, 23 Nov 2022 18:44:01 +0000 Original-Received: (at 59491) by debbugs.gnu.org; 23 Nov 2022 18:43:39 +0000 Original-Received: from localhost ([127.0.0.1]:56216 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxuih-00027f-Fx for submit@debbugs.gnu.org; Wed, 23 Nov 2022 13:43:39 -0500 Original-Received: from mail-pj1-f49.google.com ([209.85.216.49]:41645) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxuif-00027L-9B for 59491@debbugs.gnu.org; Wed, 23 Nov 2022 13:43:37 -0500 Original-Received: by mail-pj1-f49.google.com with SMTP id w15-20020a17090a380f00b0021873113cb4so2646506pjb.0 for <59491@debbugs.gnu.org>; Wed, 23 Nov 2022 10:43:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=CTcXZbsZ+ZuSS5ouutrpBFj5RC0uVvXwobHNIzKcGKM=; b=UEitVItsXFo1aTGEkqfD0GkRZ1UgqNh3unXa1nRdICeaLls3joL3xtYtFcCatxZMQr LzODrxITVlmjleeIMVatO7bf9DltoEZy+ZNgAk2FZUlOBttK3dGzUDroJtQoOCkvVt0x coyHIkygTF7uEeYzIx5MA/9UGDppNNSJqBvlPk4qKvNlsh6dJM8i47b4q2tSViigklLq JyO3OO4O2LtAY7fhDolU/Su9p80v4uOUcfPpppispBDQDjV5dD0M/28Z5UN8pBwlEVuc fQzxjTzJvIFCWyH3fmDQNoUNnJ7+mtcIzy8LXFcNow76D1oiWr1hihTwUkAFOsPr8RdB MNSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CTcXZbsZ+ZuSS5ouutrpBFj5RC0uVvXwobHNIzKcGKM=; b=LNHWsQCf2VLpNn5Udne2Iwk+u5red9j7X8vfrTwQYu64mwyrBc1Xj+eHCCSG38yKEX w7b7QL3BdA3q2sHhXargbfSoaoJ1/U/O08T/2G/DeXhjJWOs8vcJ/76fg4Am92h0FFEM niJXLINxH+Rhf6QQJKlrd278KBtluzq2pT5aBgA9d7tI0FpahoblLIRkDkYj4bv27L40 ZpYDRP459+EA9tgT5eYQQAS/HUTeeLfVP2eXrirt5I1IVqiSbgqes40wndEnUW/E62qB SVmDejeWjyWNTbD+faWE50ACVlD5v0uYYfIYPPuVu+6IFeFod2FHJ7o0me51UpYQwaFl tMxQ== X-Gm-Message-State: ANoB5pmV+zNbslEp0NUzHnfX5ZQKOfGlMF+Lj+KHnlQRTI5nTxqjLamb 6DKZQoMXTutO3xIOp1dGaHs= X-Google-Smtp-Source: AA0mqf5I9Eo+jJMQs1jSozYGuZiIz4mg0RZNSewthZZeKRzGuJLftexkXHa2RRcc+1j/aXM9FI/z+g== X-Received: by 2002:a17:903:2443:b0:181:6c64:6dd3 with SMTP id l3-20020a170903244300b001816c646dd3mr10744140pls.123.1669229011186; Wed, 23 Nov 2022 10:43:31 -0800 (PST) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id r17-20020aa79631000000b0057452fc8935sm1969108pfg.162.2022.11.23.10.43.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Nov 2022 10:43:30 -0800 (PST) Content-Language: en-US In-Reply-To: <83sfi9zx3y.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248770 Archived-At: On 11/23/2022 4:14 AM, Eli Zaretskii wrote: >> From: Gabriel >> Date: Tue, 22 Nov 2022 17:58:25 -0300 >> >> For Git, a better option would be to use a "short revision" (by default >> the first 7 characters of the "long revision") > > AFAIR, just taking the first 7 characters is not safe; you need to ask Git. > But maybe for this purpose taking 7 would be enough? It'd be nice to pass this through `git rev-parse --short` or maybe even `git describe --always --all`. vc-git.el could also use something like this when it gets the ref for the modeline (see 'vc-git-mode-line-string' and 'vc-git--symbolic-ref'). In fact, maybe there should be a generic VC function for getting a "friendly" string describing a commit. Then code could use that function in some/most cases instead of showing the full commit ID.