* bug#60415: Emacs master doesn't build if !HAVE_TREE_SITTER
@ 2022-12-30 4:46 Paul Eggert
2023-01-01 1:09 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 1 reply; 4+ messages in thread
From: Paul Eggert @ 2022-12-30 4:46 UTC (permalink / raw)
To: 60415
[-- Attachment #1: Type: text/plain, Size: 797 bytes --]
On my platform the current Emacs master (commit
91ae9f3d12885373d38c3e8d693f7dc210f9d471) won't build, failing with:
ELC progmodes/typescript-ts-mode.elc
In toplevel form:
progmodes/typescript-ts-mode.el:31:2: Error: Symbol’s function
definition is vo\
id: treesit-query-compile
Full log (compressed) attached, built from Git on Fedora 37 x86-64. The
best fix isn't immediately obvious to me; adding a declare-function
doesn't work.
This platform doesn't have the tree-sitter library, so HAVE_TREE_SITTER
is not defined which means C doesn't define treesit-query-compile.
I will probably just install the tree-sitter library to work around the
bug, but thought I'd document it. Presumably you can simulate it by
configuring --without-tree-sitter.
[-- Attachment #2: log.txt.gz --]
[-- Type: application/gzip, Size: 20469 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#60415: Emacs master doesn't build if !HAVE_TREE_SITTER
2022-12-30 4:46 bug#60415: Emacs master doesn't build if !HAVE_TREE_SITTER Paul Eggert
@ 2023-01-01 1:09 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-01 2:18 ` Yuan Fu
0 siblings, 1 reply; 4+ messages in thread
From: Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-01-01 1:09 UTC (permalink / raw)
To: Paul Eggert; +Cc: Yuan Fu, 60415
Paul Eggert <eggert@cs.ucla.edu> writes:
> On my platform the current Emacs master (commit
> 91ae9f3d12885373d38c3e8d693f7dc210f9d471) won't build, failing with:
>
> ELC progmodes/typescript-ts-mode.elc
>
> In toplevel form:
> progmodes/typescript-ts-mode.el:31:2: Error: Symbol’s function
> definition is vo\
> id: treesit-query-compile
>
>
> Full log (compressed) attached, built from Git on Fedora 37
> x86-64. The best fix isn't immediately obvious to me; adding a
> declare-function doesn't work.
>
> This platform doesn't have the tree-sitter library, so
> HAVE_TREE_SITTER is not defined which means C doesn't define
> treesit-query-compile.
>
> I will probably just install the tree-sitter library to work around
> the bug, but thought I'd document it. Presumably you can simulate it
> by configuring --without-tree-sitter.
Copying in Yuan Fu.
Would people please test their changes on an Emacs *WITHOUT* tree-sitter
before installing them in the future?
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#60415: Emacs master doesn't build if !HAVE_TREE_SITTER
2023-01-01 1:09 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-01-01 2:18 ` Yuan Fu
2023-09-06 7:02 ` Stefan Kangas
0 siblings, 1 reply; 4+ messages in thread
From: Yuan Fu @ 2023-01-01 2:18 UTC (permalink / raw)
To: Po Lu; +Cc: Paul Eggert, 60415
> On Dec 31, 2022, at 5:09 PM, Po Lu <luangruo@yahoo.com> wrote:
>
> Paul Eggert <eggert@cs.ucla.edu> writes:
>
>> On my platform the current Emacs master (commit
>> 91ae9f3d12885373d38c3e8d693f7dc210f9d471) won't build, failing with:
>>
>> ELC progmodes/typescript-ts-mode.elc
>>
>> In toplevel form:
>> progmodes/typescript-ts-mode.el:31:2: Error: Symbol’s function
>> definition is vo\
>> id: treesit-query-compile
>>
>>
>> Full log (compressed) attached, built from Git on Fedora 37
>> x86-64. The best fix isn't immediately obvious to me; adding a
>> declare-function doesn't work.
>>
>> This platform doesn't have the tree-sitter library, so
>> HAVE_TREE_SITTER is not defined which means C doesn't define
>> treesit-query-compile.
>>
>> I will probably just install the tree-sitter library to work around
>> the bug, but thought I'd document it. Presumably you can simulate it
>> by configuring --without-tree-sitter.
>
> Copying in Yuan Fu.
>
> Would people please test their changes on an Emacs *WITHOUT* tree-sitter
> before installing them in the future?
Yeah I’ve setup a no-tree-sitter build so I could catch these in the future. Sorry for the inconvenience.
Yuan
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#60415: Emacs master doesn't build if !HAVE_TREE_SITTER
2023-01-01 2:18 ` Yuan Fu
@ 2023-09-06 7:02 ` Stefan Kangas
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Kangas @ 2023-09-06 7:02 UTC (permalink / raw)
To: Yuan Fu; +Cc: Po Lu, 60415-done, Paul Eggert
Yuan Fu <casouri@gmail.com> writes:
>> On Dec 31, 2022, at 5:09 PM, Po Lu <luangruo@yahoo.com> wrote:
>>
>> Paul Eggert <eggert@cs.ucla.edu> writes:
>>
>>> On my platform the current Emacs master (commit
>>> 91ae9f3d12885373d38c3e8d693f7dc210f9d471) won't build, failing with:
>>>
>>> ELC progmodes/typescript-ts-mode.elc
>>>
>>> In toplevel form:
>>> progmodes/typescript-ts-mode.el:31:2: Error: Symbol’s function
>>> definition is vo\
>>> id: treesit-query-compile
>>>
>>>
>>> Full log (compressed) attached, built from Git on Fedora 37
>>> x86-64. The best fix isn't immediately obvious to me; adding a
>>> declare-function doesn't work.
>>>
>>> This platform doesn't have the tree-sitter library, so
>>> HAVE_TREE_SITTER is not defined which means C doesn't define
>>> treesit-query-compile.
>>>
>>> I will probably just install the tree-sitter library to work around
>>> the bug, but thought I'd document it. Presumably you can simulate it
>>> by configuring --without-tree-sitter.
>>
>> Copying in Yuan Fu.
>>
>> Would people please test their changes on an Emacs *WITHOUT* tree-sitter
>> before installing them in the future?
>
> Yeah I’ve setup a no-tree-sitter build so I could catch these in the future. Sorry for the inconvenience.
That was 9 months ago.
I'm assuming this has been fixed by now, and that the bug was left open
by accident. Therefore, I'm closing this bug report.
If anyone is still seeing this, please report back and we can
investigate.
Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-09-06 7:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-30 4:46 bug#60415: Emacs master doesn't build if !HAVE_TREE_SITTER Paul Eggert
2023-01-01 1:09 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-01 2:18 ` Yuan Fu
2023-09-06 7:02 ` Stefan Kangas
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).