bug#61320: 28.2; `vc-cvs-parse-root' returns wrong results

bug#61320: 28.2; `vc-cvs-parse-root' returns wrong results

[Farblos via Bug reports for GNU Emacs, the Swiss army knife of text editors]

This reproduces also in master.

Not sure why nobody has reported this.  Most likely because the current
callers of `vc-cvs-parse-root' care only about some aspects of the
actual result of `vc-cvs-parse-root'.

$ emacs -Q

In scratch buffer evaluate the following (specification of Ctrl-J
omitted for clarity):

(load-library "vc-cvs")
t

;; this one is correct in the sense that 3rd element of the list is nil
;; (making it a local root for `vc-cvs-repository-hostname'), but
;; probably is not what the author has intended:
(vc-cvs-parse-root ":local:/var/lib/cvs")
("local" nil nil "var:/lib/cvs")

;; but this one is completely broken:
(vc-cvs-parse-root "/var/lib/cvs")
("ext" nil "var" "/lib/cvs")

There might be different fixes, but IMHO the regexp used in function
`vc-cvs-parse-uhp' should be anchored to beginning of line or string:

  "\\`\\([^/]+\\)\\(/.*\\)"

bug#61320: `vc-cvs-parse-root' returns wrong results

[Farblos via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Fixed in master:

M-x emacs-version RET

GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.24, 
cairo version 1.16.0) of 2023-05-12

(vc-cvs-parse-root ":local:/var/lib/cvs")
("local" nil nil "/var/lib/cvs")

(vc-cvs-parse-root "/var/lib/cvs")
("local" nil nil "/var/lib/cvs")

Feel free to close this issue.

bug#61320: `vc-cvs-parse-root' returns wrong results

[Eli Zaretskii]

> Date: Fri, 12 May 2023 22:48:46 +0200
> From:  Farblos via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> 
> Fixed in master:
> 
> M-x emacs-version RET
> 
> GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.24, 
> cairo version 1.16.0) of 2023-05-12
> 
> (vc-cvs-parse-root ":local:/var/lib/cvs")
> ("local" nil nil "/var/lib/cvs")
> 
> (vc-cvs-parse-root "/var/lib/cvs")
> ("local" nil nil "/var/lib/cvs")
> 
> Feel free to close this issue.

Thanks, done.