bug#14377: 24.3.50; patch: run a hook after `bookmark-write'

bug#14377: 24.3.50; patch: run a hook after `bookmark-write'

[Eduard Wiebe]

[-- Attachment #1: Type: text/plain, Size: 107 bytes --]

 
   Hello,

i want always to export my bookmarks when bookmark file is saved.
Consider this simple patch.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: bookmark.after.save.hook.patch --]
[-- Type: text/x-diff, Size: 786 bytes --]

diff --git a/lisp/bookmark.el b/lisp/bookmark.el
index 482cdf9..ee561db 100644
--- a/lisp/bookmark.el
+++ b/lisp/bookmark.el
@@ -1311,6 +1311,9 @@ Don't use this in Lisp programs; use `bookmark-save' instead."
   (bookmark-save t))


+(defvar bookmark-after-save-hook nil
+  "Hook run after bookmark file was saved.")
+
 ;;;###autoload
 (defun bookmark-save (&optional parg file)
   "Save currently defined bookmarks.
@@ -1380,5 +1383,6 @@ for a file, defaulting to the file defined by variable
             (write-region (point-min) (point-max) file)
           (file-error (message "Can't write %s" file)))
         (kill-buffer (current-buffer))
+        (run-hooks 'bookmark-after-save-hook)
         (bookmark-maybe-message
          "Saving bookmarks to file %s...done" file)))))

bug#14377: 24.3.50; patch: run a hook after `bookmark-write'

[Stefan Monnier]

> I want always to export my bookmarks when bookmark file is saved.
> Consider this simple patch.

You could use

  (defadvice bookmark-write-file (after export activate)
    (do what I want))

Of course, we could also install something like your patch, but the hook
functions will probably need access to the file name (which might turn into
a lexically scoped var any time).


        Stefan

bug#14377: 24.3.50; patch: run a hook after `bookmark-write'

[Eduard Wiebe]

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

>> I want always to export my bookmarks when bookmark file is saved.
>> Consider this simple patch.
>
> You could use
>
>   (defadvice bookmark-write-file (after export activate)
>     (do what I want))

Sure.

> Of course, we could also install something like your patch, but the hook
> functions will probably need access to the file name (which might turn into
> a lexically scoped var any time).

Ahh.., that was not clear to me. Thanks for the hint.
Please close this report.

--
Eduard Wiebe

bug#14377: 24.3.50; patch: run a hook after `bookmark-write'

[Glenn Morris]

>> Of course, we could also install something like your patch, but the hook
>> functions will probably need access to the file name (which might turn into
>> a lexically scoped var any time).

Aren't matters of extensibility like this one reason why

http://www.gnu.org/software/emacs/emacs-paper.html#SEC15

favours dynamic binding?

bug#14377: 24.3.50; patch: run a hook after `bookmark-write'

[Drew Adams]

> >> Of course, we could also install something like your 
> >> patch, but the hook functions will probably need access
> >> to the file name (which might turn into a lexically
> >> scoped var any time).
> 
> Aren't matters of extensibility like this one reason why
> http://www.gnu.org/software/emacs/emacs-paper.html#SEC15
> favours dynamic binding?

;-)

FWIW, Bookmark+ has such a hook: `bmkp-write-bookmark-file-hook'.  (And it
passes the file name to the hook functions.)