bug#54628: 29.0.50; C-h f incorrectly replaces `function' arguments with #' for generic functions

bug#54628: 29.0.50; C-h f incorrectly replaces `function' arguments with #' for generic functions

[Philipp]

C-h f seq-do RET

The resulting help screen contains:

*****
Implementations:

#'sequence in ‘seq.el’.

Undocumented
*****

Here, the help screen has incorrect translated the argument list
(function sequence) into #'sequence.


In GNU Emacs 29.0.50 (build 47, aarch64-apple-darwin21.4.0, NS appkit-2113.40 Version 12.3 (Build 21E230))
 of 2022-03-29
Repository revision: 973608e35895a8f89a3abcac43dfaf89598b0c82
Repository branch: master
Windowing system distributor 'Apple', version 10.3.2113
System Description:  macOS 12.3

Configured using:
 'configure --with-modules --without-xml2 --without-pop --with-mailutils
 --enable-gcc-warnings=warn-only --enable-checking=all
 --enable-check-lisp-object-type '--prefix=/tmp/\7''

Configured features:
ACL GNUTLS JSON LCMS2 MODULES NOTIFY KQUEUE NS PDUMPER PNG SQLITE3
THREADS TOOLKIT_SCROLL_BARS ZLIB

Important settings:
  value of $LANG: de_DE.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug phst skeleton pcase ffap thingatpt url
url-proxy url-privacy url-expand url-methods url-history url-cookie
url-domsuf url-util url-parse auth-source cl-seq eieio eieio-core
cl-macs eieio-loaddefs json map url-vars rx message sendmail mailcap
yank-media rmc dired dired-loaddefs rfc822 mml mml-sec password-cache
epa derived epg rfc6068 epg-config gnus-util time-date mm-decode
mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util
ietf-drums mail-prsvr mailabbrev mail-utils gmm-utils mailheader gnutls
puny elp dbus xml seq gv subr-x byte-opt bytecomp byte-compile cconv
compile text-property-search comint ansi-color ring cl-loaddefs cl-lib
iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks
lisp-float-type elisp-mode mwheel term/ns-win ns-win ucs-normalize
mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode lisp-mode prog-mode register
page tab-bar menu-bar rfn-eshadow isearch easymenu timer select
scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors
frame minibuffer nadvice simple cl-generic cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese composite emoji-zwj charscript charprop case-table
epa-hook jka-cmpr-hook help abbrev obarray cl-preloaded button loaddefs
faces cus-face macroexp files window text-properties overlay sha1 md5
base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads kqueue cocoa ns lcms2
multi-tty make-network-process emacs)

Memory information:
((conses 16 68547 8868)
 (symbols 48 8132 1)
 (strings 32 23601 1819)
 (string-bytes 1 766139)
 (vectors 16 16627)
 (vector-slots 8 221372 15184)
 (floats 8 29 28)
 (intervals 56 225 0)
 (buffers 992 10))

bug#54628: 29.0.50; C-h f incorrectly replaces `function' arguments with #' for generic functions

[Lars Ingebrigtsen]

Philipp <p.stephani2@gmail.com> writes:

> C-h f seq-do RET
>
> The resulting help screen contains:
>
> *****
> Implementations:
>
> #'sequence in ‘seq.el’.
>
> Undocumented
> *****
>
> Here, the help screen has incorrect translated the argument list
> (function sequence) into #'sequence.

Yup.  I've also previously found that section in the *Help* buffer to be
somewhat obscure, so I've made it include the function name, which
should help clarify things slightly (and fixes the problem here as a
side effect, although I guess we could also just bind print-quoted to
nil).

------

Implementations:

(seq-do function sequence) in ‘seq.el’.


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#54628: 29.0.50; C-h f incorrectly replaces `function' arguments with #' for generic functions

[Philipp Stephani]

> Am 31.03.2022 um 13:38 schrieb Lars Ingebrigtsen <larsi@gnus.org>:
> 
> Philipp <p.stephani2@gmail.com> writes:
> 
>> C-h f seq-do RET
>> 
>> The resulting help screen contains:
>> 
>> *****
>> Implementations:
>> 
>> #'sequence in ‘seq.el’.
>> 
>> Undocumented
>> *****
>> 
>> Here, the help screen has incorrect translated the argument list
>> (function sequence) into #'sequence.
> 
> Yup. I've also previously found that section in the *Help* buffer to be
> somewhat obscure, so I've made it include the function name, which
> should help clarify things slightly (and fixes the problem here as a
> side effect,

Thanks.

> although I guess we could also just bind print-quoted to
> nil).
> 

Does the fix still work if a FUNCTION argument is specialized?

(cl-defmethod foobar ((function my-function-type)))

bug#54628: 29.0.50; C-h f incorrectly replaces `function' arguments with #' for generic functions

[Lars Ingebrigtsen]

Philipp Stephani <p.stephani2@gmail.com> writes:

> Does the fix still work if a FUNCTION argument is specialized?
>
> (cl-defmethod foobar ((function my-function-type)))

Nope.  Fixed now.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#54628: 29.0.50; C-h f incorrectly replaces `function' arguments with #' for generic functions

[Philipp Stephani]

> Am 04.04.2022 um 12:49 schrieb Lars Ingebrigtsen <larsi@gnus.org>:
> 
> Philipp Stephani <p.stephani2@gmail.com> writes:
> 
>> Does the fix still work if a FUNCTION argument is specialized?
>> 
>> (cl-defmethod foobar ((function my-function-type)))
> 
> Nope.  Fixed now.

Thanks.