From: Jim Porter <jporterbugs@gmail.com>
To: Stefan Kangas <stefankangas@gmail.com>,
65590@debbugs.gnu.org, michael.albinus@gmx.de
Subject: bug#65590: 29.0.50; esh-var-test/interp-concat-cmd fails on macOS
Date: Tue, 29 Aug 2023 10:10:12 -0700 [thread overview]
Message-ID: <7422c797-ff06-b05b-81e9-21b349be30ef@gmail.com> (raw)
In-Reply-To: <CADwFkmn+0bBr2N+bfvJjpkbXBn1pRCFx61fWC56AyDtz0vkYHg@mail.gmail.com>
On 8/28/2023 11:44 PM, Stefan Kangas wrote:
> X-Debbugs-CC: jporterbugs@gmail.com
>
> I see the below test failure on macOS:
>
> Test esh-var-test/interp-concat-cmd backtrace:
> signal(error ("echo: unrecognized option -b"))
> error("%s: unrecognized option -%c" "echo" 98)
> eshell--process-option("echo" "baz" 0 0 ((110 nil (nil) output-newli
> eshell--process-args("echo" ("-baz") ((110 nil (nil) output-newline
> eshell--do-opts("echo" ((110 nil (nil) output-newline "do not output
> eshell/echo("-baz")
> apply(eshell/echo "-baz")
[snip]
> eshell-command-result("echo ${*echo \"foo\nbar\"}-baz")
> eshell-test-command-result("echo ${*echo \"foo\nbar\"}-baz")
> eshell-command-result-equal("echo ${*echo \"foo\nbar\"}-baz" ("foo"
> #f(compiled-function () #<bytecode -0x1e41ac0e460bffe0>)()
> ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
> ert-run-test(#s(ert-test :name esh-var-test/interp-concat-cmd :docum
> ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
> ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n
> ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) (
> ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
> eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
> command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/eshell/esh-var-tests
> command-line()
> normal-top-level()
> Test esh-var-test/interp-concat-cmd condition:
> (error "echo: unrecognized option -b")
> FAILED 20/110 esh-var-test/interp-concat-cmd (0.616546 sec) at
> lisp/eshell/esh-var-tests.el:275
This looks like a race condition when executing this command:
echo ${*echo "foo\nbar"}-baz
That *should* print "foo\nbar-baz", but it tries to print "-baz" (and
fails). That appears to be because the subcommand (*echo "foo\nbar")
produces no output.
I'll inspect the code here more to see if there are any obvious places
that we're not waiting long enough for the output. However, I've never
been able to reproduce this locally, so it might be time to add more
debug instrumentation to Eshell...
(Michael Albinus - CCed - has also seen similar sorts of issues on EMBA.
They're usually different tests that fail, but they all look like
similar issues where we get no output from a subcommand.)
next prev parent reply other threads:[~2023-08-29 17:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-29 6:44 bug#65590: 29.0.50; esh-var-test/interp-concat-cmd fails on macOS Stefan Kangas
2023-08-29 17:10 ` Jim Porter [this message]
2023-08-29 18:59 ` Stefan Kangas
2023-08-29 19:15 ` Stefan Kangas
2023-08-30 0:44 ` Jim Porter
2023-09-01 1:54 ` Jim Porter
2023-09-01 16:03 ` Stefan Kangas
2023-09-01 16:30 ` Jim Porter
2023-09-01 17:00 ` Jim Porter
2023-09-12 18:53 ` Jim Porter
2023-09-13 16:10 ` Stefan Kangas
2023-09-13 18:54 ` Jim Porter
2023-09-13 20:34 ` Stefan Kangas
2023-09-13 20:41 ` Jim Porter
2023-09-13 20:48 ` Stefan Kangas
2023-09-13 21:10 ` bug#65590: bug#65602: 30.0.50; eshell-test/{elisp,subcommand}-reset-in-pipeline fails intermittently " Stefan Kangas
2023-09-13 21:33 ` Stefan Kangas
2023-09-14 1:24 ` Jim Porter
2023-09-14 19:14 ` Stefan Kangas
2023-09-14 19:33 ` Jim Porter
2023-09-15 0:59 ` Jim Porter
2023-09-15 12:14 ` Stefan Kangas
2023-09-18 17:30 ` Jim Porter
2023-09-13 21:13 ` bug#65590: " Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7422c797-ff06-b05b-81e9-21b349be30ef@gmail.com \
--to=jporterbugs@gmail.com \
--cc=65590@debbugs.gnu.org \
--cc=michael.albinus@gmx.de \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).