From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#65590: 29.0.50; esh-var-test/interp-concat-cmd fails on macOS Date: Tue, 29 Aug 2023 10:10:12 -0700 Message-ID: <7422c797-ff06-b05b-81e9-21b349be30ef@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35172"; mail-complaints-to="usenet@ciao.gmane.io" To: Stefan Kangas , 65590@debbugs.gnu.org, michael.albinus@gmx.de Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 29 19:11:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qb2FK-00090y-O3 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 29 Aug 2023 19:11:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qb2F1-0007na-O7; Tue, 29 Aug 2023 13:11:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qb2Ez-0007mx-Cd for bug-gnu-emacs@gnu.org; Tue, 29 Aug 2023 13:10:57 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qb2Ex-0007Ab-Lm for bug-gnu-emacs@gnu.org; Tue, 29 Aug 2023 13:10:55 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qb2F4-0007pk-0T for bug-gnu-emacs@gnu.org; Tue, 29 Aug 2023 13:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 29 Aug 2023 17:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65590 X-GNU-PR-Package: emacs Original-Received: via spool by 65590-submit@debbugs.gnu.org id=B65590.169332903430079 (code B ref 65590); Tue, 29 Aug 2023 17:11:01 +0000 Original-Received: (at 65590) by debbugs.gnu.org; 29 Aug 2023 17:10:34 +0000 Original-Received: from localhost ([127.0.0.1]:51463 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qb2Ea-0007p2-7u for submit@debbugs.gnu.org; Tue, 29 Aug 2023 13:10:34 -0400 Original-Received: from mail-pf1-x433.google.com ([2607:f8b0:4864:20::433]:53696) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qb2ET-0007oi-9Z for 65590@debbugs.gnu.org; Tue, 29 Aug 2023 13:10:30 -0400 Original-Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-68bed8de5b9so3201815b3a.3 for <65590@debbugs.gnu.org>; Tue, 29 Aug 2023 10:10:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693329012; x=1693933812; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=ekgCESDg/gjKX7qVRwwv0t3DxOwSs/FRxIyNBzJLcUQ=; b=XKA5ReL2ODZpnGspnY9+idTvcIGt3qKwpJZIFq8o/OLr/lVyzIQHx3Fl8uT93zs7Dl O3uXsFqog/r7gT27U5zhbGoPdf4OAiTrxUt0zTN3H4bF9MjjC1DbRJ3h770HDea7ICjv ajrno8arH43OINp9QfyCdOrMw4lMm3fNnkvs6I34zaxc848vZ7u4n2YaNIaXuQppa2pU El4Nb4BrM6EfZQZ5eZ+fNyjuN+fxFc4uDMter1L8vtsK5ujB6kOjIRWDlI0nyLeKQqr/ T+Lu/DyLpof1f18p5dqkb5VbY//AHQdhHCGgUFR/UE6zN7o+hQrJAtU+nA82Gbym6IZw ceaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693329012; x=1693933812; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ekgCESDg/gjKX7qVRwwv0t3DxOwSs/FRxIyNBzJLcUQ=; b=ly3Zpf0ZY/frNQoQ59WKqWaxnrK7kZ7vJDkJkce+yexgXyIx7+Q3xcPuUmXRG+k2W1 kGyv2he0NZ/GjZjJungbqbuo9KJ4eTY2i43ZGTtjsyDjSfY+XNSVm1Hc9p0KWuILNH/s Y/Pl/s3k6fF/9QI9eHLC2BNg20SbhaGsxRTKKg8HKXSQNVAwhp6KnvFau68WJ1YGcPTV p3VcDtCiBKu40hgZRnyky2UIPbf0wUwFo54H4xCtB9cpB0XnYidK/LovrWMAnTIDN5mx 3Fj6iM/2aZZi7DEtGDlqOcC81US77DI3bIcqllZNrgxjqtK/YzkgkPh2PEgi+3aS/2FH EiQw== X-Gm-Message-State: AOJu0YwJaU46cvkSVHc9QJZINrBuqN5ppydHSz6Iq2BwbHCstDbR9lev vWl0RHJuByE05WlS8xkyEpNiXokykHg= X-Google-Smtp-Source: AGHT+IE+i9PEwla84doIEdYTLBVEdwuMBJeubP4xVmHnZTNVSvRozp3VQa+MMfC7hzONaZ86VfHKRw== X-Received: by 2002:a05:6a20:f385:b0:14d:2b8d:d631 with SMTP id qr5-20020a056a20f38500b0014d2b8dd631mr6007568pzb.20.1693329012251; Tue, 29 Aug 2023 10:10:12 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id k8-20020aa792c8000000b006871fdde2c7sm8627254pfa.110.2023.08.29.10.10.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Aug 2023 10:10:11 -0700 (PDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268667 Archived-At: On 8/28/2023 11:44 PM, Stefan Kangas wrote: > X-Debbugs-CC: jporterbugs@gmail.com > > I see the below test failure on macOS: > > Test esh-var-test/interp-concat-cmd backtrace: > signal(error ("echo: unrecognized option -b")) > error("%s: unrecognized option -%c" "echo" 98) > eshell--process-option("echo" "baz" 0 0 ((110 nil (nil) output-newli > eshell--process-args("echo" ("-baz") ((110 nil (nil) output-newline > eshell--do-opts("echo" ((110 nil (nil) output-newline "do not output > eshell/echo("-baz") > apply(eshell/echo "-baz") [snip] > eshell-command-result("echo ${*echo \"foo\nbar\"}-baz") > eshell-test-command-result("echo ${*echo \"foo\nbar\"}-baz") > eshell-command-result-equal("echo ${*echo \"foo\nbar\"}-baz" ("foo" > #f(compiled-function () #)() > ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test > ert-run-test(#s(ert-test :name esh-var-test/interp-concat-cmd :docum > ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m > ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n > ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) ( > ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un > eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( > command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/eshell/esh-var-tests > command-line() > normal-top-level() > Test esh-var-test/interp-concat-cmd condition: > (error "echo: unrecognized option -b") > FAILED 20/110 esh-var-test/interp-concat-cmd (0.616546 sec) at > lisp/eshell/esh-var-tests.el:275 This looks like a race condition when executing this command: echo ${*echo "foo\nbar"}-baz That *should* print "foo\nbar-baz", but it tries to print "-baz" (and fails). That appears to be because the subcommand (*echo "foo\nbar") produces no output. I'll inspect the code here more to see if there are any obvious places that we're not waiting long enough for the output. However, I've never been able to reproduce this locally, so it might be time to add more debug instrumentation to Eshell... (Michael Albinus - CCed - has also seen similar sorts of issues on EMBA. They're usually different tests that fail, but they all look like similar issues where we get no output from a subcommand.)