* bug#8947: 24.0.50; `describe-mode': `help-mode-map' pollutes minor mode descriptions
@ 2011-06-27 22:41 Drew Adams
2014-02-10 5:07 ` Lars Ingebrigtsen
0 siblings, 1 reply; 15+ messages in thread
From: Drew Adams @ 2011-06-27 22:41 UTC (permalink / raw)
To: 8947
This bug seems to date from the first day that `describe-mode' included
minor-mode information.
emacs -Q
Visit any *.el file, hit `C-h m', then search for `Transient' in *Help*.
The help for `transient-mark-mode' says this:
"...for example, incremental search, <, and >."
`<' and `>' here should be `M-<' and `M->'. The bug happens because
`help-mode-map' is being used to interpret `\\[beginning-of-buffer]'
and `\\[end-of-buffer]'. In the *Help* buffer, where the text is
used, the current keymap is being picked up, where these commands
are bound to `<' and `>'.
Note that the problem isn't manifested for something like `C-h f
transient-mark-mode'. In that case the bindings picked up are those of
the current buffer where the command is issued. If you do that in
*Help* then you get `<' and `>'. If you do it in *.el then you get
`M-<' and `M->'.
In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600)
of 2011-06-27 on 3249CTO
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.5) --no-opt --cflags
-Ic:/build/include'
^ permalink raw reply [flat|nested] 15+ messages in thread
* bug#8947: 24.0.50; `describe-mode': `help-mode-map' pollutes minor mode descriptions
2011-06-27 22:41 bug#8947: 24.0.50; `describe-mode': `help-mode-map' pollutes minor mode descriptions Drew Adams
@ 2014-02-10 5:07 ` Lars Ingebrigtsen
2016-04-28 11:04 ` Lars Ingebrigtsen
0 siblings, 1 reply; 15+ messages in thread
From: Lars Ingebrigtsen @ 2014-02-10 5:07 UTC (permalink / raw)
To: Drew Adams; +Cc: 8947
"Drew Adams" <drew.adams@oracle.com> writes:
> Visit any *.el file, hit `C-h m', then search for `Transient' in *Help*.
> The help for `transient-mark-mode' says this:
>
> "...for example, incremental search, <, and >."
>
> `<' and `>' here should be `M-<' and `M->'. The bug happens because
> `help-mode-map' is being used to interpret `\\[beginning-of-buffer]'
> and `\\[end-of-buffer]'. In the *Help* buffer, where the text is
> used, the current keymap is being picked up, where these commands
> are bound to `<' and `>'.
This bug still exists in Emacs 24.3.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog http://lars.ingebrigtsen.no/
^ permalink raw reply [flat|nested] 15+ messages in thread
* bug#8947: 24.0.50; `describe-mode': `help-mode-map' pollutes minor mode descriptions
2014-02-10 5:07 ` Lars Ingebrigtsen
@ 2016-04-28 11:04 ` Lars Ingebrigtsen
2016-05-01 18:32 ` Lars Ingebrigtsen
0 siblings, 1 reply; 15+ messages in thread
From: Lars Ingebrigtsen @ 2016-04-28 11:04 UTC (permalink / raw)
To: Drew Adams; +Cc: 8947
Lars Ingebrigtsen <larsi@gnus.org> writes:
> "Drew Adams" <drew.adams@oracle.com> writes:
>
>> Visit any *.el file, hit `C-h m', then search for `Transient' in *Help*.
>> The help for `transient-mark-mode' says this:
>>
>> "...for example, incremental search, <, and >."
>>
>> `<' and `>' here should be `M-<' and `M->'. The bug happens because
>> `help-mode-map' is being used to interpret `\\[beginning-of-buffer]'
>> and `\\[end-of-buffer]'. In the *Help* buffer, where the text is
>> used, the current keymap is being picked up, where these commands
>> are bound to `<' and `>'.
>
> This bug still exists in Emacs 24.3.
Here's a shorter test case:
(progn
(describe-function 'transient-mark-mode)
(with-current-buffer (get-buffer "*Help*")
(revert-buffer)))
After answering "y", the `M-'s will go missing before the `<' and '>'.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 15+ messages in thread
* bug#8947: 24.0.50; `describe-mode': `help-mode-map' pollutes minor mode descriptions
2016-04-28 11:04 ` Lars Ingebrigtsen
@ 2016-05-01 18:32 ` Lars Ingebrigtsen
2016-05-01 20:06 ` Drew Adams
0 siblings, 1 reply; 15+ messages in thread
From: Lars Ingebrigtsen @ 2016-05-01 18:32 UTC (permalink / raw)
To: Drew Adams; +Cc: 8947
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Here's a shorter test case:
>
> (progn
> (describe-function 'transient-mark-mode)
> (with-current-buffer (get-buffer "*Help*")
> (revert-buffer)))
>
> After answering "y", the `M-'s will go missing before the `<' and '>'.
Hm... well, after fiddling with this a bit more, I see that it's
describing all these minor mode bindings in the context of the buffer
you were in when you called the description command. I think that's
correct. If you have these commands bound to `<' etc in that mode, then
that is what the help command will say.
So the form above will give different results when run from, say,
*scratch* and from a special mode, and that's fine. Closing.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 15+ messages in thread
* bug#8947: 24.0.50; `describe-mode': `help-mode-map' pollutes minor mode descriptions
2016-05-01 18:32 ` Lars Ingebrigtsen
@ 2016-05-01 20:06 ` Drew Adams
2016-05-01 20:20 ` Michael Heerdegen
2016-05-01 20:23 ` Lars Ingebrigtsen
0 siblings, 2 replies; 15+ messages in thread
From: Drew Adams @ 2016-05-01 20:06 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 8947
> Hm... well, after fiddling with this a bit more, I see that it's
> describing all these minor mode bindings in the context of the buffer
> you were in when you called the description command. I think that's
> correct. If you have these commands bound to `<' etc in that mode, then
> that is what the help command will say.
>
> So the form above will give different results when run from, say,
> *scratch* and from a special mode, and that's fine. Closing.
One of us is missing something, I think.
The recipe I gave was this:
emacs -Q
Visit any *.el file, hit `C-h m', then search for `Transient'
^^^^^^^^^^^^^^^^^^^
in *Help*. The help for `transient-mark-mode' says this:
"...for example, incremental search, <, and >."
And I explained the cause: The doc for `transient-mark-mode'
is being picked up after *Help* has become the current buffer.
That is not the correct behavior.
It is NOT being picked up from "the context of the buffer
you were in when you called the description command". That's
exactly what the bug is: it is NOT behaving as you claim it
is. It is showing you `transient-mark-mode' bindings for
`Help' mode, not for `Emacs-Lisp' mode, which was the mode
of the buffer where you hit `C-h m'.
This should not have been closed, or else I am truly missing
something.
^ permalink raw reply [flat|nested] 15+ messages in thread
* bug#8947: 24.0.50; `describe-mode': `help-mode-map' pollutes minor mode descriptions
2016-05-01 20:06 ` Drew Adams
@ 2016-05-01 20:20 ` Michael Heerdegen
2021-10-21 19:44 ` Stefan Kangas
2016-05-01 20:23 ` Lars Ingebrigtsen
1 sibling, 1 reply; 15+ messages in thread
From: Michael Heerdegen @ 2016-05-01 20:20 UTC (permalink / raw)
To: Drew Adams; +Cc: Lars Ingebrigtsen, 8947
Drew Adams <drew.adams@oracle.com> writes:
> The recipe I gave was this:
>
> emacs -Q
>
> Visit any *.el file, hit `C-h m', then search for `Transient'
> ^^^^^^^^^^^^^^^^^^^
> in *Help*. The help for `transient-mark-mode' says this:
>
> "...for example, incremental search, <, and >."
>
> And I explained the cause: The doc for `transient-mark-mode'
> is being picked up after *Help* has become the current buffer.
> That is not the correct behavior.
I agree. I can reproduce this, and your explanation makes sense.
Michael.
^ permalink raw reply [flat|nested] 15+ messages in thread
* bug#8947: 24.0.50; `describe-mode': `help-mode-map' pollutes minor mode descriptions
2016-05-01 20:06 ` Drew Adams
2016-05-01 20:20 ` Michael Heerdegen
@ 2016-05-01 20:23 ` Lars Ingebrigtsen
2016-10-21 14:30 ` Drew Adams
1 sibling, 1 reply; 15+ messages in thread
From: Lars Ingebrigtsen @ 2016-05-01 20:23 UTC (permalink / raw)
To: Drew Adams; +Cc: 8947
Drew Adams <drew.adams@oracle.com> writes:
> One of us is missing something, I think.
>
> The recipe I gave was this:
>
> emacs -Q
>
> Visit any *.el file, hit `C-h m', then search for `Transient'
> ^^^^^^^^^^^^^^^^^^^
> in *Help*. The help for `transient-mark-mode' says this:
>
> "...for example, incremental search, <, and >."
Hm, so it does. Reopening.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 15+ messages in thread
* bug#8947: 24.0.50; `describe-mode': `help-mode-map' pollutes minor mode descriptions
2016-05-01 20:23 ` Lars Ingebrigtsen
@ 2016-10-21 14:30 ` Drew Adams
2016-10-21 14:51 ` Noam Postavsky
0 siblings, 1 reply; 15+ messages in thread
From: Drew Adams @ 2016-10-21 14:30 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 8947
This bug was summarily closed today as "wontfix". Why?
No explanation; just closed out of the blue. Perhaps
the close was a typo on the bug number?
Please read the (short, simple) thread. Two Emacs developers
have confirmed that this is a bug, one of them after thinking
at first that it might not be (it was closed and then reopened).
Please reopen (and fix) this bug. Thx.
^ permalink raw reply [flat|nested] 15+ messages in thread
* bug#8947: 24.0.50; `describe-mode': `help-mode-map' pollutes minor mode descriptions
2016-10-21 14:30 ` Drew Adams
@ 2016-10-21 14:51 ` Noam Postavsky
2016-10-21 15:42 ` Drew Adams
0 siblings, 1 reply; 15+ messages in thread
From: Noam Postavsky @ 2016-10-21 14:51 UTC (permalink / raw)
To: Drew Adams; +Cc: Lars Ingebrigtsen, 8947
On Fri, Oct 21, 2016 at 10:30 AM, Drew Adams <drew.adams@oracle.com> wrote:
> This bug was summarily closed today as "wontfix".
No, it was closed as wontfix on May 1st, 2016, then reopened after
some discussion.
https://debbugs.gnu.org/cgi/bugreport.cgi?msg=18;bug=8947
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=8947#29
I just removed the wontfix tag last night (since Lars obviously forgot
to remove it when reopening)
https://debbugs.gnu.org/cgi/bugreport.cgi?msg=33;bug=8947
^ permalink raw reply [flat|nested] 15+ messages in thread
* bug#8947: 24.0.50; `describe-mode': `help-mode-map' pollutes minor mode descriptions
2016-10-21 14:51 ` Noam Postavsky
@ 2016-10-21 15:42 ` Drew Adams
0 siblings, 0 replies; 15+ messages in thread
From: Drew Adams @ 2016-10-21 15:42 UTC (permalink / raw)
To: Noam Postavsky; +Cc: Lars Ingebrigtsen, 8947
> > This bug was summarily closed today as "wontfix".
>
> No, it was closed as wontfix on May 1st, 2016, then reopened after
> some discussion.
>
> https://debbugs.gnu.org/cgi/bugreport.cgi?msg=18;bug=8947
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=8947#29
>
> I just removed the wontfix tag last night (since Lars obviously forgot
> to remove it when reopening)
>
> https://debbugs.gnu.org/cgi/bugreport.cgi?msg=33;bug=8947
OK, thanks for doing that.
Sorry for misunderstanding the control message.
^ permalink raw reply [flat|nested] 15+ messages in thread
* bug#8947: 24.0.50; `describe-mode': `help-mode-map' pollutes minor mode descriptions
2016-05-01 20:20 ` Michael Heerdegen
@ 2021-10-21 19:44 ` Stefan Kangas
2021-10-21 20:59 ` bug#8947: [External] : " Drew Adams
0 siblings, 1 reply; 15+ messages in thread
From: Stefan Kangas @ 2021-10-21 19:44 UTC (permalink / raw)
To: Michael Heerdegen; +Cc: Lars Ingebrigtsen, 8947
Michael Heerdegen <michael_heerdegen@web.de> writes:
> Drew Adams <drew.adams@oracle.com> writes:
>
>> The recipe I gave was this:
>>
>> emacs -Q
>>
>> Visit any *.el file, hit `C-h m', then search for `Transient'
>> ^^^^^^^^^^^^^^^^^^^
>> in *Help*. The help for `transient-mark-mode' says this:
>>
>> "...for example, incremental search, <, and >."
>>
>> And I explained the cause: The doc for `transient-mark-mode'
>> is being picked up after *Help* has become the current buffer.
>> That is not the correct behavior.
>
> I agree. I can reproduce this, and your explanation makes sense.
I can no longer reproduce this using the above recipe; the
`transient-mode-mark' docstring was changed in commit b99192fe24fc.
Do we have an up-to-date reproducer for this?
^ permalink raw reply [flat|nested] 15+ messages in thread
* bug#8947: [External] : Re: bug#8947: 24.0.50; `describe-mode': `help-mode-map' pollutes minor mode descriptions
2021-10-21 19:44 ` Stefan Kangas
@ 2021-10-21 20:59 ` Drew Adams
2021-10-21 21:19 ` Stefan Kangas
0 siblings, 1 reply; 15+ messages in thread
From: Drew Adams @ 2021-10-21 20:59 UTC (permalink / raw)
To: Stefan Kangas, Michael Heerdegen; +Cc: Lars Ingebrigtsen, 8947@debbugs.gnu.org
> I can no longer reproduce this using the above recipe; the
> `transient-mode-mark' docstring was changed in commit b99192fe24fc.
>
> Do we have an up-to-date reproducer for this?
Not from me. I don't see the problem in Emacs 27.2.
^ permalink raw reply [flat|nested] 15+ messages in thread
* bug#8947: [External] : Re: bug#8947: 24.0.50; `describe-mode': `help-mode-map' pollutes minor mode descriptions
2021-10-21 20:59 ` bug#8947: [External] : " Drew Adams
@ 2021-10-21 21:19 ` Stefan Kangas
2021-10-21 21:48 ` Drew Adams
0 siblings, 1 reply; 15+ messages in thread
From: Stefan Kangas @ 2021-10-21 21:19 UTC (permalink / raw)
To: Drew Adams, Michael Heerdegen; +Cc: Lars Ingebrigtsen, 8947@debbugs.gnu.org
tags 8947 unreproducible
close 8947
thanks
Drew Adams <drew.adams@oracle.com> writes:
>> I can no longer reproduce this using the above recipe; the
>> `transient-mode-mark' docstring was changed in commit b99192fe24fc.
>>
>> Do we have an up-to-date reproducer for this?
>
> Not from me. I don't see the problem in Emacs 27.2.
OK, I'm therefore closing this bug report as unreproducible. If anyone
knows how to reproduce it, please write back and we can reopen the bug
report.
^ permalink raw reply [flat|nested] 15+ messages in thread
* bug#8947: [External] : Re: bug#8947: 24.0.50; `describe-mode': `help-mode-map' pollutes minor mode descriptions
2021-10-21 21:19 ` Stefan Kangas
@ 2021-10-21 21:48 ` Drew Adams
2021-10-21 22:21 ` Stefan Kangas
0 siblings, 1 reply; 15+ messages in thread
From: Drew Adams @ 2021-10-21 21:48 UTC (permalink / raw)
To: Stefan Kangas, Michael Heerdegen; +Cc: Lars Ingebrigtsen, 8947@debbugs.gnu.org
> tags 8947 unreproducible
> close 8947
> thanks
>
> Drew Adams <drew.adams@oracle.com> writes:
>
> >> I can no longer reproduce this using the above recipe; the
> >> `transient-mode-mark' docstring was changed in commit b99192fe24fc.
> >>
> >> Do we have an up-to-date reproducer for this?
> >
> > Not from me. I don't see the problem in Emacs 27.2.
>
> OK, I'm therefore closing this bug report as unreproducible. If anyone
> knows how to reproduce it, please write back and we can reopen the bug
> report.
Does unreproducible mean that it never could be reproduced, or that it can no longer be reproduced?
If it was reproducible (which this was), and it no longer manifests, then it was _fixed_ (even if by accident), no?
^ permalink raw reply [flat|nested] 15+ messages in thread
* bug#8947: [External] : Re: bug#8947: 24.0.50; `describe-mode': `help-mode-map' pollutes minor mode descriptions
2021-10-21 21:48 ` Drew Adams
@ 2021-10-21 22:21 ` Stefan Kangas
0 siblings, 0 replies; 15+ messages in thread
From: Stefan Kangas @ 2021-10-21 22:21 UTC (permalink / raw)
To: Drew Adams, Michael Heerdegen; +Cc: Lars Ingebrigtsen, 8947@debbugs.gnu.org
Drew Adams <drew.adams@oracle.com> writes:
> Does unreproducible mean that it never could be reproduced, or that it
> can no longer be reproduced?
AFAIU, it was reproducible, but it is no longer.
I guess fixed might be better, so feel free to change its status.
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2021-10-21 22:21 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-06-27 22:41 bug#8947: 24.0.50; `describe-mode': `help-mode-map' pollutes minor mode descriptions Drew Adams
2014-02-10 5:07 ` Lars Ingebrigtsen
2016-04-28 11:04 ` Lars Ingebrigtsen
2016-05-01 18:32 ` Lars Ingebrigtsen
2016-05-01 20:06 ` Drew Adams
2016-05-01 20:20 ` Michael Heerdegen
2021-10-21 19:44 ` Stefan Kangas
2021-10-21 20:59 ` bug#8947: [External] : " Drew Adams
2021-10-21 21:19 ` Stefan Kangas
2021-10-21 21:48 ` Drew Adams
2021-10-21 22:21 ` Stefan Kangas
2016-05-01 20:23 ` Lars Ingebrigtsen
2016-10-21 14:30 ` Drew Adams
2016-10-21 14:51 ` Noam Postavsky
2016-10-21 15:42 ` Drew Adams
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).