bug#25222: Incorrect indices in ansi-color (227e996946d4629fa8f6d665564a37668290c87f, new in Emacs 25)

bug#25222: Incorrect indices in ansi-color (227e996946d4629fa8f6d665564a37668290c87f, new in Emacs 25)

[Clément Pit--Claudel]

[-- Attachment #1.1: Type: text/plain, Size: 1773 bytes --]

Package: emacs
X-Debbugs-CC: Daniel Colascione <dancol@dancol.org>

Hi all,

The following snippet throws an out-of-bounds error on master and in Emacs 25.:

(ansi-color-filter-apply
 (base64-decode-string "UHl0aG9uIDIuNy4xMiAoZGVmYXVsdCwgTm92IDE5IDIwMTYsIDA2OjQ4OjEwKSAKVHlwZSAiY29w
eXJpZ2h0IiwgImNyZWRpdHMiIG9yICJsaWNlbnNlIiBmb3IgbW9yZSBpbmZvcm1hdGlvbi4KCklQ
eXRob24gNS4xLjAgLS0gQW4gZW5oYW5jZWQgSW50ZXJhY3RpdmUgUHl0aG9uLgo/ICAgICAgICAg
LT4gSW50cm9kdWN0aW9uIGFuZCBvdmVydmlldyBvZiBJUHl0aG9uJ3MgZmVhdHVyZXMuCiVxdWlj
a3JlZiAtPiBRdWljayByZWZlcmVuY2UuCmhlbHAgICAgICAtPiBQeXRob24ncyBvd24gaGVscCBz
eXN0ZW0uCm9iamVjdD8gICAtPiBEZXRhaWxzIGFib3V0ICdvYmplY3QnLCB1c2UgJ29iamVjdD8/
JyBmb3IgZXh0cmEgZGV0YWlscy4KChtbPzFsG1s2bhtbPzIwMDRoG1s/MjVsG1s/N2wbWzBtDRtb
MG0bW0oNG1s/MTJsG1s/MjVoG1tKG1swbRtbPzIwMDRsG1s2bhtbPzIwMDRoG1s/MjVsG1s/N2wb
WzBtG1swbRtbShtbMDszODs1OzI4bUluIFsbWzA7Mzg7NTsxMDsxbTEbWzA7Mzg7NTsyOG1dOiAb
WzhEG1s4QxtbPzEybBtbPzI1aA=="))

This is caused by the following snippet:

    ;; find the next escape sequence
    (while (setq end (string-match ansi-color-regexp string start))
      (setq result (concat result (substring string start end))
            start (match-end 0)))
    ;; eliminate unrecognized escape sequences
    (while (string-match ansi-color-drop-regexp string)
      (setq string
            (replace-match "" nil nil string)))
    ;; save context, add the remainder of the string to the result
    (let (fragment)
      (if (string-match "\033" string start)

(the error happens on the last line).  The "unrecognized escape sequences" part does not adjust the "start" variable.

Maybe that section could just be moved up (before "find the next escape sequence")? Daniel, what do you think?

Cheers,
Clément.



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

bug#25222: Incorrect indices in ansi-color (227e996946d4629fa8f6d665564a37668290c87f, new in Emacs 25)

[Glenn Morris]

There are several reports about this. Eg 24223, 21381, 24189.
Perhaps this is something to fix for 25.2.

bug#25222: Incorrect indices in ansi-color (227e996946d4629fa8f6d665564a37668290c87f, new in Emacs 25)

[Eli Zaretskii]

> From: Glenn Morris <rgm@gnu.org>
> Date: Wed, 11 Jan 2017 13:24:31 -0500
> Cc: 25222@debbugs.gnu.org
> 
> There are several reports about this. Eg 24223, 21381, 24189.
> Perhaps this is something to fix for 25.2.

I agree, and would encourage people to hurry with patches for these
problems, because RC1 of 25.2 is probably due in a week or two.

bug#25222: Incorrect indices in ansi-color (227e996946d4629fa8f6d665564a37668290c87f, new in Emacs 25)

[Clément Pit--Claudel]

[-- Attachment #1.1: Type: text/plain, Size: 619 bytes --]

On 2017-01-12 11:06, Eli Zaretskii wrote:
>> From: Glenn Morris <rgm@gnu.org>
>> Date: Wed, 11 Jan 2017 13:24:31 -0500
>> Cc: 25222@debbugs.gnu.org
>>
>> There are several reports about this. Eg 24223, 21381, 24189.
>> Perhaps this is something to fix for 25.2.
> 
> I agree, and would encourage people to hurry with patches for these
> problems, because RC1 of 25.2 is probably due in a week or two.

I posted a potential solution in a previous message, but I was hoping for the original author (Daniel) to comment on it.  Otherwise, I don't feel too comfortable touching that code.

Cheers,
Clément.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

bug#25222: Incorrect indices in ansi-color (227e996946d4629fa8f6d665564a37668290c87f, new in Emacs 25)

[Glenn Morris]

Clément Pit--Claudel wrote:

> I posted a potential solution in a previous message,

You mean the same one as in https://debbugs.gnu.org/24223 ?

bug#25222: Incorrect indices in ansi-color (227e996946d4629fa8f6d665564a37668290c87f, new in Emacs 25)

[Daniel Colascione]

On Thu, Jan 12 2017, Clément Pit--Claudel wrote:
> On 2017-01-12 11:06, Eli Zaretskii wrote:
>>> From: Glenn Morris <rgm@gnu.org>
>>> Date: Wed, 11 Jan 2017 13:24:31 -0500
>>> Cc: 25222@debbugs.gnu.org
>>>
>>> There are several reports about this. Eg 24223, 21381, 24189.
>>> Perhaps this is something to fix for 25.2.
>> 
>> I agree, and would encourage people to hurry with patches for these
>> problems, because RC1 of 25.2 is probably due in a week or two.
>
> I posted a potential solution in a previous message, but I was hoping
> for the original author (Daniel) to comment on it.  Otherwise, I don't
> feel too comfortable touching that code.

Gah, sorry. Personal issues lately.  I'll take another look at it.
I'm not really comfortable with that code at all, to be honest.  IMHO,
we should rewrite the escapes sequence parser as an explicit restartable
state machine instead of munging things with regular expressions.

bug#25222: Incorrect indices in ansi-color (227e996946d4629fa8f6d665564a37668290c87f, new in Emacs 25)

[Clément Pit--Claudel]

[-- Attachment #1.1: Type: text/plain, Size: 248 bytes --]

On 2017-01-12 12:04, Glenn Morris wrote:
> Clément Pit--Claudel wrote:
> 
>> I posted a potential solution in a previous message,
> 
> You mean the same one as in https://debbugs.gnu.org/24223 ?

Yes; thanks for tracking that reference!


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]