bug#19528: electric-pair-mode as a minor mode?

bug#19528: electric-pair-mode as a minor mode?

[João Távora]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> Tom Willemse <tom@ryuslash.org> writes:
>> Not to be a nuisance, but I wrote a patch for that some time ago and I'm
>> still waiting on a response:
>> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=19528
>
> João, can you take a look at that?

Looks pretty good so I just pushed:

    commit 40b3dcd2c06e30048be0bdc32861148a53660c90
    Author: Tom Willemse <tom@ryuslash.org>
    Date:   Sat Mar 28 14:43:33 2015 +0000
     
        New `electric-pair-local-mode'
        
        Fixes: big#19528
        
        * lisp/elec-pair.el (electric-pair-local-mode): New command.
        (electric-pair-mode): Mention `electric-pair-local-mode' in the
        docstring.

Didn't check for Tom's copyright assignment since I believe it counts as
a trivial patch (<15loc).

João

bug#19528: electric-pair-mode as a minor mode?

[Glenn Morris]

João Távora wrote:

> Didn't check for Tom's copyright assignment since I believe it counts as
> a trivial patch (<15loc).

It never works like that.

1) Add "(tiny change)" to the ChangeLog entry.
2) You always need to check for previous changes from the same author
(there are several) and estimate the total lines contributed so far.

bug#19528: electric-pair-mode as a minor mode?

[João Távora]

Glenn Morris <rgm@gnu.org> writes:

> João Távora wrote:
>
>> Didn't check for Tom's copyright assignment since I believe it counts as
>> a trivial patch (<15loc).
>
> It never works like that.
>
> 1) Add "(tiny change)" to the ChangeLog entry.
> 2) You always need to check for previous changes from the same author
> (there are several) and estimate the total lines contributed so far.
>
I'm very sorry, I didn't know it worked like that, I'm also currently
locked out of my fencepost account so I can't check the copyright file
(is there another way to check it?)

How do I decide once I've estimated the number of "total lines"? Does
that have to amount to 15loc max?

João

bug#19528: electric-pair-mode as a minor mode?

[Glenn Morris]

It's no big deal.

João Távora wrote:

> locked out of my fencepost account so I can't check the copyright file
> (is there another way to check it?)

Not AFAIK.

> How do I decide once I've estimated the number of "total lines"? Does
> that have to amount to 15loc max?

Yes, though that is a rough number. And it's not a literal line count.
Eg a purely mechanical s/foo/bar on 100 lines counts as 1 line, IMO.

Life is much easier if people complete assignments though. :)