unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Gemini Lasswell <gazally@runbox.com>
Cc: 24753@debbugs.gnu.org
Subject: bug#24753: 26.0.50; Error using Edebug on code that uses cl-defmethod
Date: Tue, 2 May 2017 04:11:25 +0300	[thread overview]
Message-ID: <6d9b038c-2241-3232-7552-0d74e4dd70f5@yandex.ru> (raw)
In-Reply-To: <8760hqvoer.fsf@chinook.i-did-not-set--mail-host-address--so-tickle-me>

Hey Gemini,

I've read the edebug manual, read the patch some more, and it looks good.

Please go ahead and install it, since nobody else seems to have any 
objections either. Thank you.

On 27.04.2017 0:39, Gemini Lasswell wrote:

> I'm not totally clear on what that example is doing either. I just
> grabbed it from cl-generic-tests.el because it was short and reproduced
> the bug. But I think the idea is to let you define a method so that
> (setf (foo x) y) does something analogous to (setf (cdr x) y).

Ah, cool.

> Your scenario is another way to reproduce the bug. When Edebug
> instruments something it attaches a cache of markers to the symbol. So
> when two methods with the same name are instrumented, the cache of
> markers pointing into the first method's source is replaced with a cache
> of markers for the second method. And then if you debug into the first
> method Edebug sees markers pointing at the wrong method and gets
> confused. My patch works by making Edebug generate new symbols for each
> method.

I wish there was a better way to generate that symbol, taking into 
account the arguments list. But probably not without some changes to edebug.

When the `name' specification element is absent, do you know if can 
affect anything else, aside from a few markers being 
non-garbage-collectable?





  reply	other threads:[~2017-05-02  1:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-21 15:15 bug#24753: 26.0.50; Error using Edebug on code that uses cl-defmethod Gemini Lasswell
2016-10-23  3:50 ` Gemini Lasswell
2017-03-03  2:49   ` bug#24753: Patch (was: bug#24753: 26.0.50; Error using Edebug on code that uses cl-defmethod) Gemini Lasswell
2017-04-11 12:16 ` bug#24753: 26.0.50; Error using Edebug on code that uses cl-defmethod Dmitry Gutov
2017-04-26 21:39   ` Gemini Lasswell
2017-05-02  1:11     ` Dmitry Gutov [this message]
2017-05-02  7:24       ` Eli Zaretskii
2017-05-02  8:41         ` Dmitry Gutov
2017-05-07  2:11         ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6d9b038c-2241-3232-7552-0d74e4dd70f5@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=24753@debbugs.gnu.org \
    --cc=gazally@runbox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).