From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#24753: 26.0.50; Error using Edebug on code that uses cl-defmethod Date: Tue, 2 May 2017 04:11:25 +0300 Message-ID: <6d9b038c-2241-3232-7552-0d74e4dd70f5@yandex.ru> References: <35640890-0451-771d-578e-666552b141ec@yandex.ru> <8760hqvoer.fsf@chinook.i-did-not-set--mail-host-address--so-tickle-me> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1493687534 20801 195.159.176.226 (2 May 2017 01:12:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 2 May 2017 01:12:14 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:53.0) Gecko/20100101 Thunderbird/53.0 Cc: 24753@debbugs.gnu.org To: Gemini Lasswell Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 02 03:12:09 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d5MMJ-0005Fs-PT for geb-bug-gnu-emacs@m.gmane.org; Tue, 02 May 2017 03:12:07 +0200 Original-Received: from localhost ([::1]:56272 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d5MMN-0004EC-NY for geb-bug-gnu-emacs@m.gmane.org; Mon, 01 May 2017 21:12:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48865) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d5MMH-0004E7-Ur for bug-gnu-emacs@gnu.org; Mon, 01 May 2017 21:12:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d5MME-0005ew-R6 for bug-gnu-emacs@gnu.org; Mon, 01 May 2017 21:12:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51908) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d5MME-0005ej-MI for bug-gnu-emacs@gnu.org; Mon, 01 May 2017 21:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d5MME-00011G-Hs for bug-gnu-emacs@gnu.org; Mon, 01 May 2017 21:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 May 2017 01:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24753 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed patch Original-Received: via spool by 24753-submit@debbugs.gnu.org id=B24753.14936874973872 (code B ref 24753); Tue, 02 May 2017 01:12:02 +0000 Original-Received: (at 24753) by debbugs.gnu.org; 2 May 2017 01:11:37 +0000 Original-Received: from localhost ([127.0.0.1]:50107 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d5MLp-00010N-A3 for submit@debbugs.gnu.org; Mon, 01 May 2017 21:11:37 -0400 Original-Received: from mail-wr0-f173.google.com ([209.85.128.173]:34251) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d5MLo-00010A-01 for 24753@debbugs.gnu.org; Mon, 01 May 2017 21:11:36 -0400 Original-Received: by mail-wr0-f173.google.com with SMTP id l9so70411853wre.1 for <24753@debbugs.gnu.org>; Mon, 01 May 2017 18:11:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=6TcCPA/jlrUzWpJMIE9JBTQcxLgSSSpVVD4e1Y/kJFk=; b=AMwb9eSNNWlgKX3siKPzwDmu3Ln9ke/zRghobHe8NLK5YAJG73miOgi38FpwQ2uh+m z6zkwHUrXSjPjhzb5/0+Ru1L8U4G0PPrelMf2c0lhwbzc7n7OU0c/TVshhyEjZhqoGZ7 YhKGQ7k4iqcatZqui6REaYPIsIPvWPgA7AFh6gnFWfIschqxExQY+UdRfgVLNPsU9/6Z yUALH2AKxSuG8U7Q8gzoKRwAeWkiUfEnf5+zbn0w+tnZDTqaodF/Qv33K9xVAsJA/7Xf 3Znq7g/fOMdbmNG8gi6aH6fRfXVfpQmGdNL+McC1PPmwVIvieZyO2EPJun5oms75PUIx q90Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6TcCPA/jlrUzWpJMIE9JBTQcxLgSSSpVVD4e1Y/kJFk=; b=BxfH/V1nGomncSnTK6OFLy++KKfdvkXLBuhUtu8VOOlrt05ezpUwGgc7GEDHvI9pmD wzyqfpnjAMqWFHyWczFncG42gBbQM6LSWoP8s/jUuUT+mTtJPCrHBkajYCb7bZWviqvB Ztewh/9FfuILQtDDfKbjyEBpEeMzkMyr0ZVUT8yRjTJuFw21DQwC7EpMSpn01srBTKN9 rzq1/8Syoxn2irybvXZRGVa4OrJxiAQgxl1g8hELeDDhowtnRypFkv2F2ulx9+D6rEcG fLbh0dKym++YRfgY8KMXP93XpDvcR/lhjv5Lb1+ayU1sBSnhfdZziWb/gxaZwRIQFWQC MhAg== X-Gm-Message-State: AN3rC/6AnnwMfE54DCzArCh+ZDWzP4zuDYm0hhyGjdCCJSdM7V/Q9bGW NlWuaiZRT4lfUA== X-Received: by 10.223.165.94 with SMTP id j30mr19339943wrb.111.1493687490167; Mon, 01 May 2017 18:11:30 -0700 (PDT) Original-Received: from [192.168.1.3] ([185.105.173.156]) by smtp.googlemail.com with ESMTPSA id f189sm6118591wmf.34.2017.05.01.18.11.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 May 2017 18:11:29 -0700 (PDT) In-Reply-To: <8760hqvoer.fsf@chinook.i-did-not-set--mail-host-address--so-tickle-me> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:132178 Archived-At: Hey Gemini, I've read the edebug manual, read the patch some more, and it looks good. Please go ahead and install it, since nobody else seems to have any objections either. Thank you. On 27.04.2017 0:39, Gemini Lasswell wrote: > I'm not totally clear on what that example is doing either. I just > grabbed it from cl-generic-tests.el because it was short and reproduced > the bug. But I think the idea is to let you define a method so that > (setf (foo x) y) does something analogous to (setf (cdr x) y). Ah, cool. > Your scenario is another way to reproduce the bug. When Edebug > instruments something it attaches a cache of markers to the symbol. So > when two methods with the same name are instrumented, the cache of > markers pointing into the first method's source is replaced with a cache > of markers for the second method. And then if you debug into the first > method Edebug sees markers pointing at the wrong method and gets > confused. My patch works by making Edebug generate new symbols for each > method. I wish there was a better way to generate that symbol, taking into account the arguments list. But probably not without some changes to edebug. When the `name' specification element is absent, do you know if can affect anything else, aside from a few markers being non-garbage-collectable?