unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#11124: 24.0.94; doc of `customize-apropos-*'
@ 2012-03-29 17:31 Drew Adams
  2012-03-30 14:47 ` Drew Adams
  2012-04-23 12:33 ` Chong Yidong
  0 siblings, 2 replies; 3+ messages in thread
From: Drew Adams @ 2012-03-29 17:31 UTC (permalink / raw)
  To: 11124

All of the `customize-apropos-*' commands except for `customize-apropos'
need to have their doc strings updated.  The arg is no longer
necessarily a REGEXP.  The doc string should say the same thing for
these commands as it says for `customize-apropos' about the PATTERN arg
(or refer to the `customize-apropos' doc).

In GNU Emacs 24.0.94.1 (i386-mingw-nt5.1.2600)
 of 2012-03-19 on MARVIN
Windowing system distributor `Microsoft Corp.', version 5.1.2600
Configured using:
 `configure --with-gcc (4.6) --no-opt --enable-checking --cflags
 -ID:/devel/emacs/libs/libXpm-3.5.8/include
 -ID:/devel/emacs/libs/libXpm-3.5.8/src
 -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include
 -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include
 -ID:/devel/emacs/libs/giflib-4.1.4-1/include
 -ID:/devel/emacs/libs/jpeg-6b-4/include
 -ID:/devel/emacs/libs/tiff-3.8.2-1/include
 -ID:/devel/emacs/libs/gnutls-3.0.9/include'
 






^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#11124: 24.0.94; doc of `customize-apropos-*'
  2012-03-29 17:31 bug#11124: 24.0.94; doc of `customize-apropos-*' Drew Adams
@ 2012-03-30 14:47 ` Drew Adams
  2012-04-23 12:33 ` Chong Yidong
  1 sibling, 0 replies; 3+ messages in thread
From: Drew Adams @ 2012-03-30 14:47 UTC (permalink / raw)
  To: 11124

> All of the `customize-apropos-*' commands except for 
> `customize-apropos' need to have their doc strings updated.
> The arg is no longer necessarily a REGEXP.  The doc string
> should say the same thing for these commands as it says for
> `customize-apropos' about the PATTERN arg
> (or refer to the `customize-apropos' doc).

I was wrong about that.  But I should have been right ;-) - they should accept a
PATTERN the same as `customize-apropos' does.

So consider this an enhancement request for each of the `customize-apropos-*'
commands to allow a PATTERN (as in `customize-apropos') instead of just a REGEXP
as arg.

Just use `apropos-read-pattern' in their `interactive' specs.

Or be smarter: move the logic of `apropos-read-pattern' out of the `interactive'
spec, and put it in the body of `customize-apropos':

(when (string= (regexp-quote pattern) pattern)
  (setq pattern  (split-string pattern "[ \t]+" 'OMIT-NULLS)))
(apropos-parse-pattern pattern)

(I also fixed bug #11132 here: provide non-nil 3rd arg.) 






^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#11124: 24.0.94; doc of `customize-apropos-*'
  2012-03-29 17:31 bug#11124: 24.0.94; doc of `customize-apropos-*' Drew Adams
  2012-03-30 14:47 ` Drew Adams
@ 2012-04-23 12:33 ` Chong Yidong
  1 sibling, 0 replies; 3+ messages in thread
From: Chong Yidong @ 2012-04-23 12:33 UTC (permalink / raw)
  To: Drew Adams; +Cc: 11124

"Drew Adams" <drew.adams@oracle.com> writes:

> All of the `customize-apropos-*' commands except for `customize-apropos'
> need to have their doc strings updated.  The arg is no longer
> necessarily a REGEXP.  The doc string should say the same thing for
> these commands as it says for `customize-apropos' about the PATTERN arg
> (or refer to the `customize-apropos' doc).

Fixed, thanks.





^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-04-23 12:33 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-29 17:31 bug#11124: 24.0.94; doc of `customize-apropos-*' Drew Adams
2012-03-30 14:47 ` Drew Adams
2012-04-23 12:33 ` Chong Yidong

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).