bug#59878: [PATCH] c++-ts-mode: Highlight nullptr as a constant

bug#59878: [PATCH] c++-ts-mode: Highlight nullptr as a constant

[Brian Leung]

[-- Attachment #1: Type: text/plain, Size: 546 bytes --]

Tags: patch





In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo
version 1.16.0, Xaw3d scroll bars)
Repository revision: 80df980e4100297942775eae4f89c5ccabe03afc
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12014000
System Description: NixOS 23.05 (Stoat)

Configured using:
 'configure
 --prefix=/nix/store/yc2vgl7zmby1dawpra4x92cfxlrvhrx1-emacs-git-20221206.0
 --disable-build-details --with-modules --with-x-toolkit=lucid
 --with-xft --with-cairo --with-native-compilation'


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-c-ts-mode-Highlight-nullptr-as-a-constant.patch --]
[-- Type: text/patch, Size: 905 bytes --]

From 6552afaede8ca29dde8eeb0a7b78dfa0e138cec8 Mon Sep 17 00:00:00 2001
From: Brian Leung <leungbk@posteo.net>
Date: Wed, 7 Dec 2022 02:12:05 -0800
Subject: [PATCH] c++-ts-mode: Highlight nullptr as a constant

* lisp/progmodes/c-ts-mode.el (c-ts-mode--font-lock-settings): Add
nullptr.
---
 lisp/progmodes/c-ts-mode.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/progmodes/c-ts-mode.el b/lisp/progmodes/c-ts-mode.el
index 0c66b4959e0..6f1488917a6 100644
--- a/lisp/progmodes/c-ts-mode.el
+++ b/lisp/progmodes/c-ts-mode.el
@@ -233,7 +233,8 @@ c-ts-mode--font-lock-settings
      (false) @font-lock-constant-face
      (null) @font-lock-constant-face
      ,@(when (eq mode 'cpp)
-         '((this) @font-lock-constant-face)))
+         '((this) @font-lock-constant-face
+           (nullptr) @font-lock-constant-face)))
 
    :language mode
    :feature 'keyword
-- 
2.38.1

bug#59878: [PATCH] c++-ts-mode: Highlight nullptr as a constant

[Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Hi!

Brian Leung <leungbk@posteo.net> writes:
> diff --git a/lisp/progmodes/c-ts-mode.el b/lisp/progmodes/c-ts-mode.el
> index 0c66b4959e0..6f1488917a6 100644
> --- a/lisp/progmodes/c-ts-mode.el
> +++ b/lisp/progmodes/c-ts-mode.el
> @@ -233,7 +233,8 @@ c-ts-mode--font-lock-settings
>       (false) @font-lock-constant-face
>       (null) @font-lock-constant-face
>       ,@(when (eq mode 'cpp)
> -         '((this) @font-lock-constant-face)))
> +         '((this) @font-lock-constant-face
> +           (nullptr) @font-lock-constant-face)))
>  
>     :language mode
>     :feature 'keyword

Thanks!  Yuan, Will you apply this change?

Theo

bug#59878: [PATCH] c++-ts-mode: Highlight nullptr as a constant

[Yuan Fu]

Theodor Thornhill <theo@thornhill.no> writes:

> Hi!
>
> Brian Leung <leungbk@posteo.net> writes:
>> diff --git a/lisp/progmodes/c-ts-mode.el b/lisp/progmodes/c-ts-mode.el
>> index 0c66b4959e0..6f1488917a6 100644
>> --- a/lisp/progmodes/c-ts-mode.el
>> +++ b/lisp/progmodes/c-ts-mode.el
>> @@ -233,7 +233,8 @@ c-ts-mode--font-lock-settings
>>       (false) @font-lock-constant-face
>>       (null) @font-lock-constant-face
>>       ,@(when (eq mode 'cpp)
>> -         '((this) @font-lock-constant-face)))
>> +         '((this) @font-lock-constant-face
>> +           (nullptr) @font-lock-constant-face)))
>>  
>>     :language mode
>>     :feature 'keyword
>
> Thanks!  Yuan, Will you apply this change?

Applied, thanks!

Yuan

bug#59878: [PATCH] c++-ts-mode: Highlight nullptr as a constant

[Stefan Kangas]

Yuan Fu <casouri@gmail.com> writes:

> Applied, thanks!

I'm therefore also closing this bug.

bug#59878: [PATCH] c++-ts-mode: Highlight nullptr as a constant

[Yuan Fu]

> On Dec 7, 2022, at 4:19 PM, Stefan Kangas <stefankangas@gmail.com> wrote:
> 
> Yuan Fu <casouri@gmail.com> writes:
> 
>> Applied, thanks!
> 
> I'm therefore also closing this bug.

Ah I forgot to close this, thank you, as always.

Yuan