unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#60305: Help with hideshow
@ 2022-12-25  9:24 Yuan Fu
  2022-12-25  9:40 ` Eli Zaretskii
  0 siblings, 1 reply; 3+ messages in thread
From: Yuan Fu @ 2022-12-25  9:24 UTC (permalink / raw)
  To: 60305

Is anyone familiar with hideshow? I tried to add tree-sitter support for it but didn’t quite make it. 

I just generalized some defun functions so that one can define a “thing” with a regexp that matches node types. So now it should be relatively straightforward for each major mode to define a “block” thing, like they do for defun, and a hideshow-treesitter bridge can use treesit-thing-at-point, treesit-beginning-of-thing, etc, to support hideshow.

It would be great if someone familiar with hideshow would like to give it a try, or educate me how to set hs-special-modes-alist.

On the separate note, I wonder if the hideshow support can go on the release branch.

Thanks,
Yuan




^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#60305: Help with hideshow
  2022-12-25  9:24 bug#60305: Help with hideshow Yuan Fu
@ 2022-12-25  9:40 ` Eli Zaretskii
  2022-12-25 17:58   ` Yuan Fu
  0 siblings, 1 reply; 3+ messages in thread
From: Eli Zaretskii @ 2022-12-25  9:40 UTC (permalink / raw)
  To: Yuan Fu; +Cc: 60305

> From: Yuan Fu <casouri@gmail.com>
> Date: Sun, 25 Dec 2022 01:24:44 -0800
> 
> On the separate note, I wonder if the hideshow support can go on the release branch.

It depends on what it will look like.  If the addition of that doesn't
touch hideshow code used without tree-sitter, and if the tree-sitter
support is opt-in, I think we can have it on the release branch -- if
you manage to do this soon enough.  (I'm planning on a complete
feature freeze on the release branch in a week or so.)





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#60305: Help with hideshow
  2022-12-25  9:40 ` Eli Zaretskii
@ 2022-12-25 17:58   ` Yuan Fu
  0 siblings, 0 replies; 3+ messages in thread
From: Yuan Fu @ 2022-12-25 17:58 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 60305-done, 60305

Oops, this some how got sent to debbugs, I’ll resend to emacs-devel.

> On Dec 25, 2022, at 1:40 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> 
>> From: Yuan Fu <casouri@gmail.com>
>> Date: Sun, 25 Dec 2022 01:24:44 -0800
>> 
>> On the separate note, I wonder if the hideshow support can go on the release branch.
> 
> It depends on what it will look like.  If the addition of that doesn't
> touch hideshow code used without tree-sitter, and if the tree-sitter
> support is opt-in, I think we can have it on the release branch -- if
> you manage to do this soon enough.  (I'm planning on a complete
> feature freeze on the release branch in a week or so.)

In that case, going on master is probably better. Hideshow isn’t that critical or game-changing.

Yuan




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-12-25 17:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-25  9:24 bug#60305: Help with hideshow Yuan Fu
2022-12-25  9:40 ` Eli Zaretskii
2022-12-25 17:58   ` Yuan Fu

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).