bug#10050: 24.0.90; image files display image data only after drag and drop

bug#10050: 24.0.90; image files display image data only after drag and drop

[Adam Winiecki]

24.0.90; image files display image data only after drag and drop
This does not allow me to view the image.  The preferred behavior would be
for the image itself to display like in older versions.

-Adam



In GNU Emacs 24.0.90.1 (x86_64-apple-darwin, NS apple-appkit-1038.35)
 of 2011-10-20 on virtualmac.porkrind.org
Windowing system distributor `Apple', version 10.3.1138
configured using `configure  '--host=x86_64-apple-darwin' '--build=i686-apple-darwin' '--with-ns' 'build_alias=i686-apple-darwin' 'host_alias=x86_64-apple-darwin' 'CC=gcc -mmacosx-version-min=10.5''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: nil
  value of $XMODIFIERS: nil
  locale-coding-system: nil
  default enable-multibyte-characters: t

Major mode: ERC

Minor modes in effect:
  erc-list-mode: t
  erc-menu-mode: t
  erc-ring-mode: t
  erc-networks-mode: t
  erc-pcomplete-mode: t
  erc-track-mode: t
  erc-track-minor-mode: t
  erc-match-mode: t
  erc-button-mode: t
  erc-fill-mode: t
  erc-stamp-mode: t
  erc-netsplit-mode: t
  shell-dirtrack-mode: t
  erc-autojoin-mode: t
  erc-irccontrols-mode: t
  erc-noncommands-mode: t
  erc-move-to-prompt-mode: t
  erc-readonly-mode: t
  display-time-mode: t
  delete-selection-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t
  abbrev-mode: t

Recent input:
O S 4 <backspace> 5 ? SPC t h e SPC w o r r <backspace> 
l d SPC i c c <backspace> o n SPC i s SPC m i s s i 
n g <left> <left> <left> <left> <left> <left> <left> 
<left> <left> <left> n e x t SPC t o SPC t h e SPC 
s p a c e b a r SPC t h a t SPC u s u a l l y SPC b 
r i n g s SPC i t SPC u SPC <backspace> p SPC C-e , 
SPC e v e n SPC t h o u g h SPC I SPC h a v e SPC a 
d d e d SPC t h e SPC b k e <backspace> <backspace> 
<backspace> k e y b o a r d <return> C-x o C-x o C-x 
o d a b <tab> C-a C-k C-x o C-x o C-x k <return> C-x 
o C-x o C-x C-f <backspace> <backspace> <backspace> 
<backspace> <backspace> <backspace> <backspace> <backspace> 
<backspace> t o d o <return> C-x k <return> C-x b t 
o d o <return> M-< <return> <up> <return> <return> 
<up> <up> <return> SPC SPC 1 : 0 0 SPC s 
p r i n t SPC m e e t i n g <return> SPC SPC <ns-drag-file> 
C-_ C-x o C-x C-f C-a <right> <right> <right> <right> 
<right> <right> <right> <right> <right> <right> C-k 
<help-echo> <help-echo> <down-mouse-1> <mouse-1> C-x 
b # e <backspace> <backspace> M-x b u g <tab> <backspace> 
<backspace> <backspace> <backspace> <backspace> <backspace> 
<backspace> <backspace> p <tab> C-g M-x r e p <tab> 
C-g C-x b C-x b # C-g C-x b # e m <tab> <return> M-x 
r e p <tab> o r <tab> <return>

Recent messages:
(New file)
Mark set [2 times]
Undo!
completing-read-default: Command attempted to use minibuffer while in minibuffer
Quit
Making completion list...
Quit
completing-read-default: Command attempted to use minibuffer while in minibuffer
Quit
Making completion list...

Load-path shadows:
None found.

Features:
(shadow sort mail-extr message rfc822 mml mml-sec mm-decode mm-bodies
mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev
mail-utils gmm-utils mailheader emacsbug server etags ruby-mode cc-mode
cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars
cc-defs ind-util browse-url multi-isearch mule-util erc-log
network-stream starttls tls erc-menu erc-ring erc-networks erc-pcomplete
erc-track erc-match erc-button wid-edit erc-fill erc-stamp erc-netsplit
help-mode easymenu view pcmpl-unix vc-git ange-ftp tramp-ftp tramp-cache
tramp-sh tramp tramp-compat auth-source eieio byte-opt bytecomp
byte-compile cconv macroexp assoc gnus-util mm-util mail-prsvr
password-cache advice help-fns advice-preload tramp-loaddefs warnings cl
ansi-color shell pcomplete comint regexp-opt ring erc-join erc-goodies
erc erc-backend erc-compat format-spec thingatpt pp time allout delsel
disp-table edmacro kmacro time-date tooltip ediff-hook vc-hooks
lisp-float-type mwheel ns-win tool-bar dnd fontset image fringe
lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar
mouse jit-lock font-lock syntax facemenu font-core frame cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev
minibuffer loaddefs button faces cus-face files text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote make-network-process ns multi-tty
emacs)

bug#10050: 24.0.90; image files display image data only after drag and drop

[Jan Djärv]

Hello.

14 nov 2011 kl. 20:37 skrev Adam Winiecki:

> 24.0.90; image files display image data only after drag and drop
> This does not allow me to view the image.  The preferred behavior would be
> for the image itself to display like in older versions.
> 
> -Adam
> 
> 
> 
> In GNU Emacs 24.0.90.1 (x86_64-apple-darwin, NS apple-appkit-1038.35)
> of 2011-10-20 on virtualmac.porkrind.org
> Windowing system distributor `Apple', version 10.3.1138
> configured using `configure  '--host=x86_64-apple-darwin' '--build=i686-apple-darwin' '--with-ns' 'build_alias=i686-apple-darwin' 'host_alias=x86_64-apple-darwin' 'CC=gcc -mmacosx-version-min=10.5''
> 


The big problem is that dragging a file to Emacs on NS inserts the contents of that file to the current buffer instead of opening it as people normally expect, and indeed is what all other Emacs versions does.  It is like that in Emacs 23 also, so this is not a regression. But as we are in a feature freeze this will have to wait, even if the behaviour is stupid.  If Emacs would open dragged files in a new buffer, images would be shown as images.

	Jan D.

bug#10050: 24.0.90; image files display image data only after drag and drop

[Glenn Morris]

Jan Djärv wrote:

> The big problem is that dragging a file to Emacs on NS inserts the
> contents of that file to the current buffer instead of opening it as
> people normally expect, and indeed is what all other Emacs versions
> does. It is like that in Emacs 23 also, so this is not a regression.
> But as we are in a feature freeze this will have to wait, even if the
> behaviour is stupid. If Emacs would open dragged files in a new
> buffer, images would be shown as images.

Is it just a question of doing what it says in the manual, or is more
needed?

    The default behavior when a user drags files from another application
    into an Emacs frame is to insert the contents of all the dragged files
    into the current buffer.  To remap the `ns-drag-file' event to open the
    dragged files in the current frame use the following line:
 
         (define-key global-map [ns-drag-file] 'ns-find-file)

Maybe that change is sensible and safe enough for 24.1.
(I can't even test it so I wouldn't know.)

bug#10050: 24.0.90; image files display image data only after drag and drop

[Jan Djärv]

Hello.


22 feb 2012 kl. 09:08 skrev Glenn Morris <rgm@gnu.org>:

> Jan Djärv wrote:
> 
>> The big problem is that dragging a file to Emacs on NS inserts the
>> contents of that file to the current buffer instead of opening it as
>> people normally expect, and indeed is what all other Emacs versions
>> does. It is like that in Emacs 23 also, so this is not a regression.
>> But as we are in a feature freeze this will have to wait, even if the
>> behaviour is stupid. If Emacs would open dragged files in a new
>> buffer, images would be shown as images.
> 
> Is it just a question of doing what it says in the manual, or is more
> needed?
> 

No, that and changing the manual. 
The bindning to change is in ns-win.el


>    The default behavior when a user drags files from another application
>    into an Emacs frame is to insert the contents of all the dragged files
>    into the current buffer.  To remap the `ns-drag-file' event to open the
>    dragged files in the current frame use the following line:
> 
>         (define-key global-map [ns-drag-file] 'ns-find-file)
> 
> Maybe that change is sensible and safe enough for 24.1.
> (I can't even test it so I wouldn't know.)

If you want I can do it. I have been  running with that change in my local copy for about a year now.

    Jan D. 

bug#10050: 24.0.90; image files display image data only after drag and drop

[Glenn Morris]

Jan Djärv wrote:

> If you want I can do it. I have been running with that change in my
> local copy for about a year now.

It's not my call, but to me it sounds appropriate to change this for
24.1

bug#10050: 24.0.90; image files display image data only after drag and drop

[Chong Yidong]

Jan Djärv <jan.h.d@swipnet.se> writes:

>>         (define-key global-map [ns-drag-file] 'ns-find-file)
>> 
>> Maybe that change is sensible and safe enough for 24.1.
>> (I can't even test it so I wouldn't know.)
>
> If you want I can do it. I have been running with that change in my
> local copy for about a year now.

Yes, please go ahead.  I think it's a misfeature that the NS port does
d&d differently from the other platforms.

bug#10050: 24.0.90; image files display image data only after drag and drop

[Jan Djärv]

Hello.

25 feb 2012 kl. 04:59 skrev Chong Yidong:

> Jan Djärv <jan.h.d@swipnet.se> writes:
> 
>>>        (define-key global-map [ns-drag-file] 'ns-find-file)
>>> 
>>> Maybe that change is sensible and safe enough for 24.1.
>>> (I can't even test it so I wouldn't know.)
>> 
>> If you want I can do it. I have been running with that change in my
>> local copy for about a year now.
> 
> Yes, please go ahead.  I think it's a misfeature that the NS port does
> d&d differently from the other platforms.

Done.  Documentation updated.  NEWS not updated though, should it be?

	Jan D.

bug#10050: 24.0.90; image files display image data only after drag and drop

[Chong Yidong]

Jan Djärv <jan.h.d@swipnet.se> writes:

> Done.  Documentation updated.  NEWS not updated though, should it be?

I've committed a NEWS entry.