From: Jim Porter <jporterbugs@gmail.com>
To: Morgan Smith <Morgan.J.Smith@outlook.com>
Cc: 63778@debbugs.gnu.org
Subject: bug#63778: [PATCH] Use comint-pager in eshell
Date: Mon, 29 May 2023 22:14:18 -0700 [thread overview]
Message-ID: <635470cf-103b-8383-0bc5-9b69de4f324d@gmail.com> (raw)
In-Reply-To: <DM5PR03MB3163EE8C8D3F3CF569F71754C54A9@DM5PR03MB3163.namprd03.prod.outlook.com>
On 5/28/2023 11:23 PM, Morgan Smith wrote:
> My main pain point was trying to figure out how to maintain the ability
> to set/unset the PAGER variable. These current patches allow you to
> set/unset the PAGER variable iff you don't set comint-pager. It even
> allows you to do stuff like 'PAGER=cat git log' (see
> eshell-handle-local-variables) without modifying buffer state (as it
> should). Maintaining those capabilities when comint-pager is set seems
> very difficult so I gave up.
Thanks. I'll think this over for a bit and try some stuff out locally
too. Looking at your second patch, I think I see where the pain lies:
when getting PAGER, it always treats 'comint-pager' as taking precedence
over the real env var, but when setting PAGER, it only sets the env var.
Therefore, with 'comint-pager' set, setting PAGER won't have the
intended effect (though maybe this doesn't apply to local variables).
There's probably a nice way to do this, but it might involve some tweaks
to how Eshell handles variable aliases in general. I'll look into it more.
next prev parent reply other threads:[~2023-05-30 5:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-28 22:45 bug#63778: [PATCH] Use comint-pager in eshell Morgan Smith
2023-05-28 23:06 ` Jim Porter
[not found] ` <DM5PR03MB31631AA2F61C4C656FF6AFCFC54A9@DM5PR03MB3163.namprd03.prod.outlook.com>
2023-05-29 2:26 ` Morgan Smith
2023-05-29 2:41 ` Jim Porter
2023-05-29 6:23 ` Morgan Smith
2023-05-30 5:14 ` Jim Porter [this message]
2023-08-23 23:58 ` Jim Porter
2023-05-29 11:46 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=635470cf-103b-8383-0bc5-9b69de4f324d@gmail.com \
--to=jporterbugs@gmail.com \
--cc=63778@debbugs.gnu.org \
--cc=Morgan.J.Smith@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).