From: Jim Porter <jporterbugs@gmail.com>
To: Morgan Smith <Morgan.J.Smith@outlook.com>, 63778@debbugs.gnu.org
Subject: bug#63778: [PATCH] Use comint-pager in eshell
Date: Sun, 28 May 2023 16:06:18 -0700 [thread overview]
Message-ID: <36a8613a-7601-14d5-c659-3bd86708b63b@gmail.com> (raw)
In-Reply-To: <DM5PR03MB31630ED6F4212C8995D23136C5459@DM5PR03MB3163.namprd03.prod.outlook.com>
On 5/28/2023 3:45 PM, Morgan Smith wrote:
> I know many people set PAGER=cat for eshell so I wanted to add support
> to eshell for this recent feature that was added (comint-pager).
Thanks for the patch. While I'd use this myself, I'm not sure it should
be the default though. Eshell lets you define visual commands
('eshell-visual-commands', 'eshell-visual-subcommands') that will open
up in M-x term. That way, you can use "less" (or whatever your default
pager is) as usual. If you set PAGER to "cat" or something similar, then
you likely wouldn't get the benefit of this visual command support.
Maybe we could do something where we set PAGER like in your patch, but
only if Eshell doesn't think the command is visual? Perhaps you could
keep the definition of PAGER in esh-var.el as you've done here, but then
in em-term.el, add an appropriate override for it? That way, a user who
disables the eshell-term module will always get PAGER=cat. Users who do
use eshell-term would get a behavior compatible with visual commands.
next prev parent reply other threads:[~2023-05-28 23:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-28 22:45 bug#63778: [PATCH] Use comint-pager in eshell Morgan Smith
2023-05-28 23:06 ` Jim Porter [this message]
[not found] ` <DM5PR03MB31631AA2F61C4C656FF6AFCFC54A9@DM5PR03MB3163.namprd03.prod.outlook.com>
2023-05-29 2:26 ` Morgan Smith
2023-05-29 2:41 ` Jim Porter
2023-05-29 6:23 ` Morgan Smith
2023-05-30 5:14 ` Jim Porter
2023-08-23 23:58 ` Jim Porter
2023-05-29 11:46 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36a8613a-7601-14d5-c659-3bd86708b63b@gmail.com \
--to=jporterbugs@gmail.com \
--cc=63778@debbugs.gnu.org \
--cc=Morgan.J.Smith@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).