* bug#11812: emacs24 -- Addition of language/persian.el and updates to leim/quail/persian.el
@ 2012-06-28 22:36 Mohsen BANAN
2012-08-06 7:39 ` Glenn Morris
0 siblings, 1 reply; 4+ messages in thread
From: Mohsen BANAN @ 2012-06-28 22:36 UTC (permalink / raw)
To: 11812
[-- Attachment #1: Type: text/plain, Size: 561 bytes --]
In the attached tar file are 3 files:
emacs24-banan-patches/lisp/language/persian.el
Is a new file that adds persian as an emacs
language.
emacs24-banan-patches/lisp/loadup.el.diff
Is the (load "language/persian") added to lisp/loadup.el
emacs24-banan-patches/leim/quail/persian.el.diff
Is an update and bug fix to leim/quail/persian.el.
Based on experience and feedback some keys are
mapped differently.
Additional documentation has been added.
Please add the new file and apply the context diffs.
Thank you in advance.
...Mohsen
[-- Attachment #2: emacs24-banan-patches.tar --]
[-- Type: application/x-tar, Size: 20480 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#11812: emacs24 -- Addition of language/persian.el and updates to leim/quail/persian.el
2012-06-28 22:36 bug#11812: emacs24 -- Addition of language/persian.el and updates to leim/quail/persian.el Mohsen BANAN
@ 2012-08-06 7:39 ` Glenn Morris
2012-08-06 20:52 ` Glenn Morris
0 siblings, 1 reply; 4+ messages in thread
From: Glenn Morris @ 2012-08-06 7:39 UTC (permalink / raw)
To: 11812-done
Version: 24.2
Mohsen BANAN wrote:
> emacs24-banan-patches/lisp/language/persian.el
> Is a new file that adds persian as an emacs language.
Applied, thanks.
> emacs24-banan-patches/leim/quail/persian.el.diff
> Is an update and bug fix to leim/quail/persian.el.
> Based on experience and feedback some keys are mapped differently.
I have no way to judge this, but since you are the author I applied it.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#11812: emacs24 -- Addition of language/persian.el and updates to leim/quail/persian.el
2012-08-06 7:39 ` Glenn Morris
@ 2012-08-06 20:52 ` Glenn Morris
2012-08-08 6:44 ` list-general
0 siblings, 1 reply; 4+ messages in thread
From: Glenn Morris @ 2012-08-06 20:52 UTC (permalink / raw)
To: 11812; +Cc: list-general
Glenn Morris wrote:
>> emacs24-banan-patches/lisp/language/persian.el
>> Is a new file that adds persian as an emacs language.
>
> Applied, thanks.
So I actually looked at the file, and its entire contents are extremely
similar to the already existing "Arabic" section of
language/misc-lang.el. The only differences seem to be to replace
"Arabic" with "Persian", to change the sample text, and change the
input-method from "arabic" to "farsi-transliterate-banan".
Surely there is some inconsistency here?
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#11812: emacs24 -- Addition of language/persian.el and updates to leim/quail/persian.el
2012-08-06 20:52 ` Glenn Morris
@ 2012-08-08 6:44 ` list-general
0 siblings, 0 replies; 4+ messages in thread
From: list-general @ 2012-08-08 6:44 UTC (permalink / raw)
To: Glenn Morris; +Cc: 11812
>>>>> On Mon, 06 Aug 2012 16:52:12 -0400, Glenn Morris <rgm@gnu.org> said:
GM> Glenn Morris wrote:
>>> emacs24-banan-patches/lisp/language/persian.el
>>> Is a new file that adds persian as an emacs language.
>>
>> Applied, thanks.
GM> So I actually looked at the file, and its entire contents are extremely
GM> similar to the already existing "Arabic" section of
GM> language/misc-lang.el. The only differences seem to be to replace
GM> "Arabic" with "Persian", to change the sample text, and change the
GM> input-method from "arabic" to "farsi-transliterate-banan".
GM> Surely there is some inconsistency here?
Thank you for applying those patches.
I tried the latest version and addition of Persian
to "Set Language Environment" works fine.
Persian and Arabic are different languages.
Persian is an Indo-European langauge.
Arabic is a non Indo-European langauge.
Persian script uses the Arabic alphabet.
The charset used for Persian and Arabic is the
same. Some of the chars used for Persian and
Arabic are common and some are separate.
So, the part of language/persian.el that is
coding-system and charset related is same as the
arabic part of language/misc-lang.el.
Input methods for Persian and Arabic are of course
separately specified in quail/arabic.el and
quail/persian.el. And the default input method for
each language specification is in
set-language-info-alist.
So with what is in place, things work, but things
are not clean.
I am not familiar with the history of how
language/misc-lang.el evolved.
I think the right way of doing it is:
- Create a language/persoarabic.el that is
the common part of language/persian.el
and language/arabic.el (see next).
- Create a language/arabic.el which is just the
arabic part of language/misc-lang.el
and which loads language/persoarabic.el
- Make language/persian.el also load the common
part as language/persoarabic.el
More broadly speaking, I think
language/misc-lang.el needs to be cleaned up so
that alphabeticly sorted list of languages in "Set
Language Environment" is cleaner.
A bit later, perhaps we should bring this up in
the developers list and do that cleanup.
For now, Persian has been added as an emacs
language. That is a good thing.
Thanks again for applying those patches.
...Mohsen
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-08-08 6:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-28 22:36 bug#11812: emacs24 -- Addition of language/persian.el and updates to leim/quail/persian.el Mohsen BANAN
2012-08-06 7:39 ` Glenn Morris
2012-08-06 20:52 ` Glenn Morris
2012-08-08 6:44 ` list-general
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).