bug#46917: 28.0.50; error when unloading feature after loading elp

[Mauro Aranda <maurooaranda@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 513 bytes --]

tags 46917 patch
quit


Mauro Aranda <maurooaranda@gmail.com> writes:

> Starting from emacs -Q, do:
>
> 1. In the *scratch* buffer, type and evaluate (in any order):
> (require 'autoarg) ; Whatever feature.
> (require 'elp)
>
> 2. Type and evaluate
> (unload-feature 'autoarg)
>
> 3. Emacs signals an error:
> "Unsupported qualifiers in function loadhist-unload-element: (:before :extra \"elp\")"
>

Looks like the problem is the order of the qualifiers; the attached
patch should fix it.

Best regards,
Mauro.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Patch --]
[-- Type: text/x-patch, Size: 953 bytes --]

From c05dda94c490a93c360bb5b71ddae7eb1f9cdcb6 Mon Sep 17 00:00:00 2001
From: Mauro Aranda <maurooaranda@gmail.com>
Date: Thu, 4 Mar 2021 09:47:39 -0300
Subject: [PATCH] Fix qualifiers order for loadhist-unload-element in elp.el

* lisp/emacs-lisp/elp.el (loadhist-unload-element): The :extra
qualifier is expected to come before the other qualifiers, so do
that.  (Bug#46917)
---
 lisp/emacs-lisp/elp.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/emacs-lisp/elp.el b/lisp/emacs-lisp/elp.el
index cc2927caf4..411ea2af69 100644
--- a/lisp/emacs-lisp/elp.el
+++ b/lisp/emacs-lisp/elp.el
@@ -583,7 +583,7 @@ elp-unload-function
   ;; continue standard unloading
   nil)
 
-(cl-defmethod loadhist-unload-element :before :extra "elp" ((x (head defun)))
+(cl-defmethod loadhist-unload-element :extra "elp" :before ((x (head defun)))
   "Un-instrument before unloading a function."
   (elp-restore-function (cdr x)))
 
-- 
2.30.0