From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#46917: 28.0.50; error when unloading feature after loading elp Date: Thu, 04 Mar 2021 09:56:06 -0300 Message-ID: <6040d8e9.1c69fb81.a0b83.7e5d@mx.google.com> References: <6040d799.1c69fb81.936e9.ec05@mx.google.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30940"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) To: 46917@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 04 13:57:15 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHnXX-0007vs-6x for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Mar 2021 13:57:15 +0100 Original-Received: from localhost ([::1]:59748 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHnXW-00045e-6R for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Mar 2021 07:57:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56916) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHnXK-00043Y-F9 for bug-gnu-emacs@gnu.org; Thu, 04 Mar 2021 07:57:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46524) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lHnXK-0006zD-7F for bug-gnu-emacs@gnu.org; Thu, 04 Mar 2021 07:57:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lHnXK-0007zM-5m for bug-gnu-emacs@gnu.org; Thu, 04 Mar 2021 07:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Mar 2021 12:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46917 X-GNU-PR-Package: emacs Original-Received: via spool by 46917-submit@debbugs.gnu.org id=B46917.161486257730629 (code B ref 46917); Thu, 04 Mar 2021 12:57:02 +0000 Original-Received: (at 46917) by debbugs.gnu.org; 4 Mar 2021 12:56:17 +0000 Original-Received: from localhost ([127.0.0.1]:58068 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lHnWb-0007xx-JE for submit@debbugs.gnu.org; Thu, 04 Mar 2021 07:56:17 -0500 Original-Received: from mail-qk1-f174.google.com ([209.85.222.174]:45498) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lHnWZ-0007xd-PS for 46917@debbugs.gnu.org; Thu, 04 Mar 2021 07:56:16 -0500 Original-Received: by mail-qk1-f174.google.com with SMTP id z128so27513754qkc.12 for <46917@debbugs.gnu.org>; Thu, 04 Mar 2021 04:56:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:from:to:subject:references:date:in-reply-to:user-agent :mime-version; bh=6HLTzvN23O3StZiZ6RFnweYGfdDLxu8RZ42t4HnJoEU=; b=RtC5Kz/5KqjCWw2v7hP3jyg6dbAaQrAuRAS8ZYBHea0PjaYl0aR0xw46qyEgbtHMjv hOhEElLh9Adu+H3Tywpv7pBz45ltmfNQhj+0XblehWdfsc7MDb95h2G3d7pjB3NRg4yD dtQS2Nd6yZ0GuvC7yMsZi006yUqX+E5I2GXmZz/hqlI3dJdIHDrAYsUZBlxUcS4a6WCt l4KA7N/41rlwcwyf0bXoNiCSE4EM8wRq2YkTgxUJpXUpm3zTQFptFwQdnjP8NqoQ1YMh R0aU1Tbl7qFVuSkndzDoluf5SayJAcsw4TGg2h2xzOXv7S4fbhKk2Tv1kUuB8mz59joe 5Cfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:from:to:subject:references:date :in-reply-to:user-agent:mime-version; bh=6HLTzvN23O3StZiZ6RFnweYGfdDLxu8RZ42t4HnJoEU=; b=W7Z9p527ihgvhqh7UTHgtjwujNbfq7IHoZq9+n7g9hM0bzIUHeiaxpKb+gN3nsW3Iy 64Y9ig3TwMmblsoyKx/dzc9WYlf32FbDig5F53FB8/qxyKPLkZ7jvZpeQ5wBH8Ba4J8s FYXJTX//TSZwBIbzUxFjCyur2Fb0GjrnB9RQNYoNg/FSfgk3Y8ui1UK6tXp1q06wHfiS jUsmxleDMFBCMA064RqG9GvDypFZC4MCV/z2pPPqSCX+T8PRhGFkC8Ky96+VgtyBYxiE BcPDPFZEABTLR4Nvzr9OHk9RChb+hMc9V6J6qhKY/6CXatgv4DmU3q536LlomAF2tAtG WCXQ== X-Gm-Message-State: AOAM532fBlWdI9Wfh9o6QASWKcm2zYNyhB7INaJDPah3MywfnJuixt6C YGYV9Lzbniy6jp1gZb/VAYusiBb2PmEnKA== X-Google-Smtp-Source: ABdhPJzH3HLEYZzwdtJ3+BGNO4Tq9XGljcx1YEx+8bP27ndvTAV0YsrkXap+aSKwF8y6PFhAXKUyBA== X-Received: by 2002:a37:b406:: with SMTP id d6mr3962880qkf.4.1614862569823; Thu, 04 Mar 2021 04:56:09 -0800 (PST) Original-Received: from tbb-desktop ([201.213.132.172]) by smtp.gmail.com with ESMTPSA id 131sm19043100qkl.74.2021.03.04.04.56.08 for <46917@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 04 Mar 2021 04:56:09 -0800 (PST) X-Google-Original-Message-ID: <87r1kvqdqx.fsf@maurooaranda@gmail.com> In-Reply-To: <6040d799.1c69fb81.936e9.ec05@mx.google.com> (Mauro Aranda's message of "Thu, 04 Mar 2021 09:50:30 -0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201385 Archived-At: --=-=-= Content-Type: text/plain tags 46917 patch quit Mauro Aranda writes: > Starting from emacs -Q, do: > > 1. In the *scratch* buffer, type and evaluate (in any order): > (require 'autoarg) ; Whatever feature. > (require 'elp) > > 2. Type and evaluate > (unload-feature 'autoarg) > > 3. Emacs signals an error: > "Unsupported qualifiers in function loadhist-unload-element: (:before :extra \"elp\")" > Looks like the problem is the order of the qualifiers; the attached patch should fix it. Best regards, Mauro. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Fix-qualifiers-order-for-loadhist-unload-element-in-.patch Content-Description: Patch >From c05dda94c490a93c360bb5b71ddae7eb1f9cdcb6 Mon Sep 17 00:00:00 2001 From: Mauro Aranda Date: Thu, 4 Mar 2021 09:47:39 -0300 Subject: [PATCH] Fix qualifiers order for loadhist-unload-element in elp.el * lisp/emacs-lisp/elp.el (loadhist-unload-element): The :extra qualifier is expected to come before the other qualifiers, so do that. (Bug#46917) --- lisp/emacs-lisp/elp.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/emacs-lisp/elp.el b/lisp/emacs-lisp/elp.el index cc2927caf4..411ea2af69 100644 --- a/lisp/emacs-lisp/elp.el +++ b/lisp/emacs-lisp/elp.el @@ -583,7 +583,7 @@ elp-unload-function ;; continue standard unloading nil) -(cl-defmethod loadhist-unload-element :before :extra "elp" ((x (head defun))) +(cl-defmethod loadhist-unload-element :extra "elp" :before ((x (head defun))) "Un-instrument before unloading a function." (elp-restore-function (cdr x))) -- 2.30.0 --=-=-=--