From: Dmitry Gutov <dgutov@yandex.ru>
To: "Kévin Le Gouguec" <kevin.legouguec@gmail.com>
Cc: 45765-done@debbugs.gnu.org, Juri Linkov <juri@linkov.net>
Subject: bug#45765: [PATCH] 28.0.50; Change default-directory before prompting in project-compile
Date: Sat, 16 Jan 2021 05:51:47 +0200 [thread overview]
Message-ID: <5ad49c92-6a29-ff7f-6b2a-2c3e5505334d@yandex.ru> (raw)
In-Reply-To: <8735z4tyb4.fsf@gmail.com>
On 13.01.2021 21:46, Kévin Le Gouguec wrote:
> Dmitry Gutov <dgutov@yandex.ru> writes:
>
>> I'm not a big fan of the 'interactive' argument. It could be replaced
>> by using (called-interactively-p 'interactive), though I'm not sure
>> how idiomatic that is.
>
> Not necessarily a fan either, but my takeaway from recent discussions on
> emacs-devel is that the argument is preferred to called-interactively-p,
> which should only be used when a function's arglist is set in stone.
>
> <E1k7A3J-0005gG-4K@fencepost.gnu.org>
> https://lists.gnu.org/archive/html/emacs-devel/2020-08/msg00463.html
>
> <jwvzh6ubtbe.fsf-monnier+emacs@gnu.org>
> https://lists.gnu.org/archive/html/emacs-devel/2020-08/msg00472.html
>
> I see a few dozen hits for "&optional \([\w-]+ \)*interactive)" under
> lisp/, so it seems to be an established practice.
All right, that makes sense. It will help the next time such question
comes up.
> PS: I've just seen Juri's reponse in bug#45765#26; I'm glad there is a
> consensus on the first patch, because after looking at more in-tree
> examples of optional INTERACTIVE arguments, I found myself agonizing
> over spelling the spec (list nil nil t), '(nil nil t), or "i\ni\np".
I know the feeling ;-)
Patch installed, closing. Thanks again.
next prev parent reply other threads:[~2021-01-16 3:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-10 12:57 bug#45765: [PATCH] 28.0.50; Change default-directory before prompting in project-compile Kévin Le Gouguec
2021-01-11 0:47 ` Dmitry Gutov
2021-01-11 18:35 ` Juri Linkov
2021-01-11 19:13 ` Dmitry Gutov
2021-01-11 21:24 ` Kévin Le Gouguec
2021-01-12 18:46 ` Juri Linkov
2021-01-13 1:06 ` Dmitry Gutov
2021-01-13 18:05 ` Juri Linkov
2021-01-13 19:46 ` Kévin Le Gouguec
2021-01-16 3:51 ` Dmitry Gutov [this message]
2021-01-19 17:38 ` Juri Linkov
2021-01-19 19:50 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ad49c92-6a29-ff7f-6b2a-2c3e5505334d@yandex.ru \
--to=dgutov@yandex.ru \
--cc=45765-done@debbugs.gnu.org \
--cc=juri@linkov.net \
--cc=kevin.legouguec@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).