From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#45765: [PATCH] 28.0.50; Change default-directory before prompting in project-compile Date: Sat, 16 Jan 2021 05:51:47 +0200 Message-ID: <5ad49c92-6a29-ff7f-6b2a-2c3e5505334d@yandex.ru> References: <87bldx2bmk.fsf@gmail.com> <87ft37bbp0.fsf@mail.linkov.net> <01a19619-e48a-825f-b459-5b04df402ad6@yandex.ru> <87zh1fyxo0.fsf@gmail.com> <87lfcywhyc.fsf@mail.linkov.net> <6e5456e4-a5ac-3e54-2ced-0116a6e7a9dc@yandex.ru> <8735z4tyb4.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35448"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 Cc: 45765-done@debbugs.gnu.org, Juri Linkov To: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 16 04:52:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l0cdJ-00095B-60 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 16 Jan 2021 04:52:13 +0100 Original-Received: from localhost ([::1]:55000 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l0cdH-0004Af-Ob for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 Jan 2021 22:52:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57302) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l0cd8-0004A2-LB for bug-gnu-emacs@gnu.org; Fri, 15 Jan 2021 22:52:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58902) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l0cd8-00086o-4n for bug-gnu-emacs@gnu.org; Fri, 15 Jan 2021 22:52:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l0cd8-0001YL-3h for bug-gnu-emacs@gnu.org; Fri, 15 Jan 2021 22:52:02 -0500 Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Jan 2021 03:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 45765 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 45765@debbugs.gnu.org, dgutov@yandex.ru, kevin.legouguec@gmail.com Original-Received: via spool by 45765-done@debbugs.gnu.org id=D45765.16107691195956 (code D ref 45765); Sat, 16 Jan 2021 03:52:01 +0000 Original-Received: (at 45765-done) by debbugs.gnu.org; 16 Jan 2021 03:51:59 +0000 Original-Received: from localhost ([127.0.0.1]:42215 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l0cd5-0001Xz-AX for submit@debbugs.gnu.org; Fri, 15 Jan 2021 22:51:59 -0500 Original-Received: from mail-ed1-f53.google.com ([209.85.208.53]:36707) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l0cd3-0001Xn-Aj for 45765-done@debbugs.gnu.org; Fri, 15 Jan 2021 22:51:58 -0500 Original-Received: by mail-ed1-f53.google.com with SMTP id b2so11756801edm.3 for <45765-done@debbugs.gnu.org>; Fri, 15 Jan 2021 19:51:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=6zjUPykM+gw7pzlw/1sbOYudWnX8aa6ZuNxWkGVmr3o=; b=LLHQ1XuXQbAiUq+ve6x4ZeRWUgO1CXrcdxxXpm1dQbkTQosdBabjYawiXHFO4P0Je5 9WYzJppktA9WG2bl+jTHp4hMSPgoq9vVvTJ5K2SRIk2/x/l2tlBgMkeRH4pfTjb5t2WR K0R7XYny0qRU9i9sCXTjnjAnRLZgX2dxpmcGrjdeXJhNHiyQPkXcQW7BQ8g7iNKAop5V 9tftU041PfQvl3pvu3oUNnwCIdMv+ZdjcLN3y0d8wzpAf4esteR+xjyZ+kVVE6Qqs75p /kSVv0ygFRt+Np/sQ9kZdQQnrfTO1XPu/6Mt4dFhjUk4ZYfeLDqjDtJwvyM2EeqOIIym XcLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6zjUPykM+gw7pzlw/1sbOYudWnX8aa6ZuNxWkGVmr3o=; b=C7xqa/nrL/GVUvT3/DQYPQ1fOPsOUtq0/SQPS1syc7RYWUzg14/2d0iKERzZszlxFy oc9B4dMHh1vId4mwA151whYMXCTxVID4IpZ5AHi1yGepAkur9goV6P4vRtxw5iaYkvwn nQZu12pF6iuU38VNZoqDfeT0MDQDqPF+snvEb0ZeEN7GMsP6WQsf7MCwNkaOeko4d4hW 0Lyq8Sd9b24URgkSSZR5UnL8zKsEfwLZiYraju6RwYdCH07l7bkFYA+GR6MVX7YIjm7h d81M6qNu74z9jGYemAq53e1vvozOouVM0Nr8ca1am/FcI/uUdvcYr+b5jfyarYogv6EQ b9Qg== X-Gm-Message-State: AOAM532lD567DuB1XsuXiKV+8Kd1Y5plo3zxKJThKVJAf4lWypK7hnsV Njh0lnHxxPtlu8SrGJa7DNg= X-Google-Smtp-Source: ABdhPJz2vkT6HHm/d89yHA5tlh3/Qol57tPEF/tx1hlm0k2mIjkIN/5TeIIsq7YsnwPaiNiv62LDKQ== X-Received: by 2002:aa7:db85:: with SMTP id u5mr4863766edt.107.1610769111539; Fri, 15 Jan 2021 19:51:51 -0800 (PST) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id k6sm5259482ejb.84.2021.01.15.19.51.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Jan 2021 19:51:50 -0800 (PST) In-Reply-To: <8735z4tyb4.fsf@gmail.com> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:198007 Archived-At: On 13.01.2021 21:46, Kévin Le Gouguec wrote: > Dmitry Gutov writes: > >> I'm not a big fan of the 'interactive' argument. It could be replaced >> by using (called-interactively-p 'interactive), though I'm not sure >> how idiomatic that is. > > Not necessarily a fan either, but my takeaway from recent discussions on > emacs-devel is that the argument is preferred to called-interactively-p, > which should only be used when a function's arglist is set in stone. > > > https://lists.gnu.org/archive/html/emacs-devel/2020-08/msg00463.html > > > https://lists.gnu.org/archive/html/emacs-devel/2020-08/msg00472.html > > I see a few dozen hits for "&optional \([\w-]+ \)*interactive)" under > lisp/, so it seems to be an established practice. All right, that makes sense. It will help the next time such question comes up. > PS: I've just seen Juri's reponse in bug#45765#26; I'm glad there is a > consensus on the first patch, because after looking at more in-tree > examples of optional INTERACTIVE arguments, I found myself agonizing > over spelling the spec (list nil nil t), '(nil nil t), or "i\ni\np". I know the feeling ;-) Patch installed, closing. Thanks again.